Re: Urgent: kirigami unittest broken

[Marco Martin]

On Sat, Jul 2, 2022 at 3:17 PM David Faure  wrote:
>
> On samedi 2 juillet 2022 15:09:21 CEST ivan tkachenko wrote:
> > https://invent.kde.org/frameworks/kirigami/-/commit/
> > 7775fea13c02c3bf836f5c0bf0580284d0f3904d
> >
> > Should be good now. Again, sorry for the trouble.
>
> All green (well, blue), thanks Ivan, that was quick!
>
Thanks Ivan indeed :)

This may mitigate the problem in the future,
https://invent.kde.org/frameworks/kirigami/-/merge_requests/588
requiring tests passing only on BSD for now as on linux being a bunch of
qt6 porting is still missing (like things depending on custom shaders)
they are still expected to fail


-- 
Marco Martin

Re: Urgent: kirigami unittest broken

[David Faure]

On samedi 2 juillet 2022 15:09:21 CEST ivan tkachenko wrote:
> https://invent.kde.org/frameworks/kirigami/-/commit/
> 7775fea13c02c3bf836f5c0bf0580284d0f3904d
> 
> Should be good now. Again, sorry for the trouble.

All green (well, blue), thanks Ivan, that was quick!

https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.15/job/kirigami/job/kf5-qt5%20SUSEQt5.15/

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Urgent: kirigami unittest broken

[David Faure]

Hi Kirigami people,

Is someone working on fixing the regression in the kirigami unittest, or are we 
releasing it broken?

FAIL!  : Kirigami::KeyboardNavigation::test_press() 'wait for signal 
lastKeyChanged' returned FALSE. ()
   Loc: [/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 
SUSEQt5.15/autotests/tst_keynavigation.qml(52)]

Jenkins history says "Make JavaScript cleaner and stricter" is when this 
regressed (but sometimes it's not related, if something changed in a dependency 
or in the CI environment).

https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.15/job/kirigami/job/kf5-qt5%20SUSEQt5.15/1052/

On vendredi 1 juillet 2022 18:16:59 CEST CI System wrote:
>   BUILD UNSTABLE
> Build
> URL   https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5
> .15/1060/ Project:kf5-qt5 SUSEQt5.15
> Date of build:Fri, 01 Jul 2022 16:12:19 +
> Build duration:   4 min 40 sec and counting
> 
> 
> 
> BUILD ARTIFACTS
> 
> acc/KF5Kirigami2-5.96.0.xml
> 
> 
> 
> JUnit Tests
> Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s),
> Total: 1 test(s) Name:
> projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt515
> Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16
> test(s)
> 
> Failed:
> projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt515.au
> totests.tst_keynavigation.qml
> 
> 
> 
> Cobertura Report
> Project Coverage Summary
> Name  PackagesFiles   Classes Lines   Conditionals
> Cobertura Coverage Report 80% (4/5)   60% (30/50) 60% (30/50) 
> 47%
> (2815/6019)   34% (1169/3446) Coverage Breakdown by Package
> Name  Files   Classes Lines   Conditionals
> autotests 100% (1/1)  100% (1/1)  100% (6/6)  100% (0/0)
> examples.applicationitemapp   0% (0/1)0% (0/1)0% (0/8)
> 100% (0/0)
> src   67% (20/30) 67% (20/30) 48% (2195/4617) 34% (948/2812)
> src.libkirigami   80% (8/10)  80% (8/10)  56% (588/1055)  44% 
> (215/490)
> src.scenegraph13% (1/8)   13% (1/8)   8% (26/333) 4% 
> (6/144)


-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5