Re: kde4support: kstandarddirs_unittest fix

2013-12-28 Thread David Faure
On Monday 23 December 2013 14:51:19 Alex Merry wrote: > If $PREFIX/share/applications does not exist, KStandardDirs will not add > it. It will then notice that nothing matching the installation prefix > was added, and add installPath("xdgdata-apps"), which is > $PREFIX/share/applications/kde5/. O

Re: kde4support: kstandarddirs_unittest fix

2013-12-28 Thread David Faure
On Friday 27 December 2013 11:38:08 Alex Merry wrote: > On 27/12/13 11:30, Kevin Ottens wrote: > > On Friday 27 December 2013 11:22:57 Alex Merry wrote: > >> On 27/12/13 11:04, Kevin Ottens wrote: > >>> On Monday 23 December 2013 14:51:19 Alex Merry wrote: > Actually, I think we should just in

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Alex Merry
On 27/12/13 11:30, Kevin Ottens wrote: > On Friday 27 December 2013 11:22:57 Alex Merry wrote: >> On 27/12/13 11:04, Kevin Ottens wrote: >>> On Monday 23 December 2013 14:51:19 Alex Merry wrote: Actually, I think we should just install application files directly in share/applications. (ie

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Kevin Ottens
On Friday 27 December 2013 11:22:57 Alex Merry wrote: > On 27/12/13 11:04, Kevin Ottens wrote: > > On Monday 23 December 2013 14:51:19 Alex Merry wrote: > >> Actually, I think we should just install application files directly in > >> share/applications. (ie: change the value of XDG_APPS_INSTALL_DIR

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Alex Merry
On 27/12/13 11:04, Kevin Ottens wrote: > On Monday 23 December 2013 14:51:19 Alex Merry wrote: >> Actually, I think we should just install application files directly in >> share/applications. (ie: change the value of XDG_APPS_INSTALL_DIR in >> KDEInstallDirs.cmake). It makes everyone's lives more

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Kevin Ottens
Hello, Any news on that front? I see kde4support is still the one not green because of that test. I see that Alex is kind of waiting for someone to take a side on the possible solutions. See below for my own take but I don't know KStandardDirs enough to have a valuable opinion. /me looks at D

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread Ben Cooksley
On Tue, Dec 24, 2013 at 5:37 AM, David Faure wrote: > On Monday 23 December 2013 14:42:45 Alex Merry wrote: >> On 23/12/13 14:23, Alex Merry wrote: >> > On 23/12/13 12:52, David Faure wrote: >> >> On Monday 23 December 2013 11:43:39 Alex Merry wrote: >> >>> Either way, the tests will fail is KDEDI

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread Alex Merry
On 23/12/13 16:37, David Faure wrote: > On Monday 23 December 2013 14:42:45 Alex Merry wrote: >> Ah, I should say that the reason setting it correctly is tricky is >> because it turns out it doesn't actually need to contain the >> installation directory. The important thing is that it contains the

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread David Faure
On Monday 23 December 2013 14:42:45 Alex Merry wrote: > On 23/12/13 14:23, Alex Merry wrote: > > On 23/12/13 12:52, David Faure wrote: > >> On Monday 23 December 2013 11:43:39 Alex Merry wrote: > >>> Either way, the tests will fail is KDEDIRS is not set correctly; I think > >>> the right approach t

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread Alex Merry
On 21/12/13 11:23, Alex Merry wrote: > KStandardDirs does not add directories that do not exist, UNLESS they > are the directory returned by installPrefix(). kde4support does not > install anything in share/applications, therefore if you install > kde4support in its own prefix, $PREFIX/share/appli

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread Alex Merry
On 23/12/13 14:23, Alex Merry wrote: > On 23/12/13 12:52, David Faure wrote: >> On Monday 23 December 2013 11:43:39 Alex Merry wrote: >>> Either way, the tests will fail is KDEDIRS is not set correctly; I think >>> the right approach there is to do a bit of a sanity check in >>> initTestCase() and

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread Alex Merry
On 23/12/13 12:52, David Faure wrote: > On Monday 23 December 2013 11:43:39 Alex Merry wrote: >> On 23/12/13 08:36, David Faure wrote: >>> Still, replacing tests that pass means introducing the risk that we're not >>> testing for the same thing anymore. But if you're fully convinced, go >>> ahead.

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread David Faure
On Monday 23 December 2013 11:43:39 Alex Merry wrote: > On 23/12/13 08:36, David Faure wrote: > > Still, replacing tests that pass means introducing the risk that we're not > > testing for the same thing anymore. But if you're fully convinced, go > > ahead. I wouldn't have rewritten these, but I do

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread Alex Merry
On 23/12/13 08:36, David Faure wrote: > Still, replacing tests that pass means introducing the risk that we're not > testing for the same thing anymore. But if you're fully convinced, go ahead. > I wouldn't have rewritten these, but I don't want to veto the change. > > In fact my thinking when wr

Re: kde4support: kstandarddirs_unittest fix

2013-12-23 Thread David Faure
On Saturday 21 December 2013 11:23:01 Alex Merry wrote: > On 21/12/13 00:19, David Faure wrote: > > On Friday 20 December 2013 23:07:08 Alex Merry wrote: > >> In my continuing mission to make the frameworks green on Jenkins: > >> > >> This makes the tests work even when not installed, even when kd

Re: kde4support: kstandarddirs_unittest fix

2013-12-21 Thread Alex Merry
On 21/12/13 11:23, Alex Merry wrote: > On 21/12/13 00:19, David Faure wrote: >> On Friday 20 December 2013 23:07:08 Alex Merry wrote: >>> The one bit that is still failing is testSetXdgDataDirs() and >>> testRestrictedResources(), which both fail for the same reason. >>> >>> Basically, the test che

Re: kde4support: kstandarddirs_unittest fix

2013-12-21 Thread Alex Merry
On 21/12/13 00:19, David Faure wrote: > On Friday 20 December 2013 23:07:08 Alex Merry wrote: >> In my continuing mission to make the frameworks green on Jenkins: >> >> This makes the tests work even when not installed, even when kde4support >> is installed to a separate prefix to the rest of frame

Re: kde4support: kstandarddirs_unittest fix

2013-12-20 Thread David Faure
On Friday 20 December 2013 23:07:08 Alex Merry wrote: > In my continuing mission to make the frameworks green on Jenkins: > > This makes the tests work even when not installed, even when kde4support > is installed to a separate prefix to the rest of frameworks (as it is on > Jenkins -- although th

kde4support: kstandarddirs_unittest fix

2013-12-20 Thread Alex Merry
In my continuing mission to make the frameworks green on Jenkins: This makes the tests work even when not installed, even when kde4support is installed to a separate prefix to the rest of frameworks (as it is on Jenkins -- although this setup is dangerous for *real* users of KStandardDirs). The o