Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On Mon, Jan 13, 2014, at 23:53, Valentin Rusu wrote: On 01/13/2014 10:05 PM, Valentin Rusu wrote: On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. The push actually took place. kwalletd is now in kwallet-frameworks. However, it won't build, sorry. It was building fine on my system, but perhaps I didn't catch some latest changes with the build system. Right now I'm doing a clean build of frameworks hoping that will help me spot where the problem is. OK, I now understand what's happening. It's a dependency (order of build) problem, as when performing frameworks fresh build, kwallet-framework fails then when rebuilding starting with kwallet-frameworks, it works. I'll fix that later, I must now leave. Meanwhile, I'd like to ask what's the preferred method to fixing this kind of dependency problems with frameworks? KWallet now depends on KInit, making it a tier3 framework. Is this what you intended? Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On 01/14/2014 10:38 AM, Aurélien Gâteau wrote: On Mon, Jan 13, 2014, at 23:53, Valentin Rusu wrote: On 01/13/2014 10:05 PM, Valentin Rusu wrote: On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. The push actually took place. kwalletd is now in kwallet-frameworks. However, it won't build, sorry. It was building fine on my system, but perhaps I didn't catch some latest changes with the build system. Right now I'm doing a clean build of frameworks hoping that will help me spot where the problem is. OK, I now understand what's happening. It's a dependency (order of build) problem, as when performing frameworks fresh build, kwallet-framework fails then when rebuilding starting with kwallet-frameworks, it works. I'll fix that later, I must now leave. Meanwhile, I'd like to ask what's the preferred method to fixing this kind of dependency problems with frameworks? KWallet now depends on KInit, making it a tier3 framework. Is this what you intended? Good point! Yes, kwalletd, which is now part of kwallet-framework, depends on KInit. And I think that ksecretsd will also depend on KInit, as it'll also be a KDE daemon. But AFAICT no tier2 depends on it, so I think that'll be no problem with this tier change. Or is it? signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. After that, and if no one objects, I'll do the git rm -rf kwalletd from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. From now on kwalletd will live here: kwallet-framework/src/runtime/kwalletd kwalletd was now removed from kde-runtime:frameworks branch signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. After that, and if no one objects, I'll do the git rm -rf kwalletd from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. Sounds good, thanks! Do you also plan on doing something with the kwallet repository, i.e. the user-facing application? I guess it makes some sense for it to rename separate, but maybe in that case its git repo should be kwalletmanager and kwallet-framework should be kwallet (the -framework suffix was just a quick hack to solve the name clash when splitting out the repos). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
Hello, On Monday 13 January 2014 10:05:26 David Faure wrote: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. After that, and if no one objects, I'll do the git rm -rf kwalletd from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. Sounds good, thanks! Do you also plan on doing something with the kwallet repository, i.e. the user-facing application? I guess it makes some sense for it to rename separate, but maybe in that case its git repo should be kwalletmanager and kwallet-framework should be kwallet (the -framework suffix was just a quick hack to solve the name clash when splitting out the repos). Definitely makes sense to me. We probably want such a repository renaming. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
2014/1/13 David Faure fa...@kde.org: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. After that, and if no one objects, I'll do the git rm -rf kwalletd from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. Sounds good, thanks! Do you also plan on doing something with the kwallet repository, i.e. the user-facing application? I guess it makes some sense for it to rename separate, but maybe in that case its git repo should be kwalletmanager and kwallet-framework should be kwallet (the -framework suffix was just a quick hack to solve the name clash when splitting out the repos). If you rename kwallet to kwalletmanager and kwallet-framework to kwallet, people with a clone of kwallet.git will get a mess the next time they pull from the server, as the entire repository/history will have changed. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: 2014/1/13 David Faure fa...@kde.org: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. After that, and if no one objects, I'll do the git rm -rf kwalletd from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. Sounds good, thanks! Do you also plan on doing something with the kwallet repository, i.e. the user-facing application? I guess it makes some sense for it to rename separate, but maybe in that case its git repo should be kwalletmanager and kwallet-framework should be kwallet (the -framework suffix was just a quick hack to solve the name clash when splitting out the repos). If you rename kwallet to kwalletmanager and kwallet-framework to kwallet, people with a clone of kwallet.git will get a mess the next time they pull from the server, as the entire repository/history will have changed. Maybe kwallet - kwalletmanager, then wait for a few months, then kwallet-framework- kwallet? That would give time to anyone having a kwallet clone to get errors and re-clone? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On 01/13/2014 05:17 PM, Kevin Ottens wrote: Hello, On Monday 13 January 2014 10:05:26 David Faure wrote: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Do you also plan on doing something with the kwallet repository, i.e. the user-facing application? Well, if you asked me, I would also import kdeutils/kwallet in kwallet-framework, as it's related technology for me. But I got some feedback about systems where kwalletd is present and not kwalletmanager. I guess it makes some sense for it to rename separate, but maybe in that case its git repo should be kwalletmanager and kwallet-framework should be kwallet (the -framework suffix was just a quick hack to solve the name clash when splitting out the repos). Definitely makes sense to me. We probably want such a repository renaming. Yes, I also agree. I'll take care of that. Regards, signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On Monday 13 January 2014 20:12:31 Valentin Rusu wrote: On 01/13/2014 07:54 PM, David Faure wrote: On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: 2014/1/13 David Faure fa...@kde.org: If you rename kwallet to kwalletmanager and kwallet-framework to kwallet, people with a clone of kwallet.git will get a mess the next time they pull from the server, as the entire repository/history will have changed. Maybe kwallet - kwalletmanager, then wait for a few months, then kwallet-framework- kwallet? That would give time to anyone having a kwallet clone to get errors and re-clone? Here is one more reason to move kwalletmanager (aka kdeutils/kwallet) in kwallet-framework. Then there'll be no more such problems. Will that be acceptable for our packagers? Honestly I think that makes sense to keep the manager application from the daemon and interface. We don't provide the KCM to control the emoticons with kemoticons for instance, it's more workspace stuff. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On 01/13/2014 08:40 PM, Kevin Ottens wrote: On Monday 13 January 2014 20:12:31 Valentin Rusu wrote: On 01/13/2014 07:54 PM, David Faure wrote: On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: 2014/1/13 David Faure fa...@kde.org: If you rename kwallet to kwalletmanager and kwallet-framework to kwallet, people with a clone of kwallet.git will get a mess the next time they pull from the server, as the entire repository/history will have changed. Maybe kwallet - kwalletmanager, then wait for a few months, then kwallet-framework- kwallet? That would give time to anyone having a kwallet clone to get errors and re-clone? Here is one more reason to move kwalletmanager (aka kdeutils/kwallet) in kwallet-framework. Then there'll be no more such problems. Will that be acceptable for our packagers? Honestly I think that makes sense to keep the manager application from the daemon and interface. We don't provide the KCM to control the emoticons with kemoticons for instance, it's more workspace stuff. Well, I see. So I'll do like David sugests. signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. The push actually took place. kwalletd is now in kwallet-frameworks. However, it won't build, sorry. It was building fine on my system, but perhaps I didn't catch some latest changes with the build system. Right now I'm doing a clean build of frameworks hoping that will help me spot where the problem is. signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kwalletd about to be switched from kde-runtime to kwallet-framework
On 01/13/2014 10:05 PM, Valentin Rusu wrote: On 01/12/2014 07:59 PM, Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. The push actually took place. kwalletd is now in kwallet-frameworks. However, it won't build, sorry. It was building fine on my system, but perhaps I didn't catch some latest changes with the build system. Right now I'm doing a clean build of frameworks hoping that will help me spot where the problem is. OK, I now understand what's happening. It's a dependency (order of build) problem, as when performing frameworks fresh build, kwallet-framework fails then when rebuilding starting with kwallet-frameworks, it works. I'll fix that later, I must now leave. Meanwhile, I'd like to ask what's the preferred method to fixing this kind of dependency problems with frameworks? signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kwalletd about to be switched from kde-runtime to kwallet-framework
Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430 commits waiting on my local copy. I filed a sysadmin ticket and as soon as it gets handled, I'll push it. After that, and if no one objects, I'll do the git rm -rf kwalletd from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. From now on kwalletd will live here: kwallet-framework/src/runtime/kwalletd -- Valentin Rusu (IRC valir, KDE vrusu) KSecretsService (former KSecretService, KWallet replacement) signature.asc Description: OpenPGP digital signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
