Re: libnm-qt - a new KF5 framework for Tier 1?
On Monday 08 December 2014 16:27:42 Jan Grulich wrote: Hi, I would like to finally finish this. According to [1] I believe we satisfy all conditions to become a framework. We also already have own bugzilla component [2] and repository in reviewboard. There were also no objections except a comment from David Edmunson regarding propertiesChanged() slots being in public API, but this is already solved. It's been almost a month since my first email so can you please take libnm-qt among other frameworks and add it to kde:sysadmin/release-tools? I'll then request moving the repo under frameworks and update version accordingly. There's a mismatch between the repo name and the framework name. E.g. list_frameworks.sh can't find the yaml file because it's not called libnm-qt.yaml - it's called networkmanagerqt.yaml instead. Can you rename one or the other? It looks like the framework name is networkmanagerqt for other things (like the version header), so maybe the git repo should be renamed? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
I'm happy with it now. +1 from me. David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
Hi, I would like to finally finish this. According to [1] I believe we satisfy all conditions to become a framework. We also already have own bugzilla component [2] and repository in reviewboard. There were also no objections except a comment from David Edmunson regarding propertiesChanged() slots being in public API, but this is already solved. It's been almost a month since my first email so can you please take libnm-qt among other frameworks and add it to kde:sysadmin/release-tools? I'll then request moving the repo under frameworks and update version accordingly. [1] - https://community.kde.org/Frameworks/CreationGuidelines [2] - https://bugs.kde.org/describecomponents.cgi?product=frameworks-networkmanager-qt Thanks a lot. Regards, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
On Thursday 20 of November 2014 17:08 David Edmundson wrote: I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. Should we move it to private classes? I would. Or make each subclass connect to the interface propertyChanged signal itself and not have the propagation. Done, I moved all propertiesChanged() slots to private classes. See https://git.reviewboard.kde.org/r/121304/ Anything else? Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. Should we move it to private classes? I would. Or make each subclass connect to the interface propertyChanged signal itself and not have the propagation. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
On Thursday 13 of November 2014 16:39 Albert Astals Cid wrote: El Dijous, 13 de novembre de 2014, a les 16:27:20, Albert Astals Cid va escriure: El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I removed them as they are not used. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. Should we move it to private classes? As far as i understand the maintainers preferred to tie it to the nm releases and not to the frameworks releases. Has this changed? Oh man, that is what i get for email being weird and getting David answer before Jan's email, so yes i guess this has changed :D There is no plan to tie it with the NM releases. Having it released with the frameworks gives us opportunity to release fixes/changes more frequently. Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
libnm-qt - a new KF5 framework for Tier 1?
Hi guys, we would like to finally move on with our libnm-qt library and become a part of KDE Frameworks 5. We plan do the same with libmm-qt, but we don't have proper unit tests yet so let's just do this one first. If you don't know, libnm-qt (NetworkManagerQt) is a dbus wrapper for NetworkManager. It has implemented everything what NetworkManager provides on dbus + some useful things which we added for our purposes. It depends just on Qt and NetworkManager so it could be in Tier 1 as an integration framework. This library is mainly used in plasma-nm, but I can imagine using it in more places for checking NetworkManager status, connectivity and so on. We have unit tests for almost all connection settings (like wired, wireless, ipv4 and so on) and a few unit tests for the most common parts like adding/removing devices/connections and activating/deactivating connections. More unit tests will be added in future, but I think it should be enough for now. I would be happy if you could take a look and tell us what we should change, what we are missing, what is wrong so we can move on. We would also need help with documentation to make it available on api.kde.org. Here is our library http://quickgit.kde.org/?p=libnm-qt.git Thanks a lot. Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. As far as i understand the maintainers preferred to tie it to the nm releases and not to the frameworks releases. Has this changed? Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
El Dijous, 13 de novembre de 2014, a les 16:27:20, Albert Astals Cid va escriure: El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. As far as i understand the maintainers preferred to tie it to the nm releases and not to the frameworks releases. Has this changed? Oh man, that is what i get for email being weird and getting David answer before Jan's email, so yes i guess this has changed :D Cheers, Albert Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
