Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:25 p.m.) Review request for KDE Frameworks and

Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:28 p.m.) Review request for KDE Frameworks and

Re: KF5 Unit test results

2012-08-06 Thread David Faure
On Sunday 29 July 2012 14:53:47 David Faure wrote: 71 - kdeui-kstartupinfo_unittest (Failed) // hangs. KXMessages::x11Event needs porting to XCB Fixed. 76 - kdeui-ktoolbar_unittest (Failed) // something about the keyboard modifiers in

Re: Reviewboard

2012-08-06 Thread Jeremy Whiting
I tried adding frameworks group to the last review I posted for the cleanup task I just finished, but rb said there's no such group... Jeremy On Fri, Jul 20, 2012 at 10:04 AM, David Faure fa...@kde.org wrote: There is now a frameworks group on reviewboard, which you can use so that reviews are

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/ --- (Updated Aug. 6, 2012, 6:53 p.m.) Review request for KDE Frameworks and

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/#review16996 --- Thanks, a good start. BTW did you try running the tests

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Whiting
I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? I also found one KApplication usage in an io slave that's part of the patch, is

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread David Faure
On Monday 06 August 2012 13:53:08 Jeremy Whiting wrote: I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? Don't nuke those

Fwd: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again.

2012-08-06 Thread David Faure
-- Forwarded Message -- Subject: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again. Date: Monday 06 August 2012, 17:59:21 From: David Faure fa...@kde.org To: kde-comm...@kde.org CC: kde-framewo...@kde.org, thi...@kde.org Git commit