Jenkins build became unstable: kdelibs_stable #625

2013-06-05 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110835: Port time_t to QDateTime in HostInfo (KIO)

2013-06-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110835/ --- Review request for KDE Frameworks. Description --- Port time_t to QDa

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review33781 --- staging/kiconthemes/src/kiconloader.h

Re: Bad rpath/LD_LIBRARY_PATH settings in kdelibs build scripts?

2013-06-05 Thread Alex Merry
On 04/06/13 23:01, David Faure wrote: > Hm, but why doesn't it work then? I see builddir/libkdeqt5staging/src in both > the RPATH and the RUNPATH, and one of these has priority over the env var, no? > I must be confused about how they work, then. https://blog.qt.digia.com/blog/2011/10/28/rpath-an

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/ --- (Updated June 5, 2013, 10:42 a.m.) Review request for KDE Frameworks and D

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review33790 --- With this change people listening to the old KGlobalSettings ic

Re: Review Request 110825: Move KEditListWidget to KWidgetAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110825/ --- (Updated June 5, 2013, 11:02 a.m.) Status -- This change has been mar

Re: Review Request 110825: Move KEditListWidget to KWidgetAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110825/#review33791 --- This review has been submitted with commit 1a90976e606a2653db2

Build failed in Jenkins: kdelibs_frameworks_qt5 #657

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] Move KEditListWidget to KWidgetAddons -- [...truncated 3657 lines...] [ 26%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeacadapter

Build failed in Jenkins: kdelibs_frameworks_qt5 #658

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] oops! -- [...truncated 3980 lines...] [ 37%] Built target karchivetest [ 37%] Building CXX object tier1/kdbusaddons/autotests/CMakeFiles/kdbusservicetest.dir/kdbusservic

Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110836/ --- Review request for KDE Frameworks. Description --- Port time_t to QDa

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/ --- (Updated June 5, 2013, 11:21 a.m.) Review request for KDE Frameworks and D

Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Re: Review Request 110827: Move KCursor to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110827/#review33793 --- This review has been submitted with commit 6cd3848036d11ba21ea

Re: Review Request 110827: Move KCursor to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110827/ --- (Updated June 5, 2013, 11:45 a.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #659

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] Move KCursor to KWidgetsAddons -- [...truncated 4021 lines...] [ 33%] [ 33%] Building CXX object tier1/kplotting/examples/CMakeFiles/kplottest.dir/kplottest_automoc.cpp.

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33795 --- ping! - Aleix Pol Gonzalez On June 3, 2013, 4:08 p.m., Aleix

Re: Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110826/#review33797 --- This review has been submitted with commit ef78be3d6b0855c4487

Re: Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110826/ --- (Updated June 5, 2013, noon) Status -- This change has been marked as

Build failed in Jenkins: kdelibs_frameworks_qt5 #660

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] Move KRatingPainter and KRatingWidget to KWidgetsAddons -- [...truncated 3944 lines...] [ 34%] Building CXX object tier1/threadweaver/autotests/CMakeFiles/ThreadWeaverJo

Build failed in Jenkins: plasma-framework_master_qt5 #467

2013-06-05 Thread KDE CI System
See Changes: [aseigo] add ConfigGroup here as well -- [...truncated 544 lines...] from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kservice.h:

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-05 Thread Aleix Pol Gonzalez
> On June 4, 2013, 8:50 p.m., David Faure wrote: > > tier1/kwidgetsaddons/src/kactionselector.h, line 300 > > > > > > This comment should be removed, polish() isn't virtual anymore since Qt > > 4.0... > > >

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110820/ --- (Updated June 5, 2013, 1:21 p.m.) Review request for KDE Frameworks. Cha

Build failed in Jenkins: plasma-framework_master_qt5 #468

2013-06-05 Thread KDE CI System
See Changes: [aseigo] forward port the cache file versioning so it drops properly in all cases -- [...truncated 558 lines...] from

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/ --- (Updated June 5, 2013, 2:12 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review33807 --- Cool. Almost there :) staging/kiconthemes/src/kiconloader.h <

Build failed in Jenkins: plasma-framework_master_qt5 #469

2013-06-05 Thread KDE CI System
See Changes: [aseigo] missing const -- [...truncated 551 lines...] [ 26%] Building CXX object src/plasma/CMakeFiles/plasma.dir/runnersyntax.cpp.o [ 27%] Building CXX object src/plasma/CMak

Moving KLinkDialog

2013-06-05 Thread Aleix Pol
At the moment KLinkDialog is set to be moved to KWidgetsAddons. I don't think this is correct because the class is not being exported as of KDE4, it's an internal class only used by KRichTextEdit. I'd suggest to move it to KTextWidgets and leave it as private. Does it sound good? Or we really wan

Re: Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/#review33808 --- Ship it! - David Faure On June 5, 2013, 11:42 a.m., Wojciech

Re: Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/ --- (Updated June 5, 2013, 2:48 p.m.) Status -- This change has been mark

Re: Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110837/#review33809 --- This review has been submitted with commit 1a2f5d7f0132af65cf6

Build failed in Jenkins: kdelibs_frameworks_qt5 #661

2013-06-05 Thread KDE CI System
See Changes: [wojtask9.kde] Port away ItemViews from KLineEdit and i18n -- [...truncated 3987 lines...] Building CXX object tier1/kdbusaddons/autotests/CMakeFiles/kdbusinterprocesslocktest.dir/

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110820/#review33813 --- Ship it! - David Faure On June 5, 2013, 1:21 p.m., Aleix Pol

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110820/#review33815 --- This review has been submitted with commit 46c1f06c05f828a8f77

Re: Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110820/ --- (Updated June 5, 2013, 3:43 p.m.) Status -- This change has been mark

Jenkins build is back to normal : kdelibs_frameworks_qt5 #662

2013-06-05 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w2

2013-06-05 Thread David Faure
Today we had the 4th update meeting for KF5, on #kde-devel. Announcement: * Aleix Pol improved cmake support in kdevelop so that working on KF5 can be done in kdevelop. Try it out, and report kdevelop-specific problems to him :) On-going work: * KDEUI crumble: Aleix Pol (apol) is working on kp

Re: Moving KLinkDialog

2013-06-05 Thread David Faure
On Wednesday 05 June 2013 16:23:23 Aleix Pol wrote: > At the moment KLinkDialog is set to be moved to KWidgetsAddons. I don't > think this is correct because the class is not being exported as of KDE4, > it's an internal class only used by KRichTextEdit. > > I'd suggest to move it to KTextWidgets

Review Request 110840: Move KFontComboBox to KDE4Support

2013-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110840/ --- Review request for KDE Frameworks. Description --- Move KFontComboBox

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated June 5, 2013, 7:39 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-06-05 Thread Marco Martin
> On June 4, 2013, 10:52 p.m., David Faure wrote: > > staging/knotifications/src/knotificationrestrictions.h, line 23 > > > > > > wrong file sorry, uploaded the wrong diff yesterday - Marco ---

Review Request 110842: Add reviewboardrc file

2013-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/ --- Review request for KDE Frameworks. Description --- Add reviewboardrc

Re: Review Request 110842: Add reviewboardrc file

2013-06-05 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/#review33822 --- Ship it! Yes please. - Ian Monroe On June 5, 2013, 8:32 p.m

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33824 --- tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/#review33825 --- Ship it! staging/knotifications/src/CMakeLists.txt

Re: Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110836/#review33827 --- kio/kio/slavebase.cpp

Re: Bad rpath/LD_LIBRARY_PATH settings in kdelibs build scripts?

2013-06-05 Thread Alexander Neundorf
On Wednesday 05 June 2013, Alex Merry wrote: > On 04/06/13 23:01, David Faure wrote: > > Hm, but why doesn't it work then? I see builddir/libkdeqt5staging/src in > > both the RPATH and the RUNPATH, and one of these has priority over the > > env var, no? I must be confused about how they work, then.

Re: Review Request 110840: Move KFontComboBox to KDE4Support

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110840/#review33833 --- staging/kde4support/src/kdeui/fonthelpers.cpp

Re: Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110836/#review33834 --- kio/kio/slavebase.cpp

Re: Moving KLinkDialog

2013-06-05 Thread Aleix Pol
On Wed, Jun 5, 2013 at 6:34 PM, David Faure wrote: > On Wednesday 05 June 2013 16:23:23 Aleix Pol wrote: > > At the moment KLinkDialog is set to be moved to KWidgetsAddons. I don't > > think this is correct because the class is not being exported as of KDE4, > > it's an internal class only used b

Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/ --- Review request for KDE Frameworks. Description --- Just moved it, no

Re: Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

2013-06-05 Thread David Faure
> On June 5, 2013, 10:35 p.m., David Gil Oliva wrote: > > kio/kio/slavebase.cpp, line 275 > > > > > > AFAIK, time_t can be either a given moment in time (say 2013-06-06, > > 00:00) or an elapsed time (say 136 sec

Re: Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/#review33838 --- Ship it! Would be a good opportunity to fix some of the broken

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 5, 2013, 11:12 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33839 --- Ship it! Small is good :) Just minor things left, probably do

Re: Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/#review33840 --- This review has been submitted with commit cf5e2fa99a63fb2b914

Re: Review Request 110838: Moved KColorCombo to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110838/ --- (Updated June 5, 2013, 11:50 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #667

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] Moved KColorCombo to KWidgetsAddons -- [...truncated 3640 lines...] [ 28%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/internetgateway.cpp.o [

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33841 --- This review has been submitted with commit 2563bc4fa33568594d2

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 5, 2013, 11:58 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #668

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] Moving KToolBarSpacerAction to KWidgetsAddons -- [...truncated 3611 lines...] Generating moc_kstatusbarjobtracker_p.cpp Generating moc_kwidgetjobtracker.cpp Generating mo

Build failed in Jenkins: kdelibs_frameworks_qt5 #669

2013-06-05 Thread KDE CI System
See Changes: [aleixpol] remove wrongly included file -- [...truncated 14720 lines...] -- Installing:

Review Request 110845: Move kdeui/itemviews to ItemViews framework

2013-06-05 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110845/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/ --- Review request for KDE Frameworks. Description --- Besides the move,

Re: Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/#review33844 --- Missing files - David Edmundson On June 6, 2013, 12:37 a.m.,

Re: Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/ --- (Updated June 6, 2013, 1:03 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons

2013-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110847/#review33845 --- Ship it! Change needed. Rest looks fine. tier1/kwidgetsaddon