Problem merging Qt branch

2013-08-20 Thread David Edmundson
Hey, I don't think I'll be able to make the meeting tomorrow, which is a shame as I'm currently stuck. I have a Qt review. It all passed, everyone is happy: https://codereview.qt-project.org/#change,62059 however every time it goes through integration testing, because I've modified QEvent, it

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review38182 --- Ship it! Ship It! - Kevin Ottens On Aug. 19, 2013, 10:43

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/#review38183 --- Ship it! Ship It! - Kevin Ottens On Aug. 19, 2013, 3:11

Re: Review Request 112170: Drop hack for cyclic depndencies between kde4support and kdelibs

2013-08-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112170/#review38184 --- Ship it! Ship It! - Kevin Ottens On Aug. 20, 2013, 5:53

Re: Review Request 112170: Drop hack for cyclic depndencies between kde4support and kdelibs

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112170/#review38185 --- This review has been submitted with commit

Re: Review Request 112170: Drop hack for cyclic depndencies between kde4support and kdelibs

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112170/ --- (Updated Aug. 20, 2013, 7:32 a.m.) Status -- This change has been

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/#review38186 --- This review has been submitted with commit

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/ --- (Updated Aug. 20, 2013, 7:33 a.m.) Status -- This change has been

Re: Problem merging Qt branch

2013-08-20 Thread Kevin Ottens
On Monday 19 August 2013 22:30:21 David Edmundson wrote: Hey, I don't think I'll be able to make the meeting tomorrow, which is a shame as I'm currently stuck. I have a Qt review. It all passed, everyone is happy: https://codereview.qt-project.org/#change,62059 however every time it

Build failed in Jenkins: kdelibs_frameworks_qt5 #1046

2013-08-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1046/changes Changes: [mgraesslin] Drop hack for cyclic depndencies between kde4support and kdelibs [mgraesslin] Use xcb for KWindowEffects::isEffectAvailable [mgraesslin] Port of KWindowEffects::slideWindow to XCB [mgraesslin] Use

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review38190 --- Ship it! Ok for pushing (just one last issue to fix first)

Jenkins build is back to normal : plasma-framework_master_qt5 #605

2013-08-20 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/605/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1050

2013-08-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1050/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112172: reenable QLineEdit clear button

2013-08-20 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112172/ --- Review request for KDE Frameworks. Description --- reenable

Re: Review Request 112172: reenable QLineEdit clear button

2013-08-20 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112172/ --- (Updated Aug. 20, 2013, 12:26 p.m.) Review request for KDE Frameworks.

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-20 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 20, 2013, 1:21 p.m.) Status -- This change has been

KF5 Update Meeting Minutes 2013-w34

2013-08-20 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 34 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, apol, dfaure, mgraesslin, sebas, shadeslayer, vHanda, wojtask9 and myself. Announcement: * kdelibs splitting tasks open again, effective

Re: Review Request 112172: reenable QLineEdit clear button

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112172/#review38217 --- This review has been submitted with commit

Jenkins build became unstable: kdelibs_frameworks_qt5 #1055

2013-08-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1055/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112174: Make KSharedConfig::Ptr use QExplicitlySharedDataPointer

2013-08-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112174/ --- (Updated Aug. 20, 2013, 6:48 p.m.) Review request for KDE Frameworks.

Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/ --- Review request for KDE Frameworks. Description --- Make it possible

Review Request 112174: Make KSharedConfig::Ptr use QExplicitlySharedDataPointer

2013-08-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112174/ --- Review request for KDE Frameworks. Description --- Make

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38221 --- KDE5PORTING.html

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/ --- (Updated Aug. 20, 2013, 5:27 p.m.) Review request for KDE Frameworks.

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38225 --- not sure about the directory layout, I'd expect src and tests

Re: Review Request 112177: Split URL drop functionality from KLineEdit

2013-08-20 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112177/ --- (Updated Aug. 20, 2013, 8:46 p.m.) Review request for KDE Frameworks.

oxygen vs kstyle

2013-08-20 Thread Hugo Pereira Da Costa
Hi All, There is some traffic on the frameworks list concerning implementing new features in kstyle. It might be useful to mention that the current oxygen code (KDE's default widget style) derives from QCommonStyle and not kstyle, so that none of the modifications to KStyle will be available

Re: oxygen vs kstyle

2013-08-20 Thread Christoph Feck
On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote: Hi All, There is some traffic on the frameworks list concerning implementing new features in kstyle. It might be useful to mention that the current oxygen code (KDE's default widget style) derives from QCommonStyle and not

Re: oxygen vs kstyle

2013-08-20 Thread Hugo Pereira Da Costa
On 08/20/2013 09:45 PM, Christoph Feck wrote: On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote: Hi All, There is some traffic on the frameworks list concerning implementing new features in kstyle. It might be useful to mention that the current oxygen code (KDE's default widget

Updating CMake requirement to 2.8.12 RC 1

2013-08-20 Thread Stephen Kelly
Hello, CMake 2.8.12 RC 1 was released a few hours ago: http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/47443 Updating to that will allow us to get on the home straight with regard to our buildsystem files. For example, we can easily set the INTERFACE_INCLUDE_DIRECTORIES of

Re: Notes from Frameworks5 Promo BoF at Akademy

2013-08-20 Thread Alexander Neundorf
On Thursday 08 August 2013, Kevin Ottens wrote: On Wednesday 07 August 2013 14:03:54 Jos Poortvliet wrote: On Wednesday 31 July 2013 12:54:53 Jos Poortvliet wrote: Heya, I know it's late and perhaps somebody already send these, but if not, here they are: the notes of the

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-20 Thread Alexander Neundorf
Hi, On Tuesday 20 August 2013, Stephen Kelly wrote: Hello, CMake 2.8.12 RC 1 was released a few hours ago: http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/47443 Updating to that will allow us to get on the home straight with regard to our buildsystem files. please

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-20 Thread David Gil Oliva
On Aug. 20, 2013, 9:27 a.m., David Faure wrote: staging/kio/src/core/authinfo.cpp, line 545 http://git.reviewboard.kde.org/r/111636/diff/3/?file=183588#file183588line545 let's hope macdef always comes *after* machine, otherwise index won't be set yet at this point...

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-20 Thread Stephen Kelly
Alexander Neundorf wrote: Hi, On Tuesday 20 August 2013, Stephen Kelly wrote: Hello, CMake 2.8.12 RC 1 was released a few hours ago: http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/47443 Updating to that will allow us to get on the home straight with regard to our

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review38242 --- This review has been submitted with commit

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/ --- (Updated Aug. 20, 2013, 9:31 p.m.) Status -- This change has been

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1056

2013-08-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1056/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #1057

2013-08-20 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1057/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Notes from Frameworks5 Promo BoF at Akademy

2013-08-20 Thread Kevin Ottens
On Tuesday 20 August 2013 22:40:18 Alexander Neundorf wrote: On Thursday 08 August 2013, Kevin Ottens wrote: Whatever would be released early, will need also a release of extra-cmake- modules. I'd like to do that as soon as possible, Stephen objected to that. I don't know what he thinks about