Re: Frameworks Overview

2013-09-24 Thread Cornelius Schumacher
On Monday 23 September 2013 11:43:58 Sebastian Kügler wrote: On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: On Thursday 19 September 2013 Sebastian Kügler wrote: http://community.kde.org/Frameworks/Overview I have put the data on Inqlude (see

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Nicolás Alvarez
On Monday, September 23, 2013, Nicolás Alvarez wrote: On Monday, September 23, 2013, Kevin Ottens wrote: On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote: El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va escriure: Albert Astals Cid wrote:

Re: Frameworks Overview

2013-09-24 Thread Jos Poortvliet
On Mon, Sep 23, 2013 at 11:43 AM, Sebastian Kügler se...@kde.org wrote: Technically, this is the current focus. We're splitting kdelibs. As to communication, it probably needs a bit of boilerplate. (Which the bits I wrote don't contain purposefully.) Otherwise, you're right, we need to work

Re: Review Request 112830: Start splitting KParts

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/#review40629 --- Ship it! Ship It! - Kevin Ottens On Sept. 23, 2013, noon,

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40632 --- Probably needs some porting notes in KDE5PORTING to point to

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Kevin Ottens
On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux it would be easy to install, and on Windows it wouldn't be needed (what's a manpage?). And still leave it optional everywhere... Thats a very good question.

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40642 --- staging/kde4support/CMakeLists.txt

Re: Review Request 112900: Prepare KDNSSD for moving

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/#review40644 --- Yes, looks like a tier 2 in that case. I wonder if that

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-24 Thread Kevin Ottens
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least partly. Jeremy Whiting wrote: well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files iirc). All I did was copy it and rename it.

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-24 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40646 --- Please split this into multiple patches. The move should be

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40648 --- I'm torn on that one... If we're sure the remaining features

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-24 Thread Kevin Ottens
On Sept. 23, 2013, 10:49 a.m., Kevin Ottens wrote: modules/ECMAddUnitTest.cmake, line 23 http://git.reviewboard.kde.org/r/112828/diff/2/?file=190650#file190650line23 I agree, it's about automated (vs manual) tests here. We've no way when writing this macro to know if the user

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40650 --- staging/kemoticons/src/providers/adium/CMakeLists.txt

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-24 Thread Chusslove Illich
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote: I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least partly. Jeremy Whiting wrote: well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files iirc). All I did was copy it and rename it.

Build failed in Jenkins: kdelibs_frameworks_qt5 #1246

2013-09-24 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1246/changes Changes: [mklapetek] Use QStringLiteral rather than QLatin1String [steveire] Define isnan() for MSVC [steveire] Don't use QStringLiteral as a default value initializer. [steveire] Use the correct moc include on Windows.

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-24 Thread Martin Klapetek
On Sept. 24, 2013, 7:10 a.m., Kevin Ottens wrote: I'm torn on that one... If we're sure the remaining features aren't useful, I would propose to just move all the printing stuff from KDE4Attic to KDE4Support. If we're not sure, then we should move the printing stuff from KDE4Attic to

Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Martin Gräßlin
On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: Hi all, We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. That means if you're building your Plasma yourself from Git (and you're not yet ready for Plasma2 ;)), you should switch to

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40662 --- Ship it! Ship It! - Kevin Ottens On Sept. 23, 2013, 6:47

Jenkins build became unstable: kdelibs_frameworks_qt5 #1249

2013-09-24 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1249/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1250

2013-09-24 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1250/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112900: Prepare KDNSSD for moving

2013-09-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/ --- (Updated Sept. 24, 2013, 11:14 a.m.) Review request for KDE Frameworks.

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Albert Astals Cid
El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va escriure: On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux it would be easy to install, and on Windows it wouldn't be needed (what's a

Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Albert Astals Cid
El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va escriure: On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: Hi all, We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. That means if you're building your

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Kevin Ottens
On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va escriure: On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux it would

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

2013-09-24 Thread David Edmundson
On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote: staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3 http://git.reviewboard.kde.org/r/112882/diff/1/?file=191209#file191209line3 I surely has other dependencies. Aleix Pol Gonzalez wrote: Most things in staging have faulty

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/ --- (Updated Sept. 24, 2013, 12:22 p.m.) Status -- This change has been

Re: Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Martin Gräßlin
On Tuesday 24 September 2013 13:51:57 Albert Astals Cid wrote: El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va escriure: On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: Hi all, We're planning to merge the frameworks-scratch branch of

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Aleix Pol
On Tue, Sep 24, 2013 at 2:09 PM, Kevin Ottens er...@kde.org wrote: On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va escriure: On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: Maybe we can use a

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/#review40679 --- This review has been submitted with commit

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/ --- (Updated Sept. 24, 2013, 1:10 p.m.) Status -- This change has been

Re: Review Request 112830: Start splitting KParts

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/ --- (Updated Sept. 24, 2013, 1:23 p.m.) Status -- This change has been

Re: Review Request 112830: Start splitting KParts

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/#review40680 --- This review has been submitted with commit

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-24 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40681 --- Ship it! Agree to merge this as is, it removes the stuff that

Re: Review Request 112915: Fix kcrash standalone build

2013-09-24 Thread Aurélien Gâteau
On Sept. 24, 2013, 3:32 p.m., David Edmundson wrote: superbuild/CMakeLists.txt, line 46 http://git.reviewboard.kde.org/r/112915/diff/1/?file=191979#file191979line46 why have you removed kconfigwidgets? Because it does not build with superbuild right now. The original intent of my

Re: Review Request 112915: Fix kcrash standalone build

2013-09-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/ --- (Updated Sept. 24, 2013, 3:39 p.m.) Review request for KDE Frameworks.

Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- Review request for KDE Frameworks. Description --- Add index

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40691 --- This review has been submitted with commit

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/ --- (Updated Sept. 24, 2013, 2:19 p.m.) Review request for KDE Frameworks and

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40692 --- tier1/kguiaddons/src/lib/colors/kcolorutils.cpp

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- (Updated Sept. 24, 2013, 2:25 p.m.) Review request for KDE Frameworks.

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40694 --- Probably we'll need an extra patch on top of this one so that

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- (Updated Sept. 24, 2013, 2:33 p.m.) Review request for KDE Frameworks.

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Sune Vuorela
On Sept. 24, 2013, 2:23 p.m., Sune Vuorela wrote: tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 http://git.reviewboard.kde.org/r/112816/diff/1/?file=190519#file190519line42 My initial reaction is that it could return a bool wether or not things went okay, given there

Re: Templates for frameworks CMake files

2013-09-24 Thread Stephen Kelly
Aurélien Gâteau wrote: Hi, I have been playing around with itemviews CMake files and put together some templates for the top level CMakeLists.txt and *Config.cmake.in. You can find them attached there. Any one against me adding those to the repository? Aurélien CMakeLists.txt

Re: Frameworks Overview

2013-09-24 Thread Sebastian Kügler
On Monday, September 23, 2013 15:08:57 Jos Poortvliet wrote: On Mon, Sep 23, 2013 at 11:43 AM, Sebastian Kügler se...@kde.org wrote: Technically, this is the current focus. We're splitting kdelibs. As to communication, it probably needs a bit of boilerplate. (Which the bits I wrote don't

KF5 Update Meeting Minutes 2013-w39

2013-09-24 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 39 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, dfaure, mck182, mgraesslin, sebas, shadeslayer, teo, vHanda, wojtask9 and myself. Announcement: * I will be away next week,

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Kevin Ottens
On Tuesday 24 September 2013 15:05:56 Aleix Pol wrote: On Tue, Sep 24, 2013 at 2:09 PM, Kevin Ottens er...@kde.org wrote: On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: Are you sure that's an improvement? Well, as highlighted we have a dependency issue there, so it's

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-24 Thread Jeremy Whiting
On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote: I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least partly. Jeremy Whiting wrote: well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files iirc). All I did was copy it and rename it.

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Sune Vuorela
Maybe we can bundle the generated documentation? Distributions in general don't want pregenerated anything. /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [kde-promo] Terminology for Frameworks

2013-09-24 Thread Carl Symons
On Tuesday, September 24, 2013 10:09 (UTC) Jos Poortvliet wrote: Going through the article explaining Frameworks to the world* yesterday, I bumped into quite some inconsistent use of terms. Right now, we mix up: modules components frameworks addons libraries This article was developed

Terminology for Frameworks

2013-09-24 Thread Jos Poortvliet
Going through the article explaining Frameworks to the world* yesterday, I bumped into quite some inconsistent use of terms. Right now, we mix up: modules components frameworks addons libraries For example in the article, we mostly talked 'modules' intermingled with 'libraries', then suddenly

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-24 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 24, 2013, 4:08 p.m.) Review request for KDE Frameworks and

Re: QTimeZone merged for 5.2

2013-09-24 Thread John Layt
On 24 September 2013 12:11, Kevin Ottens er...@kde.org wrote: OK, let's attempt to move KLocale, KDateTime and friends to kde4support now. With some luck we'll be able to completely get rid of KDE4Attic before release. Hmm, looking at that closer... indeed it looks like we can get rid of

Review Request 112919: Prepare KParts for the move

2013-09-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112919/ --- Review request for KDE Frameworks. Description --- Moved all sources

Re: QTimeZone merged for 5.2

2013-09-24 Thread Kevin Ottens
On Tuesday 24 September 2013 19:03:21 John Layt wrote: I'll do some analysis on the use of all the widgets and what ones are worth keeping, and look at the Qt widgets to see if they're worth switching to, if not before then at Qt Dev Days / Qt Contributors Day. OK, I'll ignore this part of

Re: Templates for frameworks CMake files

2013-09-24 Thread Alexander Neundorf
On Tuesday 24 September 2013, Stephen Kelly wrote: Aurélien Gâteau wrote: Hi, I have been playing around with itemviews CMake files and put together some templates for the top level CMakeLists.txt and *Config.cmake.in. You can find them attached there. Any one against me adding those

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 24, 2013, 6:08 p.m.) Review request for KDE Frameworks,

Re: Frameworks Overview

2013-09-24 Thread Alexander Neundorf
On Tuesday 24 September 2013, Ben Cooksley wrote: On Sep 24, 2013 7:33 AM, Alexander Neundorf neund...@kde.org wrote: On Monday 23 September 2013, Sebastian Kügler wrote: Hey, On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: On Thursday 19 September 2013

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-24 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- (Updated Sept. 24, 2013, 8:44 p.m.) Status -- This change has been

Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

2013-09-24 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112921/ --- Review request for KDE Frameworks. Description --- Adjust

Re: Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

2013-09-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112921/#review40728 --- Ship it!

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Albert Astals Cid
El Dimarts, 24 de setembre de 2013, a les 14:09:57, Kevin Ottens va escriure: On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va escriure: On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: Maybe

Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

2013-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/ --- Review request for KDE Frameworks. Description --- Make leftMargin