Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41196 --- Ship it! Looks good, but why don't we replace KCategoryDrawer

EcmQt4To5Porting

2013-10-04 Thread David Faure
On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt e0efb9b cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION

Re: EcmQt4To5Porting

2013-10-04 Thread Stephen Kelly
David Faure wrote: On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt e0efb9b cmake/modules/ECMQt4To5Porting.cmake

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Edmundson
On Oct. 4, 2013, 7 a.m., David Faure wrote: Looks good, but why don't we replace KCategoryDrawer with KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones? It should be SC since v3 derives from v2 derives from v1. It's not entirely source compatible since the

Re: EcmQt4To5Porting

2013-10-04 Thread Martin Klapetek
On Fri, Oct 4, 2013 at 9:22 AM, David Faure fa...@kde.org wrote: On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41199 --- This review has been submitted with commit

Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/#review41201 --- Ship it! staging/kdesu/src/CMakeLists.txt

Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens.

Re: Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/ --- (Updated Oct. 4, 2013, 11:18 a.m.) Status -- This change has been

Re: Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/#review41211 --- This review has been submitted with commit

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- (Updated Oct. 4, 2013, 11:25 a.m.) Review request for KDE Frameworks,

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/#review41213 --- Ship it! Ship It! - David Faure On Oct. 4, 2013, 11:25

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41214 --- Nothing serious, just some nitpicking.

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41215 --- Ship it! Looking good, lots of incremental improvements, too.

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: Looking good, lots of incremental improvements, too. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 11:52 a.m.) Review request for KDE Frameworks.

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- (Updated Oct. 4, 2013, 12:02 p.m.) Status -- This change has been

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41220 --- Ship it! +1 for taking care of this. I'm noticing now there

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 12:14 p.m.) Review request for KDE Frameworks.

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41223 --- kpty/CMakeLists.txt

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: experimental/kdeclarative/bindings/backportglobal.h, line 24 http://git.reviewboard.kde.org/r/113086/diff/1/?file=193824#file193824line24 backportglobal should be not needed anymore since we don't have qscriptengine anymore (needs

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: Looking good, lots of incremental improvements, too. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly

CMake templates

2013-10-04 Thread Aurélien Gâteau
Hi, In case you missed them, CMake templates for frameworks were merged into the frameworks branch yesterday. You can now find a template dir in kdelibs, with all the necessary scaffolding to create a new framework. These template files can be used for two things: - To create new frameworks:

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: Looking good, lots of incremental improvements, too. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly

Qt 5.2, test failures and rebuilds

2013-10-04 Thread Aurélien Gâteau
Hi, I spent a bit of time this morning investigating why the khtmlparttest was failing on build.kde.org after its Qt copy was switched to 5.2 [1]. Error looked very strange: QMetaType::registerType: Binary compatibility break -- Size mismatch for type

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 1:43 p.m.) Review request for KDE Frameworks.

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41228 --- Ship it! Ship It! - Martin Klapetek On Oct. 4, 2013, 1:43

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/#review41230 --- This review has been submitted with commit

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41229 --- This review has been submitted with commit

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/ --- (Updated Oct. 4, 2013, 1:46 p.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #1343

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1343/changes Changes: [kde] Prepare kpty for moving -- [...truncated 16909 lines...] from

Build failed in Jenkins: kdelibs_frameworks_qt5 #1344

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1344/changes Changes: [mklapetek] Prepare CMakeLists.txt for moving KDESu -- [...truncated 64686 lines...] -- Installing:

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Casian Andrei
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/ --- (Updated Oct. 4, 2013, 2:35 p.m.) Review request for KDE Frameworks and

Review Request 113097: KInit splitting

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113097/ --- Review request for KDE Frameworks. Repository: kdelibs Description

kio-related build error in plasma-framework

2013-10-04 Thread Sebastian Kügler
Hi, I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out? The error is:

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41235 --- This review has been submitted with commit

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- (Updated Oct. 4, 2013, 4:26 p.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #1346

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1346/changes Changes: [aleixpol] KDeclarative cleanup -- [...truncated 64701 lines...] -- Installing:

Build failed in Jenkins: plasma-framework_master_qt5 #774

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/774/changes Changes: [hein] Adapt to kdelibs ab56e2f. -- [...truncated 510 lines...] Generating moc_panelshadows_p.cpp Generating moc_panelview.cpp Generating appinterface.moc

Build failed in Jenkins: plasma-framework_master_qt5 #775

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/775/changes Changes: [sebas] cmake fixes -- [...truncated 603 lines...] /srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:316:71: warning: ‘List’ is deprecated

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 4, 2013, 5:26 p.m.) Review request for KDE Frameworks,

Re: Review Request 113008: Clean up KWallet before moving to its own tier

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41236 --- This review has been submitted with commit

Re: Review Request 113008: Clean up KWallet before moving to its own tier

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/ --- (Updated Oct. 4, 2013, 5:29 p.m.) Status -- This change has been

Review Request 113105: Move KWallet to tier2

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs

Re: Qt 5.2, test failures and rebuilds

2013-10-04 Thread Ben Cooksley
On Sat, Oct 5, 2013 at 2:12 AM, Aurélien Gâteau agat...@kde.org wrote: Hi, Hi Aurélien, I spent a bit of time this morning investigating why the khtmlparttest was failing on build.kde.org after its Qt copy was switched to 5.2 [1]. Error looked very strange: QMetaType::registerType:

Re: Review Request 113105: Move KWallet to tier2

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/#review41252 --- Ship it! Ship It! - David Edmundson On Oct. 4, 2013, 6:17

Review Request 113110: Move KNotifyConfig to staging

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113110/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Qt 5.2, test failures and rebuilds

2013-10-04 Thread Aurélien Gâteau
On Saturday 05 October 2013 08:52:27 you wrote: On Sat, Oct 5, 2013 at 2:12 AM, Aurélien Gâteau agat...@kde.org wrote: Hi, Hi Aurélien, I spent a bit of time this morning investigating why the khtmlparttest was failing on build.kde.org after its Qt copy was switched to 5.2 [1].

Jenkins build is back to normal : plasma-framework_master_qt5 #776

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/776/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113112: Notify about fonts and palette changes

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41259 ---

Re: Review Request 113110: Move KNotifyConfig to staging

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113110/#review41260 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 4, 2013,

Re: Review Request 113112: Notify about palette changes

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41262 --- Uh, just realized ingenuous doesn't mean what I thought, I

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Kurt Hindenburg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/#review41263 --- Thanks - it appears to fix the kbookmark build - I'm getting

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Casian Andrei
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/ --- (Updated Oct. 5, 2013, 1:59 a.m.) Status -- This change has been

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/#review41264 --- This review has been submitted with commit

Build failed in Jenkins: plasma-framework_master_qt5 #779

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/779/changes Changes: [sebas] lower case headers [sebas] Port away from KStandardDirs [sebas] lower case headers [sebas] lower case headers [sebas] find KDELibs4 -- [...truncated 669 lines...] [

Build failed in Jenkins: plasma-framework_master_qt5 #781

2013-10-04 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/781/changes Changes: [sebas] Reenable tests in declarativeimports [sebas] Port Plasma::Svg away from KGlobalSettings [sebas] Port theme away from KGlobalSettings [sebas] Port declarative theme away from KGlobalSettings` [sebas] remove