On Wednesday 09 October 2013 06:22:55 KDE CI System wrote:
See http://build.kde.org/job/kdelibs_frameworks_qt5/1386/changes
\o/
Let's keep kdelibs-frameworks and plasma-framework green now, shall we?
Note however that I still have a pesky issue with kded5 getting stuck, but
build.kde.org
See http://build.kde.org/job/kdelibs_stable/854/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113181/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113181/#review41430
---
Hi Martin,
Your notes might not hold anymore. A month ago
Hi,
As you all probably know by now, Qt has included of categorized logging [1]
as of 5.2.
In KDE we've had categorized logging for ages, but while porting to
Frameworks we started using the simple Qt logging qDebug, Notice and
Warning.
However, we now again have categorized logging from within
On Oct. 9, 2013, 1:21 p.m., Mark Gaiser wrote:
Hi Martin,
Your notes might not hold anymore. A month ago they would have been fine,
but now we also have the Categorized debugging in Qt. The
qCDebug,Notice,Warning, ... macros:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41435
---
kjsembed/examples/kjsconsole/numberedtextview.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/#review41436
---
It makes sense to me. I would like someone else to approve.
-
On Aug. 31, 2013, 7:11 a.m., David Faure wrote:
I disagree. Making things slow to cover a really really corner case (mixing
kde4 and kde5), while the solution already exists (clearing the cache when
switching icon themes), doesn't seem very sensible to me.
The point is really that
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112755/#review41439
---
Any news about that patch? It hasn't seen activity lately.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112918/#review41441
---
Ship it!
OK, that's a small SIC... but OK, we don't have that
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113182/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote:
I'm just going to point out something I know you already know since we've
discussed it many times;
that an xcb port of the NETWM classes already exists in a branch.
Martin Gräßlin wrote:
my aim was to write the unit test and
On Sept. 29, 2013, 4:38 p.m., David Faure wrote:
-1, see https://git.reviewboard.kde.org/r/112443/
Well... See Nicolas comment there, even the API is tied to the way X works.
- Kevin
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112929/
---
(Updated Oct. 9, 2013, 4:49 p.m.)
Status
--
This change has been
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote:
Tested the patch in my tree, works for caps lock too.
Now it highlights a dependency problem... We don't want a dependency on
QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to
your proposed KX11Extras?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113050/#review41448
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 2, 2013, 2:43
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review41449
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 4, 2013, 5:26
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112985/#review41450
---
I'm not sure what this patch is trying to achieve. It doesn't
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote:
There's also runner-related code in
src/declarativeimports/{core,runnermodel}, these should be reenabled as
well. Possibly, they also need changes to make built. I had disabled this
after a discussion with Aaron (who has refactored
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
On Sept. 24, 2013, 6:55 a.m., Kevin Ottens wrote:
I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any
opinion?
If we ignore that point for the moment, and think in terms of KF5, ATM it
would go with KColorScheme in KConfigWidgets. I'm not quite sold on the
On Oct. 9, 2013, 1:21 p.m., Mark Gaiser wrote:
Hi Martin,
Your notes might not hold anymore. A month ago they would have been fine,
but now we also have the Categorized debugging in Qt. The
qCDebug,Notice,Warning, ... macros:
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
kdeui/colors/kcolorschemetoken.h, line 70
http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70
using int here loses the type-safety. Why no use the corresponding
enums? It would also make the code more
On Wednesday 09 October 2013, Kevin Ottens wrote:
On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote:
Looks good to me, not adding the shipit because I'm clueless about
superbuild.
Why do we need to specify the dependencies from superbuild? Shouldn't
they depend on the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41456
---
kjsembed/examples/kjsconsole/console.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112932/
---
(Updated Oct. 9, 2013, 5:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112932/#review41457
---
It seems no-one uses superbuild, so I'm discarding it.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/#review41458
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 8, 2013, 1:20
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113153/#review41459
---
Ship it!
Makes sense, as long as there's a replacement. :)
Aleix Pol Gonzalez wrote:
This patch adds a defined() first, before checking the value, so the
pre-processor doesn't need to consider the variable value, if it's not
present.
This seems like a bad idea.
These are defined with 1 if acceptable and undefined if the feature is
not present.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review41463
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/
---
(Updated Oct. 9, 2013, 6:07 p.m.)
Status
--
This change has been
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
Can we keep all discussions on reviewboard?
If you mix replying to the mailing list we lose track of messages very quickly.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113160/#review41465
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113160/
---
(Updated Oct. 9, 2013, 6:30 p.m.)
Status
--
This change has been
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote:
There's also runner-related code in
src/declarativeimports/{core,runnermodel}, these should be reenabled as
well. Possibly, they also need changes to make built. I had disabled this
after a discussion with Aaron (who has refactored
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/
---
(Updated Oct. 9, 2013, 2:24 p.m.)
Review request for KDE Frameworks,
Hi,
While porting libnm-qt to Qt5, I'm running into the following problem when
building the tests. I've not seen this error before, and I'd like advice how
to fix it.
[ 59%] Building CXX object
tests/CMakeFiles/test_8021xsetting.dir/8021xsetting.cpp.o
In file included from
On Oct. 9, 2013, 5:05 p.m., Kevin Ottens wrote:
I'm not sure what this patch is trying to achieve. It doesn't look much
more clearer API to me than what we had before. :-)
Could you share a bit more of the rationale? I guess I'm missing something.
Ok, let's see. We have a method in
On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote:
I have added this to some of my qt5 projects and it worked:
add_definitions(-fPIC)
Thanks Daniel, that helps. :)
2013/10/9 Sebastian Kügler se...@kde.org:
Hi.
I am trying to compile plasma-framework against a qt5 that is ready for
Wayland, which does not have Desktop GL enabled.
However I seem to get an error that seems to be related to opengl in QT.
Is this a bug I should file?
This is the relevant output:
[ 81%] Building CXX object
2013/10/9 nerdopolis bluescreen_aven...@verizon.net:
Hi.
I am trying to compile plasma-framework against a qt5 that is ready for
Wayland, which does not have Desktop GL enabled.
However I seem to get an error that seems to be related to opengl in QT.
Is this a bug I should file?
This
46 matches
Mail list logo
