Re: Review Request 113937: Remove dependency from kio on kinit

2013-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113937/#review44093 --- This review has been submitted with commit

Re: Review Request 113937: Remove dependency from kio on kinit

2013-11-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113937/ --- (Updated Nov. 21, 2013, 9:52 a.m.) Status -- This change has been

Re: kded5 and kde-workspace

2013-11-21 Thread Àlex Fiestas
On Wednesday 20 November 2013 20:47:54 Àlex Fiestas wrote: Hey there Today I have been porting powerdevil and while doing it found out that kded5 was not loading any modules and many kde-workspace projects were using org.kde.kded instead of the one ended with .kded5 Tomorrow I'd like to

Build failed in Jenkins: kdelibs_frameworks_qt5 #1715

2013-11-21 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1715/changes Changes: [agateau] Add missing find_package(KDocTools) calls [agateau] kpagedialog_p.h is no longer installed, do not include it -- [...truncated 4030 lines...] Scanning dependencies of

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1716

2013-11-21 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1716/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-21 Thread Kevin Ottens
On Nov. 11, 2013, 5:45 p.m., David Faure wrote: Thanks for implementing that. Indeed the TODO didn't mean adding a method to QApplication, but it was about the member that was there in qt4, and that is now in QXcbConnection. The optional dependency on QtGui breaks the rules for

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1719

2013-11-21 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1719/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Reporting bugs against frameworks/plasma2

2013-11-21 Thread Àlex Fiestas
On Thursday 21 November 2013 16:34:28 Kevin Ottens wrote: Hello, On Thursday 21 November 2013 15:59:17 David Edmundson wrote: Long term, I disagree with using the version frameworks everywhere. Agreed... We want to have a split between Frameworks5.0 and Plasma2.0 and they may not be

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

2013-11-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44120 --- Ship it! Ship It! - Aurélien Gâteau On Nov. 21, 2013, 1:29

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-11-21 Thread Kevin Ottens
On Nov. 15, 2013, 6:20 p.m., Kevin Ottens wrote: Any chance to see Stephen's comments addressed or this patch is abandoned? Last warning, I'll close it as discarded if it's not updated on my next round of reviews. - Kevin --- This

Re: kded5 and kde-workspace

2013-11-21 Thread Àlex Fiestas
On Thursday 21 November 2013 11:09:22 Daniel Nicoletti wrote: Funny this is the kind of thing that could just be avoided if projects stopped using the org.kde.kded DBus interface and instead registered their own. I for example don't need to do any change because I register org.kde.apperd

Re: Review Request 113968: Make KFileAudioPreview use its own config group

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113968/#review44132 --- Ship it! Ship It! - Kevin Ottens On Nov. 20, 2013, 11:36

Reporting bugs against frameworks/plasma2

2013-11-21 Thread Àlex Fiestas
Hi there! We are already trying to dogfood Plasma2 + frameworks and as it was to be expected we have tons of bugs :p so I have taken the liberty of setting up bugzilla, we can change things if you don't agree with that I have done. For frameworks: I have added a new version called

Build failed in Jenkins: kdelibs_frameworks_qt5 #1718

2013-11-21 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1718/changes Changes: [agateau] Rework superbuild to make it easier to use [agateau] add kdoctools to dependencies [agateau] Disable kcmutils for now [agateau] Add a SUPERBUILD option to be able to turn off superbuild [agateau] Disable

Re: Reporting bugs against frameworks/plasma2

2013-11-21 Thread David Edmundson
Long term, I disagree with using the version frameworks everywhere. We want to have a split between Frameworks5.0 and Plasma2.0 and they may not be on the same release cycle. That said; you can rename a version in bugzilla with relative ease, and it will 'update' all existing reports. David

Review Request 114004: Install kio/connection_p.h

2013-11-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114004/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Reporting bugs against frameworks/plasma2

2013-11-21 Thread Kevin Ottens
Hello, On Thursday 21 November 2013 15:59:17 David Edmundson wrote: Long term, I disagree with using the version frameworks everywhere. Agreed... We want to have a split between Frameworks5.0 and Plasma2.0 and they may not be on the same release cycle. That said; you can rename a version

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review44105 --- This review has been submitted with commit

Re: Review Request 113975: Make some KSSL files public API

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113975/#review44133 --- I'd give a ship it, but I'd like David to take a look at it.

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44125 --- tier3/kiconthemes/src/CMakeLists.txt

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44135 --- Don't we have better solutions than installing random private

Review Request 113996: Install needed private headers for FrameworksIntegration

2013-11-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 114003: Install private headers needed by kde4support

2013-11-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

2013-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/#review44141 --- This review has been submitted with commit

Jenkins build became unstable: kdelibs_frameworks_qt5 #1721

2013-11-21 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1721/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

2013-11-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/#review44131 --- Ship it! Ship It! - Kevin Ottens On Nov. 20, 2013, 7:39