Frameworkification of kactivities and plasma-framework

2014-02-12 Thread Ben Cooksley
Hi all, Can someone please frameworkify KActivities? The CI system needs this due to a dependency loop. The new KRunner framework depends on, among others plasma-framework, which in turn depends on kactivities. Previously both these two escaped the need to be fully fledged frameworks, however

Re: alpha1 release

2014-02-12 Thread Kevin Ottens
On Tuesday 11 February 2014 23:19:39 David Faure wrote: On Thursday 06 February 2014 23:30:25 David Faure wrote: I have packaged up KF5 alpha 1 and uploaded it for packagers. And alpha1 is now public ! (tarballs published, git tags pushed) Woohoo! Thanks! Reminder: Alpha 2 in 17 days.

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread David Faure
On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: Makes sense to me, I most certainly didn't consider it as a problem. This could break compilation on some projects other than KParts, will you be able to try the rest of the modules? Thanks for figuring it out! I compiled

Re: kde5 in [app .desktop file install] path

2014-02-12 Thread David Faure
On Tuesday 11 February 2014 21:29:24 Alex Merry wrote: On 11/02/14 20:09, David Faure wrote: On Monday 10 February 2014 11:30:46 Alex Merry wrote: On 09/02/14 23:55, Nicolas Lécureuil wrote: ./kde-modules/KDEInstallDirs.cmake:_set_fancy(XDG_APPS_INSTALL_DIR

Re: Review Request 115541: Build fix for Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/ --- (Updated Feb. 12, 2014, 9:05 a.m.) Status -- This change has been

Re: alpha1 release

2014-02-12 Thread David Gil Oliva
El 12/02/2014 09:46, Kevin Ottens er...@kde.org escribió: On Tuesday 11 February 2014 23:19:39 David Faure wrote: On Thursday 06 February 2014 23:30:25 David Faure wrote: I have packaged up KF5 alpha 1 and uploaded it for packagers. And alpha1 is now public ! (tarballs published,

Build failed in Jenkins: kbookmarks_master_qt5 #23

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/kbookmarks_master_qt5/23/changes Changes: [adawit] When a user creates a new bookmark folder make that the current item. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in

Re: Frameworkification of kactivities and plasma-framework

2014-02-12 Thread Ivan Čukić
The new KRunner framework depends on, among others plasma-framework, which in turn depends on kactivities. It is already under works, thanks to dfaure and marco. Cheers -- Make your code readable. Pretend the next person who looks at your code is a psychopath and they know where you live.

Build failed in Jenkins: kio_master_qt5 #65

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/65/changes Changes: [adawit] Changed OpenWith dialog from Qt::ApplicationModal to Qt::WindowModal. [adawit] Changed dialogs from Qt::ApplicationModal (default) to Qt::WindowModal. -- [...truncated 800 lines...]

Build failed in Jenkins: krunner_master_qt5 #2

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/2/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/#review49647 --- This review has been submitted with commit

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/ --- (Updated Feb. 12, 2014, 10:37 a.m.) Status -- This change has been

Jenkins build is back to normal : kbookmarks_master_qt5 #24

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/kbookmarks_master_qt5/24/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kde5 in [app .desktop file install] path

2014-02-12 Thread Jonathan Riddell
On Tue, Feb 11, 2014 at 09:29:24PM +, Alex Merry wrote: Thinking out loud: with the current efforts in making things co-installable, I wonder... it'll make .desktop files clash between kde4 and kde5. Already solved for kdelibs4 (by renaming the two desktop files in KF5's kio),

Re: alpha1 release

2014-02-12 Thread Kevin Ottens
On Wednesday 12 February 2014 10:11:48 David Gil Oliva wrote: El 12/02/2014 09:46, Kevin Ottens er...@kde.org escribió: On Tuesday 11 February 2014 23:19:39 David Faure wrote: On Thursday 06 February 2014 23:30:25 David Faure wrote: I have packaged up KF5 alpha 1 and uploaded it for

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 12, 2014, 11:03 a.m.) Review request for KDE Frameworks.

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Alex Merry
On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: Makes sense to me, I most certainly didn't consider it as a problem. This could break compilation on some projects other than KParts, will you be able to try the rest of the modules? Thanks for figuring it out! David

Jenkins build is back to normal : kio_master_qt5 #66

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/66/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- Review request for kde-workspace, KDE Frameworks, Plasma, and Sune

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review49650 --- src/notifybypopup.cpp

Build failed in Jenkins: plasma-framework_master_qt5 #1164

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/1164/changes Changes: [notmart] hide remove action for desktop containments -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 115699: Build on Mac OS X

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/#review49653 --- Ship it! yeah Atom is an XLib data type. I plan to make all

Build failed in Jenkins: krunner_master_qt5 #3

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/3/ -- Started by user gateau Building remotely on LinuxSlave - 4 in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe

Build failed in Jenkins: krunner_master_qt5 #4

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/4/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps

Build failed in Jenkins: krunner_master_qt5 #5

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/5/changes Changes: [agateau] Frameworks must not use the find_package(KF5 ...) [agateau] Fix clean build (could not find plasma/querymatch.h) -- Started by remote host 127.0.0.1 with note: Triggered by

Build failed in Jenkins: plasma-framework_master_qt5 #1165

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/1165/changes Changes: [agateau] Do not rely on KF5Umbrella -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49655 --- Ship it! Ship It! - Harald Fernengel On Feb. 11, 2014,

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Harald Fernengel
On Feb. 12, 2014, 12:20 a.m., Aleix Pol Gonzalez wrote: Makes sense to me, I most certainly didn't consider it as a problem. This could break compilation on some projects other than KParts, will you be able to try the rest of the modules? Thanks for figuring it out! David

Build failed in Jenkins: plasma-framework_master_qt5 #1166

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/1166/ -- Started by user gateau Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $

Re: Review Request 115648: Remove kdewebkit transitive dependencies

2014-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115648/#review49656 --- This review has been submitted with commit

Re: Review Request 115648: Remove kdewebkit transitive dependencies

2014-02-12 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115648/ --- (Updated Feb. 12, 2014, 2:24 p.m.) Status -- This change has been

Jenkins build is back to normal : plasma-framework_master_qt5 #1167

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/1167/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: krunner_master_qt5 #6

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/6/ -- Started by user gateau Building remotely on LinuxSlave - 4 in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe

Re: Review Request 115699: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/ --- (Updated Feb. 12, 2014, 3:02 p.m.) Status -- This change has been

Re: Review Request 115699: Build on Mac OS X

2014-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115699/#review49658 --- This review has been submitted with commit

Review Request 115700: Remove unused frameworkintegration dependencies

2014-02-12 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115700/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository:

Re: Frameworkification of kactivities and plasma-framework

2014-02-12 Thread Aurélien Gâteau
On Wed, Feb 12, 2014, at 0:10, Ben Cooksley wrote: Hi all, Can someone please frameworkify KActivities? The CI system needs this due to a dependency loop. The new KRunner framework depends on, among others plasma-framework, which in turn depends on kactivities. Previously both these

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 12, 2014, 4:54 p.m.) Review request for kde-workspace, KDE

Build failed in Jenkins: krunner_master_qt5 #7

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/7/changes Changes: [agateau] Unused include-- -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Review Request 115701: Improve build without X11 support in kde4support

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115701/ --- Review request for KDE Frameworks. Repository: kde4support Description

Jenkins build is back to normal : krunner_master_qt5 #8

2014-02-12 Thread KDE CI System
See http://build.kde.org/job/krunner_master_qt5/8/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115704: Comment out kio OpenSSL dependency checks

2014-02-12 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: let's get ready for Google Summer of Code 2014

2014-02-12 Thread Myriam Schweingruber
Hi all, On Tue, Feb 11, 2014 at 10:56 AM, Sebastian Kügler se...@kde.org wrote: On Monday, February 10, 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done:

Re: let's get ready for Google Summer of Code 2014

2014-02-12 Thread Myriam Schweingruber
On Tue, Feb 11, 2014 at 12:36 PM, Sebastian Kügler se...@kde.org wrote: On Tuesday, February 11, 2014 11:03:39 Myriam Schweingruber wrote: ... And no, it is not enough to be able to guide, you also need people available who can review code. I was able to mentor twice in the past because I was

Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49680 --- src/CMakeLists.txt

[error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

2014-02-12 Thread Shivam Makkar
Hi I'm not able to build framework 5 due to some update error in Krunner, is there any manual method to build it ? I'm also getting Cmake error while installing kwallet, the error seems to be like some git conflict in cmaketext in kwallet. Am I the only one facing these problems ? :P Please

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49682 --- Ship it! It seems to work correctly, so ship it from my

Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Luigi Toscano
On Feb. 12, 2014, 9:48 p.m., Harald Fernengel wrote: src/CMakeLists.txt, line 149 https://git.reviewboard.kde.org/r/115708/diff/1/?file=243799#file243799line149 Note - cmake is documented to replace the COMMAND by the actual command, as we added it with add_executable before.

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review49684 --- Ping? Should I send this patch differently or something? -

Re: Review Request 115526: Refactor private class member variables of KCompletionBase for readability

2014-02-12 Thread David Gil Oliva
On Feb. 12, 2014, 7:26 a.m., David Faure wrote: I kind of like the m_ prefix even in Private classes, for the readability of methods in that class. But no big deal, won't veto this since Qt doesn't use m_. I'm more a Qt-ish kind of man ;-) But I'm glad to know that there are people

Re: Review Request 115526: Refactor private class member variables of KCompletionBase for readability

2014-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115526/#review49686 --- This review has been submitted with commit

Re: Review Request 115526: Refactor private class member variables of KCompletionBase for readability

2014-02-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115526/ --- (Updated Feb. 12, 2014, 11:46 p.m.) Status -- This change has been

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-12 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/#review49689 --- fyi,

Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

2014-02-12 Thread Martin Gräßlin
On Thursday 13 February 2014 02:29:21 Shivam Makkar wrote: Hi I'm not able to build framework 5 due to some update error in Krunner, is there any manual method to build it ? Yes, I hit the same problem yesterday when compiling with kdesrc-build. Steps to fix: 1. cd frameworks (src

Review Request 115711: Introduce a config-kstyle.h.cmake

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115711/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49691 --- I locally fixed the 'if (WIN32)' issue in CMakeLists.txt and

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/ --- (Updated Feb. 13, 2014, 6:51 a.m.) Status -- This change has been

Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/ --- Review request for KDE Frameworks, kdewin and Marco Martin. Repository:

Review Request 115714: Only use xtest code if we are on platform X11

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115714/ --- Review request for KDE Frameworks. Repository: knotifications

Re: Review Request 115704: Comment out kio OpenSSL dependency checks

2014-02-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/#review49697 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 5:54

Review Request 115715: Remove X11 dependency from kprintutils

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- Review request for KDE Frameworks, kdewin and John Layt. Repository: