Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-30 Thread David Faure
On Saturday 29 March 2014 22:06:10 Chusslove Illich wrote: [: Luigi Toscano :] I'm a bit confused now: what files are to be renamed? The ones in the SVN repository under lang/messages/entry.desktop? I think that the best solution at the moment is: don't rename anything in the

Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-30 Thread Chusslove Illich
[: Chusslove Illich :] I think that the best solution at the moment is: don't rename anything in the repositories, and also don't install these files at all. When it is decided how the language selection will work with KF5, revisit this matter. [: David Faure :] Well, yes, but it's time to

qt5 stable: qengineio: fatal: remote error: access denied or repository not exported

2014-03-30 Thread Gregor Mi
Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure

Re: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported

2014-03-30 Thread Gregor Mi
On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal:

Re: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported

2014-03-30 Thread Aleix Pol
On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.dewrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone

Re: Moving KPlugionLoader|Factory to KCoreAddons?

2014-03-30 Thread Alex Merry
On 29/03/14 15:57, Alex Merry wrote: I just realised a flaw with this: KPluginLoader has a constructor that takes a KService argument. Which is annoying, because the only difference between KPluginLoader(service) and KPluginLoader(service.library()) is the error message you get if the

Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:28 a.m.) Review request for KDE Frameworks

Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-30 Thread David Faure
On Sunday 30 March 2014 10:24:28 Chusslove Illich wrote: [: Chusslove Illich :] I think that the best solution at the moment is: don't rename anything in the repositories, and also don't install these files at all. When it is decided how the language selection will work with KF5, revisit

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:41 a.m.) Review request for KDE Frameworks,

Re: Review Request 117161: Drop QApplication usages in units.cpp

2014-03-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/#review54589 --- Ship it! Ship It! - Sebastian Kügler On March 29, 2014,

Jenkins build became unstable: threadweaver_master_qt5 #42

2014-03-30 Thread KDE CI System
See http://build.kde.org/job/threadweaver_master_qt5/42/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 30, 2014, 2:03 p.m.) Status -- This change has been

Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54602 --- This review has been submitted with commit

Review Request 117190: Improve tests

2014-03-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-30 Thread Nicolás Alvarez
On March 28, 2014, 10:49 a.m., Alexander Richardson wrote: src/lib/util/kuser_win.cpp, line 391 https://git.reviewboard.kde.org/r/117131/diff/1/?file=257913#file257913line391 WCHAR pathBuf[MAX_PATH]; then you don't need the reinterpret_cast and can use

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-30 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- (Updated March 30, 2014, 12:35 p.m.) Review request for KDE Frameworks

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-30 Thread Gregor Mi
On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]?

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-30 Thread Andrius da Costa Ribas
On March 27, 2014, 3:47 p.m., Kevin Ottens wrote: src/kjsembed/CMakeLists.txt, line 75 https://git.reviewboard.kde.org/r/117012/diff/1/?file=256496#file256496line75 Agreed, that should be the preferred way. Note that some other frameworks probably carry the same mistake

Re: Review Request 117161: Drop QApplication usages in units.cpp

2014-03-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/#review54645 --- This review has been submitted with commit

Re: Review Request 117161: Drop QApplication usages in units.cpp

2014-03-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/ --- (Updated March 30, 2014, 9:06 p.m.) Status -- This change has been

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-30 Thread Aleix Pol
On Sun, Mar 30, 2014 at 6:38 PM, Gregor Mi codeminis...@publicstatic.dewrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi,

Re: build qt5 stable / SOLVED

2014-03-30 Thread Gregor Mi
On 30/03/14 23:07, Aleix Pol wrote: On Sun, Mar 30, 2014 at 6:38 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de

Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-30 Thread Chusslove Illich
[: Chusslove Illich :] There I propose not to have language entry.desktop files any more :) [: David Faure :] And, what do we use instead, to show the user a list of languages to choose from (i.e. for which translations are installed)? I don't think the concept of installed translations is

Re: Move KDED out of frameworks?

2014-03-30 Thread Albert Astals Cid
El Divendres, 28 de març de 2014, a les 20:55:02, Boudewijn Rempt va escriure: On Fri, 28 Mar 2014, Kevin Krammer wrote: The D-Bus session/user daemon is also something that needs to be treated in a platform specific way as a dependency. E.g. on Windows there could be a D-Bus installer that

Review Request 117194: Remove weird comment

2014-03-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- Review request for KDE Frameworks. Repository: kbookmarks Description

Does KKeyserver QT_TR_NOOP work?

2014-03-30 Thread Albert Astals Cid
Running lupdate complains so I'm not sure it does /home/scripty/prod/git- unstable/frameworks_kwindowsystem/src/kkeyserver_x11.cpp:88: Class 'KKeyServer' lacks Q_OBJECT macro Note that KKeyServer is not a class... Cheers, Albert ___

Does sonnet tr() work?

2014-03-30 Thread Albert Astals Cid
/home/scripty/prod/git- unstable/frameworks_sonnet/src/ui/spellcheckdecorator.cpp:35: Ignoring definition of undeclared qualified class /home/scripty/prod/git- unstable/frameworks_sonnet/src/ui/spellcheckdecorator.cpp:137: Qualifying with unknown namespace/class ::SpellCheckDecorator Cheers,

Re: Review Request 117194: Remove weird comment

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/#review54646 --- Ship it! Well, it's not doing anything useful commented out

Re: Review Request 117194: Remove weird comment

2014-03-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/#review54648 --- This review has been submitted with commit

Re: Review Request 117194: Remove weird comment

2014-03-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/#review54647 --- Ship it! Ship It! - David Faure On March 30, 2014, 10:05

Re: Review Request 117194: Remove weird comment

2014-03-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- (Updated March 30, 2014, 10:18 p.m.) Status -- This change has been

Re: Lots of duplicated catalogs

2014-03-30 Thread Aleix Pol
On Mon, Mar 31, 2014 at 12:15 AM, Albert Astals Cid aa...@kde.org wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot $ find -name

Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Lots of duplicated catalogs

2014-03-30 Thread Aleix Pol
On Mon, Mar 31, 2014 at 12:30 AM, Luigi Toscano luigi.tosc...@tiscali.itwrote: Aleix Pol ha scritto: On Mon, Mar 31, 2014 at 12:15 AM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot

Re: Lots of duplicated catalogs

2014-03-30 Thread Albert Astals Cid
El Dilluns, 31 de març de 2014, a les 00:43:09, Aleix Pol va escriure: On Mon, Mar 31, 2014 at 12:30 AM, Luigi Toscano luigi.tosc...@tiscali.itwrote: Aleix Pol ha scritto: On Mon, Mar 31, 2014 at 12:15 AM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: $ find

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-30 Thread Ben Cooksley
On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi,