On May 28, 2014, 8:10 a.m., Martin Gräßlin wrote:
kcms/keyboard/kcmmisc.cpp, lines 77-78
https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77
for new connects I would use the new compile time checked syntax.
shivam makkar wrote:
I tried it but it was
On Thursday 19 June 2014 19:26:45 Vishesh Handa wrote:
Hey guys
I've been looking into kglobalaccel in order to fix some problems that I
was having. I seems to have opened a can of worms.
Background Information: KGlobalAccel has 2 kinds of shortcuts - Active
Shortcuts and Default
On Thursday 19 June 2014 23:38:05 Luigi Toscano wrote:
Marco Martin ha scritto:
Hi all,
I was thinking, since the policy for committing in frameworks is to always
asking for a review, what about on repositories under frameworks/* adding
an hook that accepts pushes only if the comment has
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118842/#review60578
---
Ship it!
Ship It!
- Marco Martin
On June 20, 2014, 12:26
On June 18, 2014, 12:50 a.m., Matthew Dawson wrote:
autotests/kdesktopfiletest.cpp, line 88
https://git.reviewboard.kde.org/r/118692/diff/2-3/?file=280487#file280487line88
Please add a test for both:
- when both the country/language match and a modifier is included.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118780/
---
(Updated June 20, 2014, 9:03 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118780/#review60580
---
This review has been submitted with commit
See http://build.kde.org/job/kio_master_qt5/267/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
--
[...truncated 844 lines...]
[ 17%] [ 17%] Automatic moc for target kioslave-httpauthenticationtest
Automatic moc for target
See http://build.kde.org/job/frameworkintegration_master_qt5/81/changes
Changes:
[mgraesslin] Disable the xcb flush connection workaround for Qt = 5.3.1
--
[...truncated 56 lines...]
kiconthemes - Branch master
kbookmarks - Branch master
See http://build.kde.org/job/kdelibs4support_master_qt5/224/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
--
[...truncated 540 lines...]
Scanning dependencies of target kdialogbuttonboxtest_automoc
[ 14%] [ 14%] [ 14%] Automatic moc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118725/#review60583
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118725/
---
(Updated June 20, 2014, 9:50 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118844/
---
Review request for KDE Frameworks and Vishesh Handa.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118842/
---
(Updated June 20, 2014, 10:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118842/#review60584
---
This review has been submitted with commit
On Fri, Jun 20, 2014 at 7:40 AM, Kevin Ottens er...@kde.org wrote:
On Friday 20 June 2014 01:46:10 Aleix Pol wrote:
On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin notm...@gmail.com
wrote:
Hi all,
I was thinking, since the policy for committing in frameworks is to
always
asking for a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118783/
---
(Updated June 20, 2014, 11:18 a.m.)
Status
--
This change has been
On June 20, 2014, 1:17 p.m., Vishesh Handa wrote:
I approve.
The only problem I have is with the documentation, but we can improve that
in another patch.
well let's improve directly. What do you think is missing with these new
methods or is that more a general comment?
- Martin
See
http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/73/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See http://build.kde.org/job/kde-baseapps_frameworks_qt5/29/changes
Changes:
[scarlett] kde-baseapps frameworks dolphin with snapshot frameworks branch
baloo/baloo-widgets path fixes.
--
[...truncated 1142 lines...]
^
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/
---
Review request for KDE Frameworks, David Faure and Harald Sitter.
Bugs:
See http://build.kde.org/job/kcmutils_master_qt5/60/
--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kcmutils_master_qt5/ws/
Running Prebuild steps
[kcmutils_master_qt5] $
See http://build.kde.org/job/kded_master_qt5/63/
--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kded_master_qt5/ws/
Running Prebuild steps
[kded_master_qt5] $ /bin/sh -xe
See http://build.kde.org/job/kdesu_master_qt5/52/
--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kdesu_master_qt5/ws/
Running Prebuild steps
[kdesu_master_qt5] $ /bin/sh -xe
See http://build.kde.org/job/kemoticons_master_qt5/60/
--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kemoticons_master_qt5/ws/
Running Prebuild steps
[kemoticons_master_qt5]
See http://build.kde.org/job/kdewebkit_master_qt5/43/
--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kdewebkit_master_qt5/ws/
Running Prebuild steps
[kdewebkit_master_qt5] $
See http://build.kde.org/job/kio_master_qt5/268/changes
Changes:
[faure] Use QDBusConnection instead of KDBusConnectionPool.
[adawit] Do not send config reparse notification to suspended ioslaves.
[scripty] SVN_SILENT made messages (.desktop file)
--
See http://build.kde.org/job/knotifications_master_qt5/83/
--
[...truncated 4 lines...]
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/knotifications
See http://build.kde.org/job/kparts_master_qt5/75/
--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kparts_master_qt5/ws/
Running Prebuild steps
[kparts_master_qt5] $ /bin/sh
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/#review60591
---
Ship it!
looks good to me
- Harald Sitter
On June 20,
See http://build.kde.org/job/ktexteditor_master_qt5/425/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On June 20, 2014, 11:17 a.m., Vishesh Handa wrote:
I approve.
The only problem I have is with the documentation, but we can improve that
in another patch.
Martin Gräßlin wrote:
well let's improve directly. What do you think is missing with these new
methods or is that more a
On June 17, 2014, 6:50 p.m., Matthew Dawson wrote:
autotests/kdesktopfiletest.cpp, line 88
https://git.reviewboard.kde.org/r/118692/diff/2-3/?file=280487#file280487line88
Please add a test for both:
- when both the country/language match and a modifier is included.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/#review60615
---
Strange, why wasn't this necessary in kdelibs4?
- David
On 19/06/14 00:32, Aleix Pol wrote:
On Wed, Jun 18, 2014 at 10:56 PM, Ben Cooksley bcooks...@kde.org
mailto:bcooks...@kde.org wrote:
Note though that I consider this a workaround for an upstream
regression which we have detected.
One of the reasons the CI system runs the next
On 19/06/14 22:21, Marco Martin wrote:
Hi all,
I was thinking, since the policy for committing in frameworks is to always
asking for a review, what about on repositories under frameworks/* adding an
hook that accepts pushes only if the comment has a REVIEW: line?
I have been guilty too
On Friday 20 June 2014 19:25:19 Alex Merry wrote:
On 19/06/14 22:21, Marco Martin wrote:
Hi all,
I was thinking, since the policy for committing in frameworks is to always
asking for a review, what about on repositories under frameworks/* adding
an hook that accepts pushes only if the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118692/#review60621
---
Ship it!
Ship It!
- Matthew Dawson
On June 20, 2014, 4:56
2014-05-07 14:15 GMT-03:00 Thomas Braxton kde.brax...@gmail.com:
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118039/
Review request for KDE Frameworks and kdewin.
By Thomas Braxton.
Summary
Simplify KConfig::readEntry/writeEntry
El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure:
On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin notm...@gmail.com wrote:
Hi all,
I was thinking, since the policy for committing in frameworks is to always
asking for a review, what about on repositories under
El Divendres, 20 de juny de 2014, a les 07:33:34, Kevin Ottens va escriure:
Hello,
On Thursday 19 June 2014 22:30:26 André Wöbbeking wrote:
I wanted to give KF5 a try and followed the instructions from
http://community.kde.org/Frameworks/Building. After Albert told me not to
use Clang
On June 20, 2014, 7:05 p.m., David Faure wrote:
Strange, why wasn't this necessary in kdelibs4?
see the linked bug report. It's basically a regression due to introducing
platform detection (X11 vs. Wayland) in both klauncher and KWindowSystem. My
first idea to fix it was to check for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/
---
(Updated June 20, 2014, 9:24 p.m.)
Review request for kde-workspace, KDE
On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote:
kcms/keyboard/kcmmisc.cpp, lines 77-78
https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77
for new connects I would use the new compile time checked syntax.
shivam makkar wrote:
I tried it but it was
On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
kcms/keyboard/flags.cpp, line 21
https://git.reviewboard.kde.org/r/118366/diff/4/?file=276646#file276646line21
remove?
see the latest revision, apparently the diff is showing all the revisions made
to the same file.
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/#review60630
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 20, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118852/
---
Review request for KDE Frameworks and kdewin.
Repository: kconfig
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118853/
---
Review request for KDE Frameworks and Christoph Feck.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118692/#review60635
---
This review has been submitted with commit
49 matches
Mail list logo
