Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated août 22, 2014, 6:25 matin) Review request for KDE Frameworks,

Suggestion to ntroduce an application for testing config paths and access to files installed by cmake or created at runtime

2014-08-22 Thread Marko Käning
Hi devs, in the light of RR 119895 [1] I wanted to ask whether you guys could perhaps come up with a dedicated little test application which should be able to verify all possible file accesses to configs, plugins, read-only and writable data. For the manipulation of QStandardPaths on OSX it

Re: Suggestion to ntroduce an application for testing config paths and access to files installed by cmake or created at runtime

2014-08-22 Thread David Faure
On Friday 22 August 2014 09:21:13 Marko Käning wrote: 1) files installed by cmake indeed land where the application expects them at runtime You can write a script that checks that, using the qtpaths executable. For instance xmlgui says kxmlguiclient.cpp:199:const QString file =

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated août 22, 2014, 9:05 matin) Review request for KDE Frameworks,

Re: Review Request 119867: Fix CustomStyleElement

2014-08-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/ --- (Updated Aug. 22, 2014, 9:23 a.m.) Review request for KDE Frameworks and

Re: Suggestion to ntroduce an application for testing config paths and access to files installed by cmake or created at runtime

2014-08-22 Thread Cristian Oneț
Hi, I would like to add that the Windows platform has similar issues QStandardPaths does not match with the paths were cmake installs these files. As a temporary workaround we use this dirty hack [1] (patch Qt) to add the paths where cmake installs stuff to QStandardPaths. We also need to setup

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/#review65016 --- src/lib/util/kdelibs4configmigrator.h

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
On août 22, 2014, 9:39 matin, Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? - Laurent ---

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? I just found it strange. To me it is

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated août 22, 2014, 10:55 matin) Review request for KDE Frameworks,

Re: Review Request 119884: Add cursor shape property to MouseEventListener

2014-08-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119884/#review65027 --- Ship it!

Re: Review Request 119867: Fix CustomStyleElement

2014-08-22 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/#review65028 --- src/kstyle/kstyle.cpp

Re: Review Request 119867: Fix CustomStyleElement

2014-08-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/ --- (Updated Aug. 22, 2014, 11:27 a.m.) Review request for KDE Frameworks

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-22 Thread Martin Klapetek
On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: Well, you only get the frameworks integration when you're running Plasma 5... Actually, frameworksintegration should move to kde/workspace at least. It's not a framework. Martin Klapetek wrote: Well the message boxes

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread David Faure
On Aug. 22, 2014, 9:39 a.m., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
On août 22, 2014, 9:39 matin, Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-08-22 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- Review request for Build System and KDE Frameworks. Repository:

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-08-22 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65037 --- Looks good. THere is a couple of things that is kind of a

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/#review65040 --- Ship it! Ship It! - David Edmundson On Aug. 1, 2014, 2:29

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread David Faure
On Aug. 22, 2014, 9:39 a.m., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119884: Add cursor shape property to MouseEventListener

2014-08-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119884/ --- (Updated Aug. 22, 2014, 1:44 p.m.) Status -- This change has been

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
On août 22, 2014, 9:39 matin, Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-22 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 22, 2014, 3:48 p.m.) Status -- This change has been

Re: Suggestion to ntroduce an application for testing config paths and access to files installed by cmake or created at runtime

2014-08-22 Thread Marko Käning
Hi David, Hi Mario, On 22 Aug 2014, at 09:35 , David Faure fa...@kde.org wrote: On Friday 22 August 2014 09:21:13 Marko Käning wrote: 1) files installed by cmake indeed land where the application expects them at runtime You can write a script that checks that, using the qtpaths executable.

Review Request 119907: KIO: Correctly generate previews.

2014-08-22 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119907/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 119907: KIO: Correctly generate previews.

2014-08-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119907/#review65072 --- Just as a little sanity check: Did you try with the Folder

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65074 --- Is this going to lead to make install installing plugins into

Re: Review Request 119907: KIO: Correctly generate previews.

2014-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119907/#review65075 --- Ship it! Double oops from me. - David Faure On Aug. 22,

KAnagram QML WebView crash

2014-08-22 Thread Jeremy Whiting
Hello all, I'm reaching out because I can't seem to find a solution myself. TLDR If you can get a backtrace from building and running scratch/whiting/testqmlapp which uses QtWebKit's QML WebView I'd very much appreciate it. KAnagram qt4 version from master (before frameworks branch was merged)

Re: KAnagram QML WebView crash

2014-08-22 Thread Albert Astals Cid
El Divendres, 22 d'agost de 2014, a les 15:45:12, Jeremy Whiting va escriure: Hello all, I'm reaching out because I can't seem to find a solution myself. TLDR If you can get a backtrace from building and running scratch/whiting/testqmlapp which uses QtWebKit's QML WebView I'd very much

Re: KAnagram QML WebView crash

2014-08-22 Thread Jeremy Whiting
Sorry all, seems this is something wrong with my local setup. Though I've no clue what would cause these issues. If anyone has any ideas for me to try I'll try anything to get back to where I can work on fixing real issues rather than strange crashes that are only on my system :) I'll keep digging

Re: OSX/CI: ?NEW? qt5 build failure !!!

2014-08-22 Thread Marko Käning
Today I was able to successfully build qt5 again! :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel