Re: Review Request 124289: [kidletime] Install private headers for platform plugins

2015-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124289/#review82221 --- Ship it! It's what I would have expected for private

Re: Review Request 124288: [kwindowsystem] Install private headers for platform plugins

2015-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124288/#review82220 --- Ship it! It's what I would have expected for private

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

2015-07-08 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82234 --- src/knotificationmanager.cpp (line 92)

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-08 Thread Jesse Jaara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 8, 2015, 5:10 ip) Review request for KDE Frameworks and

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

2015-07-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82237 --- src/pluginwrapper.cpp (line 68)

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

2015-07-08 Thread Mark Gaiser
On jul 7, 2015, 7:38 p.m., Martin Klapetek wrote: I'm looking at the KNotifications dependency graph here [1] and see that KWindowSystem is only required for KCrash. So err, can't that one go as well since you removed KService which required KCrash which then required KWindowSystem?

Review Request 124288: [kwindowsystem] Install private headers for platform plugins

2015-07-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124288/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Review Request 124289: [kidletime] Install private headers for platform plugins

2015-07-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124289/ --- Review request for KDE Frameworks. Repository: kidletime Description