Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124487/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet

Re: Review Request 124413: Enable PAM opening KWallet again

2015-07-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 27, 2015, 11:06 a.m.) Status -- This change has been

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Martin Klapetek
On July 27, 2015, 3:15 p.m., Aleix Pol Gonzalez wrote: src/runtime/kwalletd/main.cpp, line 213 https://git.reviewboard.kde.org/r/124487/diff/1/?file=388026#file388026line213 qCDebug? KWallet does not use qCDebug, so..perhaps in another patch? - Martin

Re: Review Request 124372: Fix crash when MigrationAgent::isEmptyOldWallet() check fails

2015-07-27 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124372/ --- (Updated July 27, 2015, 12:58 p.m.) Status -- This change has been

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124487/#review83044 --- src/runtime/kwalletd/main.cpp (line 213)

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Aleix Pol Gonzalez
On July 27, 2015, 3:15 p.m., Aleix Pol Gonzalez wrote: src/runtime/kwalletd/main.cpp, line 213 https://git.reviewboard.kde.org/r/124487/diff/1/?file=388026#file388026line213 qCDebug? Martin Klapetek wrote: KWallet does not use qCDebug, so..perhaps in another patch? ok. -

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Aleix Pol Gonzalez
On July 27, 2015, 3:15 p.m., Aleix Pol Gonzalez wrote: src/runtime/kwalletd/main.cpp, line 213 https://git.reviewboard.kde.org/r/124487/diff/1/?file=388026#file388026line213 qCDebug? Martin Klapetek wrote: KWallet does not use qCDebug, so..perhaps in another patch? Aleix

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124487/#review83057 --- Ship it! Ship It! - Valentin Rusu On July 27, 2015, 11:22

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Valentin Rusu
On July 27, 2015, 1:15 p.m., Aleix Pol Gonzalez wrote: src/runtime/kwalletd/main.cpp, line 213 https://git.reviewboard.kde.org/r/124487/diff/1/?file=388026#file388026line213 qCDebug? Martin Klapetek wrote: KWallet does not use qCDebug, so..perhaps in another patch? Aleix

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 9 - Failure!

2015-07-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jul 2015 19:10:47 + Build duration: 0.52 sec CHANGE SET No changes

Jenkins-kde-ci: kxmlrpcclient master stable-kf5-qt5 » Linux,gcc - Build # 9 - Failure!

2015-07-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Jul 2015 19:09:09 + Build duration: 2 min 0 sec CHANGE SET Revision

Re: Review Request 124467: Don't generate deprecated code

2015-07-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124467/ --- (Updated July 27, 2015, 10:43 a.m.) Status -- This change has been

Re: Review Request 124372: Fix crash when MigrationAgent::isEmptyOldWallet() check fails

2015-07-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124372/#review83016 --- Ship it! Ship It! - Valentin Rusu On July 16, 2015, 1:11

Review Request 124482: Search for required perl modules.

2015-07-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124482/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 60 - Fixed!

2015-07-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/60/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 27 Jul 2015 09:43:27 + Build duration: 6 min 28 sec CHANGE SET

Re: Review Request 124482: Search for required perl modules.

2015-07-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124482/#review83021 --- Ship it! Long overdue, thanks A LOT! - Luigi Toscano On

Re: Review Request 124482: Search for required perl modules.

2015-07-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124482/ --- (Updated July 27, 2015, 9:19 a.m.) Status -- This change has been