Re: QIcon::fromTheme(xxx, someFallback)

2015-09-09 Thread Olivier Goffart
On Tuesday 8. September 2015 10:26:20 David Faure wrote: > On Monday 07 September 2015 15:53:31 Olivier Goffart wrote: > > But the problem is that QIcon::isNull is likely to be called anyway. > > And this will again do all the look ups in the file system. > > I don't think so. That's the whole

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2015-09-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 06:52:33 + Build duration: 1 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2015-09-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 06:52:28 + Build duration: 1 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 09:24:14 + Build duration: 3 min 38 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 09:24:14 + Build duration: 3 min 38 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 76 - Successful!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 10:55:41 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 83 - Successful!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 10:55:20 + Build duration: 4 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 75 - Aborted!

2015-09-09 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/75/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 10:14:34 + Build duration: 5.3 sec CHANGE SET Revision 47ab2a9c667ddf9ae6fcc4aa4dab9558e7a26a1b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 82 - Aborted!

2015-09-09 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 10:14:34 + Build duration: 4.9 sec CHANGE SET Revision 47ab2a9c667ddf9ae6fcc4aa4dab9558e7a26a1b by

Jenkins-kde-ci: sonnet master kf5-qt5 » Linux,gcc - Build # 22 - Aborted!

2015-09-09 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/sonnet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 09:34:39 + Build duration: 3.8 sec CHANGE SET Revision 73bd8623250d3691d3f33d256f65f10ae7ca220a by

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 09:24:14 + Build duration: 3 min 19 sec CHANGE SET Revision

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 24 - Aborted!

2015-09-09 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 09:34:39 + Build duration: 4 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 09:24:14 + Build duration: 3 min 19 sec CHANGE SET Revision

Review Request 125116: Fix install path

2015-09-09 Thread Giuseppe Calà
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/ --- Review request for KDE Frameworks. Repository: kwallet-pam Description

Re: Review Request 125116: Fix install path

2015-09-09 Thread Giuseppe Calà
- Giuseppe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/#review85051 --- On Set. 9, 2015, 1:58 p.m., Giuseppe Calà

Jenkins-kde-ci: sonnet master kf5-qt5 » Linux,gcc - Build # 23 - Successful!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sonnet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 11:41:36 + Build duration: 1 min 36 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 125116: Fix install path

2015-09-09 Thread Giuseppe Calà
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/ --- (Updated Set. 9, 2015, 1:58 p.m.) Review request for KDE Frameworks.

Re: Review Request 125116: Fix install path

2015-09-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/#review85052 --- > The current CMakeLists.txt has the result, in Chakra Linux,

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 25 - Successful!

2015-09-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 11:41:17 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 125116: Fix install path

2015-09-09 Thread Giuseppe Calà
> On Set. 9, 2015, 2:01 p.m., Martin Klapetek wrote: > > > The current CMakeLists.txt has the result, in Chakra Linux, to install > > > the library in /lib64 wich is wrong > > > > Can you please explain why is it wrong? In archlinux/chakra all files in the /lib directory have been moved to

Review Request 125115: kcmshell5 cookies: fix DBus names for kded5

2015-09-09 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125115/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 125116: Fix install path

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/#review85051 --- Are you sure you tried the latest source from master branch?

Re: Review Request 125116: Fix install path

2015-09-09 Thread Giuseppe Calà
> On Set. 9, 2015, 1:59 p.m., Pinak Ahuja wrote: > > Are you sure you tried the latest source from master branch? I already > > submitted https://git.reviewboard.kde.org/r/124962/ to fix the behaviour > > you are mentioning. Nope, I didn't see your last commit. Let me check... EDIT: indeed,

Re: KService, ksycoca and translations

2015-09-09 Thread Albert Astals Cid
El Dimarts, 8 de setembre de 2015, a les 22:08:58, David Faure va escriure: > On Monday 07 September 2015 23:34:54 Albert Astals Cid wrote: > > El Dilluns, 7 de setembre de 2015, a les 23:28:40, Albert Astals Cid va > > > > escriure: > > > Running > > > > > >LANGUAGE=de kcmshell5 --list > >

Re: Review Request 125121: Move checkGlobalHeader() within KBuildSycoca::recreate().

2015-09-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125121/#review85078 --- Ship it! Makes sense. - Albert Astals Cid On set. 9,

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-09 Thread Martin Klapetek
On Wed, Sep 9, 2015 at 5:30 PM, Volker Krause wrote: > Olivier and me just did some profiling here, in all possible combination. > > The results are that both the GTK icon index and the lazy null patch bring > significant improvements (~20% on KMail). With both of them pure Qt

Re: Review Request 125108: kbuildsycoca: remove code for --checkstamps and --nocheckfiles.

2015-09-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125108/#review85077 --- Ship it! Logic looks solid :) - Albert Astals Cid On set.

Review Request 125121: Move checkGlobalHeader() within KBuildSycoca::recreate().

2015-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125121/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125116: Fix install path

2015-09-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/#review85056 --- +1 Similar patches have happened on most KDE projects

Re: Review Request 125115: kcmshell5 cookies: fix DBus names for kded5

2015-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125115/#review85063 --- Ship it! Yes, clearly. I have plans to turn that kded

Re: Review Request 125115: kcmshell5 cookies: fix DBus names for kded5

2015-09-09 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125115/ --- (Updated Sept. 9, 2015, 7:55 p.m.) Status -- This change has been

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-09 Thread Volker Krause
On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > On Tuesday 8. September 2015 10:26:20 David Faure wrote: > > On Monday 07 September 2015 15:53:31 Olivier Goffart wrote: > > > But the problem is that QIcon::isNull is likely to be called anyway. > > > And this will again do all the

Re: Review Request 125116: Fix install path

2015-09-09 Thread Giuseppe Calà
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125116/ --- (Updated set. 9, 2015, 9:44 p.m.) Status -- This change has been