Re: Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

2015-11-15 Thread René J . V . Bertin
> On Nov. 15, 2015, 12:33 a.m., Aleix Pol Gonzalez wrote: > > src/runtime/kwallet-query/src/CMakeLists.txt, line 20 > > > > > > Why only for APPLE? > > René J.V. Bertin wrote: > Mostly because I didn't want

Re: [OS X] should kauth-policy-gen be an app bundle?

2015-11-15 Thread Aleix Pol
On Sun, Nov 15, 2015 at 12:38 PM, René J. V. wrote: > Aleix Pol wrote: > > >> Not really, as anything installed in libexec. > > Is it OK to push the change to the respective CMakeLists.txt without doing a > RR > first, and if so, is there any risk to changing this on all

Re: Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

2015-11-15 Thread Aleix Pol Gonzalez
> On Nov. 15, 2015, 12:33 a.m., Aleix Pol Gonzalez wrote: > > src/runtime/kwallet-query/src/CMakeLists.txt, line 20 > > > > > > Why only for APPLE? > > René J.V. Bertin wrote: > Mostly because I didn't want

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/#review88390 --- src/plugins/osx/macpoller.h (line 31)

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-15 Thread René J . V . Bertin
On Nov. 16, 2015, 12:19 a.m., René J.V. Bertin wrote: > > In fact, I'm quite sure that as is it already is broken without the #define Hmm? What do you think I broke that wasn't broken before (again, apart from the bare idle time detection, the original code doesn't work for me). Anyway, I'm