Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 10:05 a.m., Marco Martin wrote: > > a public symbol could even be spared (and in the process made possibleto > > use it from pure qml) by making an import instead that does the > > setContextObject() injection in its setupEngine (that would happen > > immediately after an

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- (Updated Nov. 18, 2015, 5:38 p.m.) Status -- This change has been

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Il Wed, 18 Nov 2015 17:28:27 +0100, René J.V. Bertin ha scritto: > If we're starting to call names arguing indeed becomes pointless as the > apparent lack of actual reading my arguments already suggested. It In the interest of the CoC and before people heat up, Martin said: "Thus the code is

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 9:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Nov. 16, 2015, 12:56 p.m., Heiko Tietze wrote: > > Ship It! I'm assuming that yours is a ship-it only from the usability side, right? - Elvis --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/ --- (Updated Nov. 18, 2015, 5:35 p.m.) Status -- This change has been

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/ --- (Updated Nov. 18, 2015, 5:35 p.m.) Review request for KDE Software on

Re: Review Request 125960: Fix build of some projects using ecm_create_qm_loader()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125960/ --- (Updated Nov. 18, 2015, 4:11 p.m.) Status -- This change has been

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

On Wednesday November 18 2015 15:01:59 Martin Gräßlin wrote: > idiotic If we're starting to call names arguing indeed becomes pointless as the apparent lack of actual reading my arguments already suggested. It leaves me with no other choice but to discard the RR and put up a mirror in place.

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88544 --- Errr... you intend to crash applications depending on whether

Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/ --- Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? Err... it **doesn't** cause a crash with the patch, causes a crash

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 18, 2015, 8:06 nachm., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it **doesn't** cause a crash

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it **doesn't** cause a crash with

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 17, 2015, 11:58 p.m., Lamarque Souza wrote: > > src/plugins/osx/macpoller.h, line 24 > > > > > > Nitpick: this should go after #include Any guidelines that dictate this? > On Nov. 17, 2015, 11:58

Re: KIdleTime: early and/or failing/rejected timeout detection?

Actually, there is one thing I may have missed in the documentation, if it's there: Is KIdleTime supposed to detect system idling, or application idling? As it happens, it should be possible to make a distinction between the two with the latest implementation I made. As to using an agent to

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 9:43 a.m., Chusslove Illich wrote: > > Could you also document the usage in docs/programmers-guide.md (section > > #link_cat)? I'm not much into QML, so it would help me understand the > > implications of the usage. > > > > It seems to me other three series of calls

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 11:05 a.m., Marco Martin wrote: > > a public symbol could even be spared (and in the process made possibleto > > use it from pure qml) by making an import instead that does the > > setContextObject() injection in its setupEngine (that would happen > > immediately after an

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/ --- (Updated Nov. 18, 2015, 1:26 p.m.) Review request for KDE Frameworks,

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Нов. 17, 2015, 9:43 пре п., Chusslove Illich wrote: > > Could you also document the usage in docs/programmers-guide.md (section > > #link_cat)? I'm not much into QML, so it would help me understand the > > implications of the usage. > > > > It seems to me other three series of calls

Re: KIdleTime: early and/or failing/rejected timeout detection?

Am 2015-11-18 12:33, schrieb René J. V. Bertin: Actually, there is one thing I may have missed in the documentation, if it's there: Is KIdleTime supposed to detect system idling, or application idling? As it happens, it should be possible to make a distinction between the two with the

Re: KIdleTime: early and/or failing/rejected timeout detection?

Hi, >> There's also always the possibility to reconsider implementing an >> Xcb-style >> alarm based mechanism that relies on a helper process, if it turns out >> in the >> future that KIdleTime/Mac is causing significant amounts of overhead. >> But >> KIdleTime has changed only minimally from

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 17, 2015, 11:58 p.m., Lamarque Souza wrote: > > src/plugins/osx/macpoller_helper.mm, line 54 > > > > > > Usually when a new operation returns 0 it is because system is on short > > on RAM memory (or

Re: KIdleTime: early and/or failing/rejected timeout detection?

On Wed, Nov 18, 2015 at 12:33 PM, René J. V. wrote: > Actually, there is one thing I may have missed in the documentation, if it's > there: > > Is KIdleTime supposed to detect system idling, or application idling? As it > happens, it should be possible to make a distinction

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88554 --- Ship it! I'm a little hesitant about this, but ship it. A

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88553 --- Ship it! src/knewpassworddialog.h (line 183)

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88556 --- without actualy knowing the code in question, a brief look

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 6:03 a.m., Vishesh Handa wrote: > > I'm a little hesitant about this, but ship it. > > > > A couple of things though - > > 1. Dolphin should probably not be sending Baloo so many requests if Baloo > > is disabled. Perhaps we should fix this in Dolphin. > > 2. This patch is

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it **doesn't** cause a crash with

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 10:35 a.m., Sune Vuorela wrote: > > without actualy knowing the code in question, a brief look over gives me > > the impression that the error handling could be improved and that would > > make this patch not needed. The assumption here is that if (rc != 0) in normal

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 18, 2015, 8:06 nachm., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it **doesn't** cause a crash

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/ --- (Updated Nov. 19, 2015, 7:11 a.m.) Status -- This change has been

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

On Wednesday, November 18, 2015 5:28:27 PM CET René J.V. Bertin wrote: > On Wednesday November 18 2015 15:01:59 Martin Gräßlin wrote: > > idiotic > > If we're starting to call names arguing indeed becomes pointless as the > apparent lack of actual reading my arguments already suggested. It leaves

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 18, 2015, 8:06 nachm., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it **doesn't** cause a crash