Re: Moving KWayland to frameworks

2015-12-09 Thread Martin Graesslin
On Thursday, November 5, 2015 11:10:49 AM CET Kevin Ottens wrote: > Hello, > > On Thursday 05 November 2015 10:50:06 Martin Graesslin wrote: > > There are two things which make the move to frameworks difficult and I > > don't see a solution to it at the moment: > > > > 1. We require C++11

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

2015-12-09 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/#review89271 --- cmake/KF5I18NMacros.cmake (lines 55 - 58)

[OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread René J . V . Bertin
Hi, Several classes exist that have the possibility to create widgets or windows from a Qt WId, and those are used (exclusively? mostly?) by certain helper agents like the kwalletd to display dialogs parented by a window from the application that sent the request that justified posting the

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 9, 2015, 11:27 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 9, 2015, 12:12 p.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
> On Dec. 9, 2015, 12:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > > > > > Naming them .zip on windows, won't make it a zip file, if you use tar > > j. I suggest

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread Martin Graesslin
On Wednesday, December 9, 2015 1:29:41 PM CET René J.V. Bertin wrote: > KWindowSystem::setMainWindow() is a different matter. Firstly, it does NOT > use the plugin architecture currently, but simply assumes that > QWindow::fromWinId() will always work (and never crash). oh that explains a lot...

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread Kai Uwe Broulik
‎> On OS X (and MS Windows?),  And Wayland, so it affects Linux, too. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89275 --- kde-modules/KDETemplateGenerator.cmake (line 59)

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Aleix Pol Gonzalez
> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > > > > > Naming them .zip on windows, won't make it a zip file, if you use tar > > j. I suggest just

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread René J . V . Bertin
On Wednesday December 09 2015 13:51:47 Martin Graesslin wrote: > > KWindowSystem::setMainWindow() is a different matter. Firstly, it does NOT > > use the plugin architecture currently, but simply assumes that > > QWindow::fromWinId() will always work (and never crash). > > oh that explains a

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-09 Thread Mark Gaiser
On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote: > On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: > > I thought the frameworkintegration plugin was exactly that and usable for > > any platform if they wish to use it. > > Or is my assumption wrong and is

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-09 Thread Aleix Pol
On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote: > On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote: >> >> On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: >> > I thought the frameworkintegration plugin was exactly that and usable >> >

Re: Moving KWayland to frameworks

2015-12-09 Thread Kevin Ottens
Hello, On Wednesday 09 December 2015 10:07:50 Martin Graesslin wrote: > On Thursday, November 5, 2015 11:10:49 AM CET Kevin Ottens wrote: > > Hello, > > > > On Thursday 05 November 2015 10:50:06 Martin Graesslin wrote: > > > There are two things which make the move to frameworks difficult and I

Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2015-12-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

2015-12-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/ --- Review request for KDE Frameworks, David Faure and Emmanuel Pescosta.

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread René J . V . Bertin
Kai Uwe Broulik wrote: > ‎> On OS X (and MS Windows?), > > And Wayland, so it affects Linux, too. Yes, I learned that while composing my message (cf. the subject). FWIW, I just provided an initial/WIP implementation of a KWindowSystem plugin for OS X: https://git.reviewboard.kde.org/r/126291/

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 22 - Failure!

2015-12-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Dec 2015 23:31:32 + Build duration: 33 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 23 - Failure!

2015-12-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Dec 2015 23:31:32 + Build duration: 1 min 4 sec CHANGE SET Revision

Re: Review Request 124147: Create Data Dir If it Does Not Exist

2015-12-09 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/ --- (Updated Dec. 10, 2015, 6:55 a.m.) Status -- This change has been

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-09 Thread Martin Graesslin
On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote: > On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote: > > On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote: > >> On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: > >> > I

Re: Moving KWayland to frameworks

2015-12-09 Thread Martin Graesslin
On Wednesday, December 9, 2015 6:14:47 PM CET Kevin Ottens wrote: > > I just started looking into doing the replacement and noticed that I'm > > also > > using: > > * Non-static data member initializers (N2756), gcc 4.7 > > * Range-based for (N2930), gcc 4.6 > > Note that if you do that with Qt

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2015-12-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Dec 2015 06:56:02 + Build duration: 5 min 9 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2015-12-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Dec 2015 06:56:02 + Build duration: 5 min 9 sec CHANGE SET Revision

Re: Moving KWayland to frameworks

2015-12-09 Thread Boudhayan Gupta
On 10 December 2015 at 12:32, Martin Graesslin wrote: > yes, that's the annoying one which is lots of work and lots of possible > regressions. I'm not sure whether I'm willing to do that work which I consider > a useless exercise. In my opinion this discussion is an useless

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-09 Thread Aleix Pol Gonzalez
> On April 7, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > > > > > This is not correct, it's too early to figure out if it's going to have > > a QApplication or

Re: Purpose as a KDE Framework

2015-12-09 Thread Aleix Pol
On Tue, Dec 8, 2015 at 8:07 PM, Alex Merry wrote: > On 2015-12-03 18:29, Aleix Pol wrote: >> >> On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: >>> >>> I'm trying to understand what Purpose is doing exactly. >>> I've read the readme file, but i still

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-09 Thread Aleix Pol Gonzalez
> On Dec. 8, 2015, 9 a.m., David Faure wrote: > > I don't understand why the move to Q_COREAPP_STARTUP_FUNCTION. That startup > > function is only about creating some singleton, not about registering a > > KJob (which is where the qApp type check happens). > > > > If the startup function