Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90395 --- src/platforms/xcb/kwindowsystem.cpp (line 59)

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Friday January 01 2016 20:24:59 Christoph Cullmann wrote: >I think the Qt support is already ok enough, the application just needs to >handle it. >That should just be a few lines of code, not sure if any more wrapping will >make this less work. You're probably right. Would be nice though if

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 1, 2016, 7:47 p.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 891 > > > > > > isn't that "return displayGeometry()?" > > > > If not, then at least something like

Re: Review Request 126587: Add option to build with gcov support

> On Jan. 2, 2016, 1:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? I don't know... I based this on KWin https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249 - Dāvis --- This is an

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/ --- (Updated Jan. 2, 2016, 1:55 a.m.) Review request for KDE Frameworks.

Re: Review Request 126453: Fix library order

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/ --- (Updated Jan. 1, 2016, 11 p.m.) Status -- This change has been

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/ --- (Updated Jan. 2, 2016, 1:32 vorm.) Review request for KDE Frameworks and

Re: Review Request 126587: Add option to build with gcov support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90426 --- Well, then it's implemented by `ECMCoverageOption.cmake` in

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 189 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/189/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 19:46:11 + Build duration: 4 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 189 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/189/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 19:46:11 + Build duration: 4 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 197 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 19:46:11 + Build duration: 14 min CHANGE SET Revision 4af8a6b3c49a02f42f4d48b92fc47f6742cebdbc by

Re: Review Request 126587: Add option to build with gcov support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- That's provided by ecm, isn't it? - Aleix Pol Gonzalez On

Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/ --- Review request for KDE Frameworks and Vishesh Handa. Repository:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 197 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 19:46:11 + Build duration: 14 min CHANGE SET Revision 4af8a6b3c49a02f42f4d48b92fc47f6742cebdbc by

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Friday January 01 2016 20:24:59 Christoph Cullmann wrote: Hi, > Guess I should add the handling to Kate/KWrite ;=) I just made a quick attempt, not very successful. From what I understand, you either have to subclass QApplication in order to provide a dedicated ::event() method, or maybe

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126309/#review90392 --- This is kdelibs4support, this code is doomed to disappear and

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/#review90393 --- Ship it! Ship It! - David Faure On Dec. 11, 2015, 2:08

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 188 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/188/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 14:53:04 + Build duration: 5 min 9 sec CHANGE SET Revision

Re: Review Request 126149: [Icon widget] Bring back properties dialog

> On Dec. 29, 2015, 6:07 p.m., Kai Uwe Broulik wrote: > > I completely screwed up my Kate desktop files :( Would it help if I set > > NoDisplay or Hidden on the desktop file copy so it's there for the icon > > widget but not shown in the Open With dialogs and so on? Or, if I copied > > the

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 196 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/196/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 14:53:04 + Build duration: 13 min CHANGE SET Revision d5298d70cd16ea21987ab05ce7ecf2ccec069780 by

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

> On Jan. 1, 2016, 5:15 p.m., David Faure wrote: > > src/urifilters/shorturi/kshorturifilter.cpp, line 58 > > > > > > "despite" sounds like the api docs say that it's not thread safe. > > AFAICS the docs don't

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Jan. 1, 2016, 6:12 p.m., Alex Richardson wrote: > > I added support for translating the ExtraNames key here: > > https://svn.reviewboard.kde.org/r/7154/ Cool ;=) Which nice new year present! Thanks! - Christoph --- This is an

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > >

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, > On Friday January 01 2016 17:47:17 Christoph Cullmann wrote: > > Hi, > > Apparently you already looked into this? > >> I can tell you that this needs to be done at the application level, not at >> kpart >> level. > > Can you explain why? Does that mean it won't be possible to

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review90416 --- Would be cool if we could have something like this for

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 19:34:06 + Build duration: 4 min 6 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Jan 2016 19:34:06 + Build duration: 4 min 6 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 126385: PartManager: stop tracking a widget even if it is no longer a top level window

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126385/#review90394 --- Ship it! I agree -- except about the "aside" in the commit

new year's resolution: opening files "the Mac way" (TM)

Hi, Best wishes for 2016! As hinted in the subject, I've dusted off a resolution from last year: finding a way to support opening files "the Mac way". Some of you probably know that OS X doesn't hand off the documents to be opened in the standard argc,argv way when an application is started

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/#review90400 --- Ship it! Ship It! - David Faure On Dec. 24, 2015, 5:55

Re: Review Request 126453: Fix library order

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/#review90402 --- Ship it! Hmm, OK. It's really not obvious that order matters

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review90403 --- Ship it! src/urifilters/shorturi/kshorturifilter.cpp (line

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/#review90406 --- src/kdeui/k4style.cpp (line 1213)

Re: Splitting KActivities, 2nd attempt...

On Friday 01 January 2016 18:07:59 Ivan Čukić wrote: > > So, applications that do link to activities will run and work > uninterrupted even if the service is not present. OK, sounds good to me. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

> On Jan. 1, 2016, 4:04 p.m., David Faure wrote: > > This is kdelibs4support, this code is doomed to disappear and apps are > > using kDebug less and less. Is it worth risking compilation breakages on > > some systems? > > > > Also I found kBacktrace less and less useful over the years

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, > Hi, > > Best wishes for 2016! > > As hinted in the subject, I've dusted off a resolution from last year: > finding a > way to support opening files "the Mac way". > Some of you probably know that OS X doesn't hand off the documents to be > opened > in the standard argc,argv way when an

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

> On Jan. 1, 2016, 3:04 p.m., David Faure wrote: > > This is kdelibs4support, this code is doomed to disappear and apps are > > using kDebug less and less. Is it worth risking compilation breakages on > > some systems? > > > > Also I found kBacktrace less and less useful over the years

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/#review90401 --- Ship it! Ship It! - David Faure On Dec. 23, 2015, 7:50

Re: Splitting KActivities, 2nd attempt...

> Shouldn't the service be part of the framework? > How usable is the framework without the service? > Compiling is good, but running is even better :-) This is the reason why the split has not happened before. The purpose of the library is: [1] - to report document/resource events to the

Re: KHolidays as Framework (redux)

On Thursday 24 December 2015 12:28:13 John Layt wrote: > Hi, > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > for inclusion as a Framework. As far as I am aware there are no outstanding > porting issues with KHolidays and it is ready for review to be included as > a

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

> On Jan. 1, 2016, 4:04 p.m., David Faure wrote: > > This is kdelibs4support, this code is doomed to disappear and apps are > > using kDebug less and less. Is it worth risking compilation breakages on > > some systems? > > > > Also I found kBacktrace less and less useful over the years

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Friday January 01 2016 17:47:17 Christoph Cullmann wrote: Hi, Apparently you already looked into this? > I can tell you that this needs to be done at the application level, not at > kpart level. Can you explain why? Does that mean it won't be possible to encapsulate the functionality in a

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review90411 --- I added support for translating the ExtraNames key here: