Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126620/ --- (Updated Sty 4, 2016, 9:38 po południu) Review request for KDE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 217 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/217/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 04 Jan 2016 18:44:47 + Build duration: 11 sec CHANGE SET No changes

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126587: Add option to build with gcov support

> On Jan. 2, 2016, 3:57 a.m., Aleix Pol Gonzalez wrote: > > Well, then it's implemented by `ECMCoverageOption.cmake` in ECM, and > > included by `KDECompilerSettings.cmake`. If anything, the proper fix would > > be to remove this kind of code from elsewhere. Indeed. - Dāvis

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- (Updated Jan. 4, 2016, 8:04 p.m.) Status -- This change has been

Re: Review Request 126587: Add option to build with gcov support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/ --- (Updated Jan. 4, 2016, 10:21 p.m.) Status -- This change has been

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126505: Do not show a warning color before the user even started typing

> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's because I have kwidgetsaddons 5.17 globally installed from archlinux repos (indeed, the warning color in my local tests is set as soon as something is

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126620/#review90525 --- Ship it! Yes, C++11 style connect is fine in KF5. However

Re: Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/#review90530 --- Ship it! Ship It! - Marco Martin On Dec. 31, 2015, 6:47

QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

On Sunday 03 January 2016 11:11:48 René J.V. Bertin wrote: > On Sunday January 03 2016 10:22:27 David Faure wrote: > > >> You saw I said "wait for QProcess to be improved", right? I don't expect a > >> patch for QProcess to be incorporated before 5.7.x ... > > > >Patience is a virtue :-) > > Oh

Re: Review Request 126403: Get rid of QApplication dependency

> On gen. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? I have not, I thought you had made it clear in the past you thought it was a bad idea since it was all supposed to be widget based anyway. - Albert

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

> On June 23, 2014, 8:08 p.m., Thomas Lübking wrote: > > What about (non override) utility windows (eg. assume Qt would not set > > floating dock override to bring its own titlebar)? > > While kwin (iirc by default) hides them for inactive windows, that's rather > > a feature. > > > > -> By

Re: Review Request 126505: Do not show a warning color before the user even started typing

> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos > (indeed, the warning color in my local

Re: Review Request 126505: Do not show a warning color before the user even started typing

> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos > (indeed, the warning color in my local

Re: Review Request 126505: Do not show a warning color before the user even started typing

> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos > (indeed, the warning color in my local

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/#review90549 --- qt5/style/qtcurve_api.cpp (line 80)

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/#review90551 --- Ship it! LGTM other than the white space issue. Sorry for

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/#review90548 --- qt5/style/CMakeLists.txt (line 70)

Re: Review Request 126494: Add cross compile support for desktoptojson.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/ --- (Updated Jan. 4, 2016, 2:11 p.m.) Status -- This change has been

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 2:36 p.m., Sebastian Kügler wrote: > > Nice. > > > > I agree with Aleix that the env var would be good to have documented. (Is > > that even English?) But then, where? > > Martin Gräßlin wrote: > as an idea check: https://community.kde.org/KWin/Environment_Variables

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` If I remember correctly I took it

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121672/ --- (Updated Jan. 4, 2016, 2:14 p.m.) Status -- This change has been

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/ --- (Updated Jan. 4, 2016, 1:54 nachm.) Review request for KDE Frameworks

Re: Review Request 126494: Add cross compile support for desktoptojson.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/#review90546 --- Ship it! I can't see anything obviously wrong with it. (But

Re: Review Request 126494: Add cross compile support for desktoptojson.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/#review90552 --- KF5CoreAddonsConfig.cmake.in (line 12)

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/ --- (Updated Jan. 4, 2016, 3:05 p.m.) Status -- This change has been

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 29, 2015, 11:56 p.m., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > Kai Uwe Broulik wrote: > I'm quite indifferent

Re: Review Request 126505: Do not show a warning color before the user even started typing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- (Updated Jan. 4, 2016, 2:46 p.m.) Status -- This change has been

Re: Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/ --- (Updated Jan. 4, 2016, 4:38 p.m.) Status -- This change has been

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/ --- (Updated Jan. 4, 2016, 4:04 p.m.) Status -- This change has been

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 215 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/215/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 04 Jan 2016 17:21:21 + Build duration: 10 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 216 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/216/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 04 Jan 2016 18:00:46 + Build duration: 9.9 sec CHANGE SET No changes

Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 04 Jan 2016 16:38:56 + Build duration: 10 sec CHANGE SET No changes

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Jan. 4, 2016, 6:20 p.m.) Status -- This change has been