Re: Raising Qt requirement to Qt 5.4

2016-03-25 Thread Ivan Čukić
>> Is this documented in some wiki so we don't have to rely on people's memories >> or someone digging up the corresponding email thread? > > Good point. Any suggestion on where to document this? +1 since my gmail-search-foo was not up to the task - we have so many threads regarding compiler and

Re: Raising Qt requirement to Qt 5.4

2016-03-25 Thread David Faure
On Thursday 24 March 2016 23:14:36 Albert Astals Cid wrote: > El diumenge, 20 de març de 2016, a les 10:12:14 CET, David Faure va escriure: > > On Friday 18 March 2016 20:16:05 Ivan Čukić wrote: > > > Hi all, > > > > > > IIRC, the last time we talked about this we decided (I'll try to find > > >

Re: Raising Qt requirement to Qt 5.4

2016-03-25 Thread Mark Gaiser
On Fri, Mar 25, 2016 at 9:37 AM, David Faure wrote: > On Thursday 24 March 2016 23:14:36 Albert Astals Cid wrote: > > El diumenge, 20 de març de 2016, a les 10:12:14 CET, David Faure va > escriure: > > > On Friday 18 March 2016 20:16:05 Ivan Čukić wrote: > > > > Hi all, > > > > >

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

2016-03-25 Thread Jarosław Staniek
> On March 24, 2016, 10:15 a.m., Jarosław Staniek wrote: > > My thoughts mostly related to non-Plasma, non-XDG run environments. > > > > KF5 is a great addition, in hierarchy often sitting aside of Qt, not a part > > of XDG-compliant desktop. As such we can't say too much about the > >

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-25 Thread Martin Gräßlin
> On March 24, 2016, 8:45 p.m., Dominik Haumann wrote: > > Given the feedback I got, I will submit tomorrow (Friday), independent on > > whether I have a ship-it or not. > > The patch is tested both on Windows and Linux, and imo correct (the changes > > are rather trivial now). > > > > If you

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93986 --- Ship it! Ship It! - Martin Gräßlin On March 20, 2016,

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-25 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review93976 --- Well, this hasn't been resolved for a while now. A final

Re: Review Request 127470: kcodecs: Fix crash on invalid data

2016-03-25 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127470/ --- (Updated March 25, 2016, 1:28 p.m.) Review request for KDE Frameworks.

Re: Raising Qt requirement to Qt 5.4

2016-03-25 Thread Scarlett Clark
CI versions has been raised as per this thread. thanks, Scarlett On Fri, Mar 25, 2016 at 1:54 AM, Ivan Čukić wrote: > >> Is this documented in some wiki so we don't have to rely on people's > memories > >> or someone digging up the corresponding email thread? > > > > Good

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-25 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/ --- (Updated March 25, 2016, 9:43 a.m.) Status -- This change has been

Re: Raising Qt requirement to Qt 5.4

2016-03-25 Thread David Faure
On Friday 25 March 2016 09:54:12 Ivan Čukić wrote: > >> Is this documented in some wiki so we don't have to rely on people's > >> memories > >> or someone digging up the corresponding email thread? > > > > Good point. Any suggestion on where to document this? > > +1 since my gmail-search-foo was

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

2016-03-25 Thread David Faure
> On March 24, 2016, 9:15 a.m., Jarosław Staniek wrote: > > My thoughts mostly related to non-Plasma, non-XDG run environments. > > > > KF5 is a great addition, in hierarchy often sitting aside of Qt, not a part > > of XDG-compliant desktop. As such we can't say too much about the > >

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review94004 --- The reviewboard upgrade must have messed up something, the

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

2016-03-25 Thread Matthew Dawson
> On March 24, 2016, 5:15 a.m., Jarosław Staniek wrote: > > My thoughts mostly related to non-Plasma, non-XDG run environments. > > > > KF5 is a great addition, in hierarchy often sitting aside of Qt, not a part > > of XDG-compliant desktop. As such we can't say too much about the > >

Re: Review Request 127486: Fix uninitialized int array in UnicodeGroupProber

2016-03-25 Thread Dominik Haumann
> On March 24, 2016, 11:29 p.m., Aleix Pol Gonzalez wrote: > > src/probers/UnicodeGroupProber.cpp, line 80 > > > > > > `(uint)` shouldn't be necessary, no? Otherwise: > > `const uint