Re: Review Request 128083: Find CPUs by subsystem rather than driver

2016-06-07 Thread Martin Gräßlin
> On June 6, 2016, 11:33 p.m., Rohan Garg wrote: > > Hi > > Could we get a shipit on these? I'd really appreciate it if we could have > > these in Frameworks 5.23 I don't want to disappoint you, but it's too late for 5.23 - Martin ---

KApiDox Maintainship

2016-06-07 Thread Olivier Churlaud
Hi, I did a lot of work on KApiDox the last weeks, and I have still a lot in mind to improve it. I spoke with Alex about the maintainship of KApidox as he doesn't have currently time to spend on it. He told me he was ok to pass me the maintainship. I don't know how this work, so I would

Review Request 128115: do not load and debug in the same line

2016-06-07 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128115/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 83 - Fixed!

2016-06-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Jun 2016 09:07:10 + Build duration: 1 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

2016-06-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Jun 2016 09:07:10 + Build duration: 1 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 83 - Fixed!

2016-06-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Jun 2016 09:07:10 + Build duration: 1 min 20 sec CHANGE SET Revision

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-07 Thread Anthony Fieroni
> On Юни 7, 2016, 12:03 преди обяд, Elvis Angelaccio wrote: > > Are we talking about this bug? https://bugs.kde.org/show_bug.cgi?id=362977 > > > > If yes, it's already fixed on Ark master. > > Anthony Fieroni wrote: > It's not this, it happens on all backend. > > Elvis Angelaccio wrote: >

Re: Review Request 128114: do not load and debug in the same line

2016-06-07 Thread Harald Sitter
> On June 7, 2016, 8:53 a.m., Aleix Pol Gonzalez wrote: > > Are you sure that's the case? Is C++ that smart that it can decide not to > > execute part of the stream? C++ isn't, Qt is. In some build configs (e.g. gcc) qCDebug becomes noop as the macro essentially expands to a fancy

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-07 Thread Elvis Angelaccio
> On June 6, 2016, 9:03 p.m., Elvis Angelaccio wrote: > > Are we talking about this bug? https://bugs.kde.org/show_bug.cgi?id=362977 > > > > If yes, it's already fixed on Ark master. > > Anthony Fieroni wrote: > It's not this, it happens on all backend. It happens with all CLI-based

Review Request 128114: do not load and debug in the same line

2016-06-07 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128114/ --- Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy

Re: Review Request 128114: do not load and debug in the same line

2016-06-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128114/#review96247 --- Are you sure that's the case? Is C++ that smart that it can

Re: Review Request 128114: do not load and debug in the same line

2016-06-07 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128114/#review96246 --- Ship it! Thanks, just wanted to start looking into this

Re: Review Request 128114: do not load and debug in the same line

2016-06-07 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128114/ --- (Updated June 7, 2016, 9:06 a.m.) Status -- This change has been

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-07 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/ --- (Updated Юни 7, 2016, 10:24 след обяд) Review request for KDE Frameworks

Re: Review Request 128085: Fix check that CPU is a valid CPU

2016-06-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128085/#review96263 --- Ship it! - Sebastian Kügler On June 3, 2016, 12:15

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-07 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/ --- (Updated Юни 8, 2016, 7:17 преди обяд) Review request for KDE Frameworks

Re: Bug in kdelibs4support/kio/kfiledialog

2016-06-07 Thread Christoph Feck
On Wednesday 08 June 2016 00:58:33 Jonathan Schultz wrote: > Sorry for cross-posting, but kde-frameworks-devel seems to be a > more active list than kde-devel where I previously raised this > issue. > > I'd like to file a bug report for kdelibs4support/kio/kfiledialog > but don't seem to be able

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

2016-06-07 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127906/ --- (Updated Juni 8, 2016, 4:57 vorm.) Review request for Documentation, KDE

Re: Review Request 127903: Update kf5options manpage docbook

2016-06-07 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127903/ --- (Updated Juni 8, 2016, 4:42 vorm.) Review request for Documentation and

Re: Review Request 127940: Rename docs/plasmapkg directory to docs/plasmapkg2

2016-06-07 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127940/#review96277 --- Ship it! If https://git.reviewboard.kde.org/r/127904/

Re: Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

2016-06-07 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127927/#review96276 --- Ship it! Too late for 5.23, but I think you can push

Re: Review Request 127903: Update kf5options manpage docbook

2016-06-07 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127903/#review96267 --- Generic options for Qt5 (so qt5options) do work for every

Re: Review Request 128088: Load KFileItemAction plugins with json metadata

2016-06-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128088/#review96284 --- Ship it! Ship It! - Emmanuel Pescosta On June 5, 2016,

Bug in kdelibs4support/kio/kfiledialog

2016-06-07 Thread Jonathan Schultz
Sorry for cross-posting, but kde-frameworks-devel seems to be a more active list than kde-devel where I previously raised this issue. I'd like to file a bug report for kdelibs4support/kio/kfiledialog but don't seem to be able to find a relevant category in KDE Bugzilla. If someone can point

Re: Review Request 128116: KStandardAction::showStatusbar: fix copy/paste error

2016-06-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128116/#review96256 --- Ship it! Ship It! - Albert Astals Cid On June 7, 2016,

Re: Review Request 128083: Find CPUs by subsystem rather than driver

2016-06-07 Thread Rohan Garg
> On June 7, 2016, 3:03 a.m., Rohan Garg wrote: > > Hi > > Could we get a shipit on these? I'd really appreciate it if we could have > > these in Frameworks 5.23 > > Martin Gräßlin wrote: > I don't want to disappoint you, but it's too late for 5.23 > > Kai Uwe Broulik wrote: > If you

Re: Review Request 128116: KStandardAction::showStatusbar: fix copy/paste error

2016-06-07 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128116/ --- (Updated June 7, 2016, 2:45 p.m.) Status -- This change has been

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 53 - Still Unstable!

2016-06-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Jun 2016 12:46:45 + Build duration: 6 min 10 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-06-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/ --- (Updated June 7, 2016, 1:23 p.m.) Status -- This change has been

Review Request 128119: Explicitly declare methods as overridden

2016-06-07 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128119/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: Review Request 128119: Explicitly declare methods as overridden

2016-06-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128119/#review96259 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 7,

Review Request 128120: Use KRun for open Url.

2016-06-07 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128120/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: Review Request 128121: Use scoped pointer for complicated delete logic

2016-06-07 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128121/ --- (Updated June 7, 2016, 4:30 p.m.) Status -- This change has been

Re: Review Request 128119: Explicitly declare methods as overridden

2016-06-07 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128119/ --- (Updated June 7, 2016, 5:10 p.m.) Status -- This change has been

Re: KApiDox Maintainship

2016-06-07 Thread Aleix Pol
On Tue, Jun 7, 2016 at 7:28 AM, Olivier Churlaud wrote: > Hi, > > I did a lot of work on KApiDox the last weeks, and I have still a lot in > mind to improve it. I spoke with Alex about the maintainship of KApidox as > he doesn't have currently time to spend on it. He told

Review Request 128121: Use scoped pointer for complicated delete logic

2016-06-07 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128121/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: Review Request 128121: Use scoped pointer for complicated delete logic

2016-06-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128121/#review96261 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 7,