Re: Review Request 128917: Make sure we don't add the appstream test twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128917/ --- (Updated Sept. 15, 2016, 12:46 p.m.) Status -- This change has been

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 15, 2016, 1:20 p.m.) Review request for KDE Frameworks

Re: Review Request 128917: Make sure we don't add the appstream test twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128917/#review99213 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 15,

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

> On Sept. 15, 2016, 3:01 p.m., Gleb Popov wrote: > > autotests/kconfigtest.cpp, line 1378 > > > > > > I'd put both `cgLocal.writeEntry("someLocalString", "whatever2");` and > > `QVERIFY(!cgLocal.sync());`

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99215 --- autotests/kconfigtest.cpp (line 1373)

Jenkins-kde-ci: oxygen Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 14:37:03 + Build duration: 4 min 3 sec CHANGE SET No changes JUNIT RESULTS

Review Request 128922: Remove invalid directory from index.theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128922/ --- Review request for KDE Frameworks and Andreas Kainz. Repository:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 113 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 15:07:21 + Build duration: 3 min 35 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 115 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/115/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 15:22:36 + Build duration: 2 min 40 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 262 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:39:40 + Build duration: 3 min 30 sec CHANGE SET Revision

Re: Review Request 128913: add a test to prevent file names from having newlines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/#review99187 --- I was surprised that we allow filenames with newlines in the

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

> On Sept. 15, 2016, 4:41 p.m., Kai Uwe Broulik wrote: > > tests/kmessageboxtest.cpp, line 232 > > > > > > QString QString::repeated(int times) const > > > > Returns a copy of this string repeated the

Re: Review Request 126086: [OS X] backend ported from KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Sept. 15, 2016, 6:41 p.m.) Review request for KDE Software on

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 217 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/217/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 16:49:33 + Build duration: 18 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 217 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/217/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 16:49:33 + Build duration: 18 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Scrap baloo?

Hi, LMDB maintainer says about that: This is pretty special-purpose and only intended for embedded builds, not for distro-wide use. => no good idea. If we want to use that, we need to bundle lmdb and link it into the baloo lib. Greetings Christoph - Am 15. Sep 2016 um 9:41 schrieb Luca

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 326 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/326/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 17:39:43 + Build duration: 21 min CHANGE SET No changes JUNIT RESULTS

Re: Scrap baloo?

Hi, > Il giorno Wed, 14 Sep 2016 23:29:22 +0200 (CEST) > Christoph Cullmann ha scritto: > > >> CC'd Vishesh, perhaps I am wrong with that issues and misunderstand >> the code, unfortunately e.g. the database structure is not that well >> documented, if I don't just not

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review99183 --- Can they be made co-installable with the ones with

Re: Scrap baloo?

Il giorno Wed, 14 Sep 2016 23:29:22 +0200 (CEST) Christoph Cullmann ha scritto: > CC'd Vishesh, perhaps I am wrong with that issues and misunderstand > the code, unfortunately e.g. the database structure is not that well > documented, if I don't just not find the correct

Re: Scrap baloo?

Hi, > Il giorno Thu, 15 Sep 2016 06:46:57 +0200 (CEST) > Christoph Cullmann ha scritto: > >> FYI >> Compile LMDB with -DMDB_VL32 to allow using larger-than-32bit DBs on >> 32bit systems. > > With my distro hat on, I wonder if this would change the on-disk format > for

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 260 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/260/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:19:57 + Build duration: 8 min 11 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 262 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:19:51 + Build duration: 8 min 1 sec CHANGE SET Revision

Re: Review Request 128913: add a test to prevent file names from having newlines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/#review99184 --- Ship it! Ship It! - Martin Gräßlin On Sept. 15, 2016,

Review Request 128913: add a test to prevent file names from having newlines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/ --- Review request for KDE Frameworks. Repository: breeze-icons

Re: Review Request 128913: add a test to prevent file names from having newlines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/ --- (Updated Sept. 15, 2016, 8:17 a.m.) Status -- This change has been

Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 128913: add a test to prevent file names from having newlines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/ --- (Updated Sept. 15, 2016, 8:10 a.m.) Review request for KDE Frameworks.

Re: Scrap baloo?

Hi, On 16 September 2016 at 01:04, Christoph Cullmann wrote: >>> => Opinions? >> >> It would be nice to hear what Vishesh, Pinak and Boudhayan think about >> this. I prefer getting familiar with the code as well as having a mile-high view of what does what before I start

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 15, 2016, 8:49 p.m.) Review request for KDE Frameworks

Re: Review Request 128913: add a test to prevent file names from having newlines

> On Sept. 15, 2016, 8:55 a.m., Elvis Angelaccio wrote: > > I was surprised that we allow filenames with newlines in the first place. > > Shouldn't we use a server-side hook that prevents commits with broken > > filenames? Or this is only a problem with icons? It may well be that we should

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote: > > Can they be made co-installable with the ones with kde-runtime, as both > > modules can be available at the same time? This is the problem of the > > missing support for kcontrol5 > > > > It was already done some time ago and I had to

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99210 --- autotests/kconfigtest.cpp

Re: Review Request 128917: Make sure we don't add the appstream test twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128917/#review99212 --- Tested here, and it indeed fixed the issue. - Mauro

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 263 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/263/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:29:03 + Build duration: 5 min 36 sec CHANGE SET Revision

Review Request 128917: Make sure we don't add the appstream test twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128917/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 262 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:39:40 + Build duration: 3 min 30 sec CHANGE SET Revision

Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- Review request for KDE Frameworks and Gleb Popov. Repository: kconfig

Re: Review Request 128917: Make sure we don't add the appstream test twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128917/#review99211 --- kde-modules/KDECMakeSettings.cmake (line 148)

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review99205 --- doc/kcontrol/cache/index.docbook (line 19)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 264 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/264/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:35:03 + Build duration: 5 min 49 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 264 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/264/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:35:03 + Build duration: 5 min 49 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 261 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/261/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Sep 2016 08:29:20 + Build duration: 6 min 41 sec CHANGE SET Revision

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128768/ --- (Updated Sept. 15, 2016, 10:52 a.m.) Review request for KDE Frameworks

Re: Review Request 128917: Make sure we don't add the appstream test twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128917/ --- (Updated Sept. 15, 2016, 5:50 p.m.) Review request for KDE Frameworks