Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 nachm., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another

Review Request 129028: introduce dupe test from breeze-icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129028/ --- Review request for KDE Frameworks. Repository: oxygen-icons5

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 297 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/297/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Sep 2016 15:19:32 + Build duration: 3 min 26 sec CHANGE SET Revision

[Differential] [Updated, 603 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

kossebau updated this revision to Diff 6927. kossebau added a comment. Fix generated inter-qch links, add support for unversioned namespace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6917=6927 BRANCH addGenerateApiDox REVISION DETAIL

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

kossebau updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/ --- (Updated Sept. 26, 2016, 7:55 p.m.) Review request for KDE Frameworks.

Re: Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129032/#review99552 --- +1 makes sense - Aleix Pol Gonzalez On Sept. 26, 2016,

Re: Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129032/ --- (Updated Sept. 26, 2016, 11:41 p.m.) Review request for KDE Frameworks

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/ --- (Updated Sept. 26, 2016, 7:58 p.m.) Review request for KDE Frameworks.

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/#review99551 --- Ship it! One less reason for Dolphin to have its own

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

> On Sept. 26, 2016, 9:53 a.m., Elvis Angelaccio wrote: > > src/widgets/kfileitemactions.cpp, line 493 > > > > > > There should be a `addedPlugins.append(jsonMetadata.pluginId());` after > > this line. For

Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 299 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/299/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Sep 2016 15:19:32 + Build duration: 2 min 15 sec CHANGE SET Revision

Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129020/ --- Review request for KDE Frameworks. Repository: breeze-icons

Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/ --- Review request for KDE Frameworks. Repository: breeze-icons

Re: Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129020/#review99522 --- Ship it! Ship It! - Kevin Funk On Sept. 26, 2016, 9:45

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/#review99526 --- autotests/dupetest.cpp (line 36)

Re: Review Request 128970: Add cross compile support for meinproc5.

> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote: > > src/CMakeLists.txt, line 60 > > > > > > So, I inherited kdoctools with this code commented - do you have an > > idea why it was like this, and why your

Re: Review Request 128970: Add cross compile support for meinproc5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128970/#review99532 --- Ship it! Ship It! - Luigi Toscano On Sept. 21, 2016,

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/#review99535 --- Ship it! Let's get this in for now, so we can actually

Re: Review Request 128970: Add cross compile support for meinproc5.

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote: > > src/CMakeLists.txt, line 60 > > > > > > So, I inherited kdoctools with this code commented - do you have an > > idea why it was like this, and why your

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

> On Sept. 24, 2016, 12:40 p.m., Elvis Angelaccio wrote: > > src/api/KWallet/kwallet.cpp, line 366 > > > > > > You should probably use isEnabled() instead, in case someone is using > > ksecretservice (though

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

> On Sept. 26, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > autotests/dupetest.cpp, line 66 > > > > > > It should mark an error if dupes found, no? > > Harald Sitter wrote: > Doesn't QFAIL unwind the

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/#review99527 --- src/widgets/kfileitemactions.cpp (line 487)

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

> On Sept. 26, 2016, 11:40 a.m., Aleix Pol Gonzalez wrote: > > autotests/dupetest.cpp, line 66 > > > > > > It should mark an error if dupes found, no? Doesn't QFAIL unwind the stack? - Harald

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/ --- (Updated Sept. 26, 2016, 12:23 p.m.) Review request for KDE Frameworks.

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/ --- (Updated Sept. 26, 2016, 12:30 p.m.) Review request for KDE Frameworks.

Re: Review Request 128970: Add cross compile support for meinproc5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128970/ --- (Updated Sept. 26, 2016, 1:45 p.m.) Status -- This change has been

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/ --- (Updated Sept. 26, 2016, 3:56 p.m.) Status -- This change has been

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128969/ --- (Updated Sept. 26, 2016, 4:16 nachm.) Review request for Documentation,

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote: > > src/CMakeLists.txt, line 173 > > > > > > docbookl10nhelper is not meant to be installed > > Ralf Habacker wrote: > To cross compile kdoctools for

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

> On Sept. 21, 2016, 1:52 p.m., Luigi Toscano wrote: > > src/CMakeLists.txt, line 173 > > > > > > docbookl10nhelper is not meant to be installed > > Ralf Habacker wrote: > To cross compile kdoctools for

Re: Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129020/ --- (Updated Sept. 26, 2016, 11:49 a.m.) Status -- This change has been

[Differential] [Updated, 609 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

kossebau updated this revision to Diff 6941. kossebau added a comment. Fixing value of exported ${name}_APIDOX_TAGSFILE & tiny improvements CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6927=6941 BRANCH addGenerateApiDox REVISION DETAIL

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 nachm., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another

Re: Review Request 128852: In listview mode use the default implemention of moveCursor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128852/ --- (Updated Sept. 27, 2016, 12:14 a.m.) Status -- This change has been

Review Request 129002: Use QCDebug in KIdleTime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129002/ --- Review request for KDE Frameworks. Repository: kidletime Description

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/ --- (Updated Sept. 27, 2016, 12:26 a.m.) Status -- This change has been

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another

Review Request 129024: fail the entire dupe test if fdupes is not present

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129024/ --- Review request for KDE Frameworks. Repository: breeze-icons

Re: Review Request 129024: fail the entire dupe test if fdupes is not present

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129024/#review99538 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 26,

Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 129024: fail the entire dupe test if fdupes is not present

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129024/ --- (Updated Sept. 26, 2016, 2:24 p.m.) Status -- This change has been

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/#review99539 --- Again, I'll refer to how it's done in KCoreAddons. I don't

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. Is this last sentence part of another conversation that I missed? -

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 296 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/296/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Sep 2016 14:30:40 + Build duration: 3 min 34 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 298 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/298/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Sep 2016 14:30:40 + Build duration: 3 min 46 sec CHANGE SET Revision

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

> On Sept. 26, 2016, 4:25 nachm., Aleix Pol Gonzalez wrote: > > Again, I'll refer to how it's done in KCoreAddons. I don't think it's > > really useful to need to define variables for every framework you are > > compiling. > > Luigi Toscano wrote: > Is this last sentence part of another