davidedmundson created this revision.
davidedmundson added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4084
davidedmundson added a comment.
See https://phabricator.kde.org/D4084
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4082
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, dfaure, davidedmundson
Cc: apol,
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4084
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
phab/prse2servicetypes
REVISION DETAIL
https://phabricator.kde.org/D4082
EMAIL PREFERENCES
mart updated this revision to Diff 10054.
mart added a comment.
- add an autotest for a list item before the servicetypes definition
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4082?vs=10045=10054
BRANCH
phab/prse2servicetypes
REVISION DETAIL
mart updated this revision to Diff 10045.
mart marked an inline comment as done.
mart added a comment.
- don't load servicetypes a second time
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4082?vs=10044=10045
BRANCH
phab/prse2servicetypes
REVISION
davidedmundson added a comment.
+1
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4082
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, dfaure, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai,
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:2a9b56e93407: parse the desktop file 2 times (authored by
mart).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4082?vs=10054=10055
REVISION DETAIL
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/193/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 15:13:47 +
Build duration: 2 min 1 sec
CHANGE SET
No changes
JUNIT RESULTS
davidedmundson added a comment.
Also you can remove the lines
} else if (key == QByteArrayLiteral("X-KDE-ServiceTypes") || key ==
QByteArrayLiteral("ServiceTypes")) {
const auto services = deserializeList(value);
- for(const auto : services) {
- // some .desktop files
mart updated this revision to Diff 10044.
mart added a comment.
- don't close/reopen the file
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4082?vs=10039=10044
BRANCH
phab/prse2servicetypes
REVISION DETAIL
https://phabricator.kde.org/D4082
aacid accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D3811
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dvratil, mart, davidedmundson, aacid
Cc: #frameworks, #plasma
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 21:30:22 +
Build duration: 1 min 53 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 21:30:22 +
Build duration: 1 min 53 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
apol added a comment.
How about adding a test?
Other than that, the patch looks good.
It's horrible that we need to do so, but I guess it's the price of backwards
compatibility. There's the possibility of doing the processing in two steps
(desktop to pairs, pairs to json), but we
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/196/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 15:11:16 +
Build duration: 2 min 21 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D3811
EMAIL PREFERENCES
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0a7ae2ce97c4: [Icon Item] Round size we want to load a
pixmap in (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
kfunk added a comment.
Why did you remove all the early-returns? Was that the case before in one of
your earlier patches?
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D2075
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
marten created this revision.
marten added a reviewer: Frameworks.
marten set the repository for this revision to R244 KCoreAddons.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Differential https://phabricator.kde.org/D4072 requests a change to the bug
reporting system
marten added a dependency: D4072: Bug reporter: Allow a URL (not just as an
email address) for custom reporting.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4080
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten,
marten added a dependent revision: D4080: KAboutData: Document that bug email
address can also be a URL.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D4072
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten, #frameworks
Cc:
On Wednesday January 11 2017 06:08:39 Andy Shaw wrote:
Hi,
>I have been doing some patches lately (i.e. yesterday and the day before) to
>fix shortcuts (these have been reported on JIRA already too) on Cocoa so I
>don’t know if this is addressed already in Qt 5.8.x as a result. But it might
marten added a comment.
Yes, I'll submit a separate diff for that. Fortunately BC, since there are
no actual code changes needed - only the parameter name. The getter/setter
bugAddress/setBugAddress will suffice as they are (with apidoc changes).
REPOSITORY
R263 KXmlGui
REVISION DETAIL
dfaure added a comment.
The QFont::toString() I mentionned in my last comment were due to changes in
Qt 5.8, and I now fixed them.
https://codereview.qt-project.org/181645
All good now, sorry for the noise.
REPOSITORY
R237 KConfig
REVISION DETAIL
dvratil updated this revision to Diff 10022.
dvratil added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Fix loading of legacy plugins.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mart added reviewers: davidedmundson, dfaure.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4082
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, davidedmundson, dfaure
Cc: plasma-devel, #frameworks, lesliezhai,
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Search for the ServiceTypes key in the desktop file before
parsing it "for real", because
mart added inline comments.
INLINE COMMENTS
> desktopfileparser.cpp:237
>
> +bool tokenizeKeyValue(QFile , const QString , QByteArray ,
> QString , int )
> +{
maybe instead a bool it could have error codes to more easily assure the
behavior is 100% the same as before
REPOSITORY
R244
Hi,
Qt 5.8.0 is in essence taking on the role of 5.7.3 I believe and it should be
out in a week or so, but one of these patches will be in 5.8.1 and not 5.8.0 in
any case.
They can be applied to 5.7.x without any problem as this code has not really
changed much since Qt 5.7.0, the ones I am
I have been doing some patches lately (i.e. yesterday and the day before) to
fix shortcuts (these have been reported on JIRA already too) on Cocoa so I
don’t know if this is addressed already in Qt 5.8.x as a result. But it might
be worth keeping an eye on that to see if it is working there
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129807/
---
Review request for KDE Frameworks, kdewin and Christoph Feck.
jonathans added a comment.
I wrote the first patch to be as minimal as possible and to be consistent
with the previous coding style. I therefore left the early returns in place.
I wrote the latest patch based on my interpretation of your (@kfunk) feedback
that it makes more sense to
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 22:11:25 +
Build duration: 1 min 49 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 22:11:25 +
Build duration: 1 min 49 sec
CHANGE SET
No changes
JUNIT RESULTS
mpyne closed this revision.
mpyne added a comment.
This diff was pushed to kio, closing manually since I seem to have messed up
the commit msg. See
https://cgit.kde.org/kio.git/commit/?id=d06e40bc1e84391640fc56a4c5ba252eaa9dcc6d
REPOSITORY
R241 KIO
REVISION DETAIL
davidedmundson created this revision.
davidedmundson added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Though we can make the property constant, some applications still use
apol added a comment.
I don't get it. If it changes, why is it constant?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4092
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma,
mpyne accepted this revision.
mpyne added a reviewer: mpyne.
mpyne added a comment.
This revision is now accepted and ready to land.
LGTM, and things seem to work in my testing as well.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4080
EMAIL PREFERENCES
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Adds tests for using custom widgets with KConfigDialog
REPOSITORY
R265 KConfigWidgets
BRANCH
extendKConfigDialog_UnitTest
REVISION DETAIL
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129807/#review101945
---
Could you test it with an SVG file that contains text? From
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/194/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 Jan 2017 21:15:44 +
Build duration: 1 min 57 sec
CHANGE SET
No changes
JUNIT RESULTS
davidedmundson added a comment.
In https://phabricator.kde.org/D4092#76611, @apol wrote:
> I don't get it. If it changes, why is it constant?
The icon sizes change
These are exposed in a QQmlPropertyMap
The address of that QQmlPropertyMap is always the same
REPOSITORY
apol added a comment.
In https://phabricator.kde.org/D4092#76633, @davidedmundson wrote:
> In https://phabricator.kde.org/D4092#76611, @apol wrote:
>
> > I don't get it. If it changes, why is it constant?
>
>
> The icon sizes change
>
> These are exposed in a QQmlPropertyMap
44 matches
Mail list logo
