[Differential] [Commented On] D4234: Change algorithm for autobrace.

cactus added a comment. Hello, In the case of void foo(bar); the both solution has the same result. But when you have 2 levels of bracket the result are different. In the example of : if (isEndMatching()) or printf("Bonjour") With auto-brackets enabled and with the old

Re: Review Request 129955: fix off by one in the socket filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/#review102534 --- Ship it! Good catch! I was curious and look a bit about

[Differential] [Request, 25 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne created this revision. flherne added a reviewer: Frameworks. flherne set the repository for this revision to R265 KConfigWidgets. Restricted Application added a project: Frameworks. REVISION SUMMARY [RFC] KColorSchemeManager::activateScheme() sets a custom path for the

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 519 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/519/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Feb 2017 22:57:45 + Build duration: 14 min CHANGE SET Revision

Re: Review Request 129955: fix off by one in the socket filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/ --- (Updated Feb. 17, 2017, 1:50 a.m.) Status -- This change has been

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 519 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/519/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Feb 2017 22:57:45 + Build duration: 2 min 32 sec CHANGE SET Revision

Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

> On Feb. 5, 2017, 9:50 a.m., David Faure wrote: > > Can you also deprecate DrawFrame, then? > > Diego S. wrote: > How does stuff get deprecated in Frameworks? I don't have a lot of kde > development (or development in general) experience. I also don't have a > proper dev environment

[Differential] [Updated] D4628: Add ability to disable saving in `KTextEditor::Document`

anthonyfieroni added reviewers: KTextEditor, cullmann, dhaumann. REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, #frameworks

[Differential] [Commented On] D4628: Add ability to disable saving in `KTextEditor::Document`

anthonyfieroni added a comment. Add reviewers KTextEditor, try not add virtual functions to base class :) REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg Cc: kwrite-devel, #frameworks

[Differential] [Closed] D4607: finish support for opening compressed packages

This revision was automatically updated to reflect the committed changes. Closed by commit R290:083b229ac85d: finish support for opening compressed packages (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4607?vs=11400=11403 REVISION

[Differential] [Request, 31 lines] D4630: Only register APPLE_* options if(APPLE)

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Otherwise the cmake cache has noisy values. TEST PLAN Recreated a project, it's not listed

[Differential] [Updated, 28 lines] D4620: allow to add application actions on an open menu

mart updated this revision to Diff 11402. mart added a comment. - remove eventual pre existing plugin actions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4620?vs=11371=11402 BRANCH phab/setActionsLater REVISION DETAIL https://phabricator.kde.org/D4620

[Differential] [Accepted] D4576: [WIP]: integrate drop menu and filecopy drop menu

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4576 REVISION DETAIL https://phabricator.kde.org/D4576 EMAIL PREFERENCES

[Differential] [Requested Changes To] D4607: finish support for opening compressed packages

hein requested changes to this revision. hein added a reviewer: hein. This revision now requires changes to proceed. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D4607 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart,

[Differential] [Commented On] D4607: finish support for opening compressed packages

hein added inline comments. INLINE COMMENTS > package.cpp:362 > foreach (const QString , d->contentsPrefixPaths) { > -const QString prefix = fileType == "metadata" ? d->path : (d->path + > contentsPrefix); > +const QString prefix = !d->tempRoot.isEmpty() ? (fileType == >

Communication with Phabricator upstream

Hi all, To help simplify things for Phabricator upstream, they've asked that only a couple of people bring things to their attention (including filing tasks). This helps them with figuring out our priorities as a project in regards to usage of Phabricator. Please therefore file all issues / etc

[Differential] [Accepted] D4607: finish support for opening compressed packages

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH arcpatch-D4607 REVISION DETAIL https://phabricator.kde.org/D4607 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, hein Cc:

[Differential] [Updated, 29 lines] D4607: finish support for opening compressed packages

mart updated this revision to Diff 11400. mart added a comment. - readability++ REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4607?vs=11336=11400 BRANCH arcpatch-D4607 REVISION DETAIL https://phabricator.kde.org/D4607 AFFECTED FILES

[Differential] [Updated] D4633: WIP: Updated folder decrypted and encrypted icons

ivan retitled this revision from "Updated folder decrypted and encrypted icons" to "WIP: Updated folder decrypted and encrypted icons". ivan updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 EMAIL PREFERENCES

[Differential] [Updated, 152 lines] D4633: Updated folder decrypted and encrypted icons

ivan updated this revision to Diff 11410. ivan added a comment. - Small issue with line borders REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4633?vs=11409=11410 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4633 AFFECTED FILES

[Differential] [Updated] D4633: Updated folder decrypted and encrypted icons

ivan updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, alex-l, andreaska Cc: #frameworks

[Differential] [Request, 159 lines] D4633: Updated folder decrypted and encrypted icons

ivan created this revision. ivan added reviewers: alex-l, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The current icons have a nice idea, but the horizontally-cut checkers look a bit like a

[Differential] [Commented On] D4633: WIP: Updated folder decrypted and encrypted icons

ivan added a comment. Or a bit different: F2501511: icons-again.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4633 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan,

[Differential] [Updated] D4628: Add ability to disable saving in `KTextEditor::Document`

dhaumann added a comment. I think we don't need this patch: The solution is to disable the save and saveAs actions: Iterate over the document's KActionCollection to find the correct actions (see katepart5ui.rc), and then disable / remove them. This is also how KDevelop and Kate once did

[Differential] [Commented On] D4234: Change algorithm for autobrace.

dhaumann added a comment. In my opinion, the current solution is "ok", i.e., if I type: void foo(bar); with auto-brackets enabled, the current code is smart enough eat the ')' since it maintains the range. While defining new functions or calling methods, this works perfectly. The

Review Request 129955: fix off by one in the socket filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/ --- Review request for KDE Frameworks. Repository: kwallet-pam Description

[Differential] [Accepted] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

mpyne accepted this revision. mpyne added a comment. A satisfying evolution towards making this code nicer. :) REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added a comment. This is a sensible idea, though I wonder whether we should put it into something more concrete than a QProperty on the qApp. INLINE COMMENTS > kcolorscheme.h:33-37 > +KSharedConfigPtr defaultConfig() { > +// Read from the application's color scheme file (as