mgallien abandoned this revision.
mgallien added a comment.
I think this review is going nowhere. I prefer to cancel it instead of
spending my energy on it.
I will limit Elisa usage of Baloo to getting an initial list of files
hopefully faster than by looking at file system. All later
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
When setting an empty QStringList as prefix, it can lead to unexpected
results, such as the prefix not changing.
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
When setting an empty QStringList as prefix, it can lead to unexpected
results, such as the prefix not changing.
davidedmundson added a comment.
Wrote https://phabricator.kde.org/D5000 based on what you said in the other
phab, the advantage there is you don't change what prefixes() returns.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4999
To: broulik,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5000
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:547a34d34669: Handle applyPrefixes with an empty string
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mgallien added a comment.
In https://phabricator.kde.org/D4911#94076, @cullmann wrote:
> > I will limit Elisa usage of Baloo to getting an initial list of files
hopefully faster than by looking at file system.
>
> I would actually not even do that, as baloo isn't working that well
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102779
---
Fix it, then Ship it!
Looks good to me now.
broulik abandoned this revision.
broulik added a comment.
I like yours better
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4999
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai,
ali-mohamed,
cullmann added a comment.
> I will limit Elisa usage of Baloo to getting an initial list of files
hopefully faster than by looking at file system.
I would actually not even do that, as baloo isn't working that well e.g. on
NFS and co. and that will limit the use of your application
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/374/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 10 Mar 2017 09:55:51 +
Build duration: 5 min 36 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/374/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 10 Mar 2017 09:55:51 +
Build duration: 5 min 36 sec
CHANGE SET
Revision
cullmann added a comment.
> This is one way to get tracks in parallel with other ways to get tracks. If
Baloo is active I can only hope that the user as made actions to ensure that it
is not just crashing., If Baloo is not active, I should check that my
application still behave nominally.
leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.
Thinking this is... well under way, with a couple of details :)
INLINE COMMENTS
> kauthactionreply.h:338
> -*
> -* In case of errors coming from the library, the type() is
> -*
jriddell created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Update API docs
TEST PLAN
Read them
REPOSITORY
R283 KAuth
BRANCH
docs
REVISION DETAIL
https://phabricator.kde.org/D5003
jriddell updated this revision to Diff 12366.
jriddell added a comment.
- mention statusChanged
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5003?vs=12365=12366
BRANCH
docs
REVISION DETAIL
https://phabricator.kde.org/D5003
AFFECTED FILES
jriddell updated this revision to Diff 12365.
jriddell marked an inline comment as done.
jriddell added a comment.
- better description for kauthexecutejob data
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5003?vs=12359=12365
BRANCH
docs
REVISION
rjvbb closed this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4968
To: rjvbb, #frameworks, dfaure
Cc: bcooksley, dfaure, #frameworks
jriddell marked an inline comment as done.
jriddell added a comment.
added some info to kauthexecutejob.h about AuthStatus
data() does get the data returned by the action (not direct return I guess)
as well as set during the action, updated.
INLINE COMMENTS
> leinir wrote in
vpilo added a dependent revision: D5012: Delay notifications until desktop
session has loaded.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4799
To: vpilo
Cc: davidedmundson, dfaure, broulik, graesslin, mck182, #frameworks
vpilo updated this revision to Diff 12377.
vpilo marked an inline comment as done.
vpilo added reviewers: Plasma, Plasma: Workspaces.
vpilo added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
New patchset.
I moved the
jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.
yep works well in my example
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D5001
To: leinir, #frameworks, jriddell
Cc: jriddell
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/
---
(Updated March 10, 2017, 1:26 p.m.)
Review request for KDE Frameworks,
leinir created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This implements the standard method for stopping a KJob in KAuth::ExecuteJob.
It is done using a minimal-intrusion approach, and is supposed to feel familiar
to people already used to working
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/
---
(Updated March 11, 2017, 6:07 a.m.)
Status
--
This change has been
25 matches
Mail list logo
