D4847: KAuth integration in document saving

2017-03-21 Thread Martin Kostolný
martinkostolny added a comment. > it should work as it is now, or I am mistaken? I believe the latest diff update is indeed making use of atomic rename. I will roughly summarize what the code currently does: 1. First try to open QSaveFile, if succeeded -> finish writing as before

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-03-21 Thread René J . V . Bertin
rjvbb set the repository for this revision to R113 Oxygen Theme. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: ltoscano, kde-mac, #frameworks

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 475 - Fixed!

2017-03-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/475/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 08:39:38 + Build duration: 16 min CHANGE SET Revision 1ae47b73a35e65b2de9040f7da69166bd7a5b1ae by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 479 - Fixed!

2017-03-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/479/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 08:39:38 + Build duration: 16 min CHANGE SET Revision 1ae47b73a35e65b2de9040f7da69166bd7a5b1ae

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 475 - Fixed!

2017-03-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/475/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 08:39:38 + Build duration: 16 min CHANGE SET Revision 1ae47b73a35e65b2de9040f7da69166bd7a5b1ae by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 479 - Fixed!

2017-03-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/479/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 08:39:38 + Build duration: 16 min CHANGE SET Revision 1ae47b73a35e65b2de9040f7da69166bd7a5b1ae

D4921: [Menu] Harmonize openRelative placement

2017-03-21 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4921 To: subdiff, #plasma, hein Cc: #frameworks, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5088: Generate plugins.qmltypes files for the plugins we install

2017-03-21 Thread Aleix Pol Gonzalez
apol added a comment. Ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5088 To: apol, #plasma, #frameworks Cc: davidedmundson, hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5087: Introduce ecm_generate_qmltypes

2017-03-21 Thread Aleix Pol Gonzalez
apol added a comment. Ping REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5087 To: apol, #frameworks, #build_system

D5102: Add scroll-barmarks also to the built-in search

2017-03-21 Thread Kåre Särs
sars added a comment. I searched through the kdevelop repo and found marks 8, 21-27 in use + the "reserved" for Bookmark,... So for KDevelop it looks OK, but we have other users also. Should I add "SearchMatch = markType32" to the MarkTypes enum to reserve it? REPOSITORY R39

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 481 - Fixed!

2017-03-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/481/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 22 Mar 2017 03:00:19 + Build duration: 7 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 481 - Fixed!

2017-03-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/481/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 22 Mar 2017 03:00:19 + Build duration: 7 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 63 - Unstable!

2017-03-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 13:58:30 + Build duration: 4 min 36 sec CHANGE SET Revision

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-03-21 Thread René J . V . Bertin
rjvbb updated this revision to Diff 12666. rjvbb added a comment. Maintain Qt4 compatibility CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12647=12666 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/main.cpp

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 64 - Unstable!

2017-03-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 14:04:16 + Build duration: 12 min CHANGE SET Revision

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-03-21 Thread Luigi Toscano
ltoscano added a comment. Which repository is this? Oxygen? Please add it. REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-03-21 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5111#96517, @ltoscano wrote: > Which repository is this? Oxygen? Please add it. Apologies, something must have gone wrong adding it the 1st time. REPOSITORY R113 Oxygen Theme REVISION DETAIL

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 480 - Unstable!

2017-03-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/480/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Mar 2017 13:58:13 + Build duration: 7 min 11 sec CHANGE SET Revision