D5413: makes KArchive be optional and do not build extractors needing it

heikobecker added a comment. In https://phabricator.kde.org/D5413#102273, @dfaure wrote: > Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing? > Not sure if that works for KF5 components. No, OPTIONAL

Problems with Python bindings in KF5

(CC'ed to the author of the bindings) Hello, There are a few problems with the KF5 Python bindings, which emerged when people (including but not limited to myself) wanted to package them. First of all, they are untestable in anything that's not a Debian based distro, because they don't look

D5030: kioexec: delegate upload to a kded module

This revision was automatically updated to reflect the committed changes. elvisangelaccio marked an inline comment as done. Closed by commit R241:a7758fb66481: kioexec: delegate upload to a kded module (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to do with te patch and be caused by the

D5030: kioexec: delegate upload to a kded module

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Feel free to push after that last fix. INLINE COMMENTS > kioexecd.cpp:58 > +qCDebug(KIOEXEC) << "About to delete" << parentDir << "containing" > << info.fileName(); > +

D5463: Pug/Jade Syntax

dhaumann added a comment. Do you also agree to release this highlighting file under MIT license? Same for the test case you attached? Also, can we use this test case for unit testing? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe,

D5463: Pug/Jade Syntax

guoyunhe edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5431: New LESS syntax based on SCSS

guoyunhe added reviewers: KTextEditor, Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5368: http slave: send error page after authorization failure

anthonyfieroni added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5368 To: schwab, #frameworks, dfaure Cc: dfaure, ltoscano

Re: Review Request 130069: Reproducible builds: drop version from XMLGUI_COMPILING_OS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130069/#review103047 --- Ship it! Ship It! - David Faure On April 7, 2017,

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kaboutdata.h:314 > Why should it happen before? (sorry for being stubborn and curious here, I > want to make sure to understand all code, to then also write proper warnings > in the dox when needed, so people know they should

D5368: http slave: send error page after authorization failure

dfaure added a comment. Seems consistent with the code further down, but I'm really puzzled because this code was the same in kdelibs4... Anyone with konqueror4 to test this? Otherwise I can do that in the office, 10 days from now. REPOSITORY R241 KIO REVISION DETAIL

D5463: Pug/Jade Syntax

guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN F3709335: Screenshot_20170415_14.png F3709391: standard.pug

D5463: Pug/Jade Syntax

guoyunhe edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 516 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/516/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Apr 2017 15:27:24 + Build duration: 22 min CHANGE SET Revision a7758fb66481f05d1791687b415331a4f4af782f by

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 516 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/516/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Apr 2017 15:27:24 + Build duration: 22 min CHANGE SET Revision a7758fb66481f05d1791687b415331a4f4af782f by

Re: Review Request 130084: Add a pair of flags forcing fsync during copy loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130084/#review103048 --- But doesn't this make copying much slower in the normal

D5413: makes KArchive be optional and do not build extractors needing it

dfaure added a comment. Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing? Not sure if that works for KF5 components. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5413 To:

D5368: http slave: send error page after authorization failure

schwab added a comment. kio4 has the same problem. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5368 To: schwab, #frameworks Cc: dfaure, ltoscano

Re: Problems with Python bindings in KF5

In data sabato 15 aprile 2017 16:10:24 CEST, Luca Beltrame ha scritto: > https://build.opensuse.org/build/ > home:luca_b:branches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n/ > _log As these build logs are only available to users logged in the OBS, the error is pasted here as well (no

Re: Problems with Python bindings in KF5

El dissabte, 15 d’abril de 2017, a les 16:10:24 CEST, Luca Beltrame va escriure: > (CC'ed to the author of the bindings) > > Hello, > > There are a few problems with the KF5 Python bindings, which emerged when > people (including but not limited to myself) wanted to package them. > > First of

D5456: KDoctools: build on Mac with docbook from homebrew

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I'd say: Add a comment that this is for OS X/homebrew then it's okay as-is. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc:

D5394: KAuth integration in document saving - vol. 2

fvogt added a comment. It is currently not possible to avoid a race condition as QSaveFile is broken and use of it is currently insecure as the file is created world-readable. It can be avoided by placing the file in a drwx-- directory, but that's more work than just using

KAuth buildability: new CI architecture

Hi all, As some will be aware i've been working on a new architecture for the CI system which will solve a number of the problems we currently have with the current iteration. The new design should allow us to: 1) Use different base systems for different groupings of projects 2) Will eliminate

Re: Review Request 130084: Add a pair of flags forcing fsync during copy loop

> On April 15, 2017, 8:30 a.m., David Faure wrote: > > But doesn't this make copying much slower in the normal case? (copying onto > > a non-removable harddisk partition). > > > > It sounds to me like this should be > > 1) done internally in kio_file (no Job API for this) > > 2) only when the

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 518 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/518/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 16 Apr 2017 02:01:30 + Build duration: 22 min CHANGE SET Revision

Re: Review Request 130084: Add a pair of flags forcing fsync during copy loop

> On April 15, 2017, 10:30 a.m., David Faure wrote: > > But doesn't this make copying much slower in the normal case? (copying onto > > a non-removable harddisk partition). > > > > It sounds to me like this should be > > 1) done internally in kio_file (no Job API for this) > > 2) only when the

D5394: KAuth integration in document saving - vol. 2

martinkostolny added a comment. Sorry for answering after a longer time. I need to be sure I understand everything correctly: ad checksum: I think it would be good to revert to previous code and start from ther (to ensure writing only once and not over d-bus): 1. create a temp file

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

kfunk updated this revision to Diff 13476. kfunk added a comment. Address mpyne's concerns REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5430?vs=13396=13476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5430 AFFECTED FILES

D5413: makes KArchive be optional and do not build extractors needing it

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. +1 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5413 To: mgallien, kfunk Cc: kfunk, heikobecker, dfaure, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

mgallien updated this revision to Diff 13496. mgallien added a comment. added a set_package_properties for KF5Archive REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5413?vs=13359=13496 BRANCH karchive_optional REVISION DETAIL

D5443: fix duplicated symbols compilation error with mingw on Windows

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH windows_fix REVISION DETAIL https://phabricator.kde.org/D5443 To: mgallien, kfunk, #windows Cc: #frameworks

D5456: KDoctools: build on Mac with docbook from homebrew

ltoscano added a comment. if a comment should be added, then the review should not be accepted (yet) REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation, skadinna

D5394: KAuth integration in document saving - vol. 2

martinkostolny added a comment. One more question - is it necessary to show the checksum to the user? I don't see what it would be good for, but I'm probably missing something. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5394 To: martinkostolny,

D5456: KDoctools: build on Mac with docbook from homebrew

kfunk added a comment. It's a "fix it, then ship it" like acceptance. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation, skadinna