D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise the user cannot tell whether what's going to be typed will be visible or not. Same fix as in

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 530 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/530/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 18:49:51 + Build duration: 21 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 530 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/530/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 18:49:51 + Build duration: 21 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

elvisangelaccio added a comment. @cfeck Ping? REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

cfeck added a comment. Elvis, this was already accepted. If I had objections, I would have stopped you :) REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH knewpasswordwidget-leak REVISION DETAIL https://phabricator.kde.org/D5530 To: elvisangelaccio, cfeck Cc: #frameworks

D5167: Move .po and .ts files look-up to build-time

This revision was automatically updated to reflect the committed changes. Closed by commit R249:a54ae95b520e: Move .po and .ts files look-up to build-time (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5167?vs=13404=13654#toc REPOSITORY R249 KI18n CHANGES SINCE

Re: Threadweaver compilation failure: Windows

Again, I don't have full Visual Studio installed, only build tools. Command Prompt does not show me anything, but installer displays version number - 15.1 (26403.7) ( https://puu.sh/vqgvx/f9122db5ef.png ) 2017-04-20 15:31 GMT+05:00 Ben Cooksley : > On Wed, Apr 19, 2017 at 7:24

Re: Threadweaver compilation failure: Windows

On Thu, Apr 20, 2017 at 10:54 PM, Alexey Min wrote: > Again, I don't have full Visual Studio installed, only build tools. > Command Prompt does not show me anything, but installer displays > version number - 15.1 (26403.7) > ( https://puu.sh/vqgvx/f9122db5ef.png ) Okay.

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 162 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/162/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 12:13:45 + Build duration: 3 min 8 sec CHANGE SET No changes JUNIT RESULTS

D5523: use correct variable for fetch-translations injection

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY KDE_L10N_AUTO_TRANSLATIONS is the name of the relevant option REPOSITORY R240 Extra CMake Modules BRANCH

D5523: use correct variable for fetch-translations injection

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5523 To: sitter, apol Cc: #frameworks, #build_system

D5523: use correct variable for fetch-translations injection

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fe46a935227f: use correct variable for fetch-translations injection (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/ --- (Updated April 20, 2017, 8:49 a.m.) Review request for KDE Frameworks.

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

palokisa added a comment. In https://phabricator.kde.org/D5521#103536, @apol wrote: > In https://phabricator.kde.org/D5521#103535, @palokisa wrote: > > > > Make them optional dependencies. > > > > What do you mean by this? > > > > > find_package(KF5Crash) #note there's

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 19, 2017, 11:28 a.m., Lamarque Souza wrote: > > autotests/solidudisks2test.cpp, line 78 > > > > > > I think registering to systemBus only works if you are root or has the > > right permissions in

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

apol added a comment. In https://phabricator.kde.org/D5521#103535, @palokisa wrote: > > Make them optional dependencies. > > What do you mean by this? find_package(KF5Crash) #note there's no REQUIRED if (KF5Crash_FOUND) somethingsomething() endif()

D5515: Update the ungrabMouse hack for Qt 5.8

mart added a comment. do you know off hand a list of places where this is needed? i think kicker,taskmanager,systray... anything else? REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D5515 To:

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 553 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/553/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 05:27:33 + Build duration: 5 min 7 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 553 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/553/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 05:27:33 + Build duration: 5 min 7 sec CHANGE SET No changes JUNIT RESULTS

D5515: Update the ungrabMouse hack for Qt 5.8

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson, #plasma, mart Cc: anthonyfieroni, mvourlakos,

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

palokisa added a comment. > Make them optional dependencies. What do you mean by this? > What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe it's not needed at all? I don't know. I didn't investigate that.I thought, it's some kind of

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

apol added a comment. Make them optional dependencies. What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe it's not needed at all? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5521 To: palokisa, graesslin, mck182 Cc: apol,

Re: Threadweaver compilation failure: Windows

On Wed, Apr 19, 2017 at 7:24 PM, Alexey Min wrote: > Built fine for me with "Build Tools for Visual Studio 2017" > (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks" > section) which contains only compiler and libs without IDE. Okay. Would you mind

D5525: adapt to fetchpo changes and use vars for target directories to dry code

This revision was automatically updated to reflect the committed changes. Closed by commit R240:77623d19b627: adapt to fetchpo changes and use vars for target directories to dry code (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

palokisa added a comment. > Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE Why is that? Why can't we have e.g. one `foo-kde` and other `foo-lxqt` package, both providing virtual `foo` (these will be in conflict as

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 528 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/528/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 15:16:46 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 164 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 15:16:53 + Build duration: 3 min 9 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 547 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/547/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 14:32:12 + Build duration: 58 sec CHANGE SET No changes

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. I don't really understand what this change is supposed to fix. Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE. If kglobalaccel is shipped without KCrash support I would consider this as a

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 163 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/163/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 12:57:54 + Build duration: 1 min 17 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 163 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/163/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 12:57:54 + Build duration: 1 min 17 sec CHANGE SET No changes JUNIT RESULTS

D5167: Move .po and .ts files look-up to build-time

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Note that there's still an ordering problem with the new fetch-translations target now. The {ts,po}files-* targets can run before the fetch-translations target so on first run you may have

D5525: adapt to fetchpo changes and use vars for target directories to dry code

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY - fetchpo now expects the output dirs as named arguments - new argument for poqm directories where releaseme will

D5525: adapt to fetchpo changes and use vars for target directories to dry code

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Okay, note that we should stabilize fetchpo.rb though as when it's released we won't get to do these changes anymore. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 164 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 15:18:23 + Build duration: 3 min 8 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 548 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/548/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 15:40:57 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 548 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/548/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 15:40:57 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 186 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/186/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 20 Apr 2017 15:16:53 + Build duration: 4 min 17 sec CHANGE SET No changes

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103071 --- autotests/fakeUdisks2.h (line 35)

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 535 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/535/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 05:27:51 + Build duration: 4 min 52 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 535 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/535/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 05:27:51 + Build duration: 4 min 52 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Threadweaver compilation failure: Windows

I can't quickly and easily try Debug build, because for that I need a separate craft build environment built with CMAKE_BUILD_TYPE=Debug, otherwise I get linking errors about incomatible C++-runtime libraries (Qt5 was built with release msvcrt, linking threadweaver with debug one). It will take

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 529 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/529/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 16:36:48 + Build duration: 27 min CHANGE SET No changes JUNIT RESULTS Name: (root)

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

graesslin added a comment. In https://phabricator.kde.org/D5521#103661, @palokisa wrote: > > Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE > > Why is that? Why can't we have e.g. one `foo-kde` and other `foo-lxqt`

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

palokisa created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY By using the MINIMAL_RUNTIME_DEPS we allow minimizing the run-time dependencies -> remove the KCrash & KService dependency/usage.

D5394: KAuth integration in document saving - vol. 2

fvogt added a comment. Thanks again! The changes look good, but strace shows that the QFile operation still use absolute paths, apparently it resolves the "." manually with getcwd: chdir("/tmp") = 0 stat("/tmp/permfile", {st_mode=S_IFREG|0644, st_size=5,