D5889: Keep QIcon::fromTheme in main thread

2017-06-07 Thread Rik Mills
rikmills added a comment. This breaks build on Neon and Kubuntu CI with Qt 5.7.1 http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console 05:10:59 In file included from /workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0, 05:10:59

D6086: Left-click mini-map to jump to clicked area

2017-06-07 Thread Kevin Funk
kfunk added a comment. Works perfectly fine for me now, great! I don't see anything wrong with it now from a behavioral point of view. @dhaumann Maybe you want to check once more? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 To: sars, #ktexteditor,

D6122: Add since tags.

2017-06-07 Thread Thomas Friedrichsmeier
tfry added a comment. In https://phabricator.kde.org/D6122#114655, @cfeck wrote: > Since this frameworks is new as of 5.28, should we really mark each class this way? We did not do this for other "new" frameworks, such as prison or kwayland. You mean, if I'm not sure whether the

D6087: Haskell: Add all language pragmas as keywords.

2017-06-07 Thread Gleb Popov
arrowdodger added a comment. I just found that the same problem exists for `import_keywords` too - when I type `import qual`, the completion doesn't show up, and deleteting `qual` and typing it again causes it to show. So, it seems to be a coding bug. REPOSITORY R216 Syntax

D6142: Fix drop menu position on Wayland

2017-06-07 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Neat solution! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6142 To: elvisangelaccio, dfaure, mart, davidedmundson Cc:

D6142: Fix drop menu position on Wayland

2017-06-07 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6142 To: elvisangelaccio, dfaure, mart Cc: #frameworks

D6142: Fix drop menu position on Wayland

2017-06-07 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On Wayland we can't rely on global cursor position. In particual QCursor::pos() returns a wrong position when called inside a

Re: Application usage statistics and targeted user surveys

2017-06-07 Thread Albert Astals Cid
El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va escriure: > On Thursday, 25 May 2017 12:33:49 CEST Volker Krause wrote: > > On Tuesday, 23 May 2017 18:31:35 CEST Aleix Pol wrote: > > > I would have looked into fixing it, but I'm not sure I understand why > > > there's all

Re: Application usage statistics and targeted user surveys

2017-06-07 Thread Aleix Pol
On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid wrote: > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va > escriure: >> On Thursday, 25 May 2017 12:33:49 CEST Volker Krause wrote: >> > On Tuesday, 23 May 2017 18:31:35 CEST Aleix Pol wrote: >> > > I would

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 9 - Failure!

2017-06-07 Thread no-reply
BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 Date of build: Wed, 07 Jun 2017 12:12:56 + Build duration: 1 min 11 sec and counting

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 10 - Still Failing!

2017-06-07 Thread no-reply
BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 Date of build: Wed, 07 Jun 2017 14:17:49 + Build duration: 1 min 25 sec and

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 11 - Fixed!

2017-06-07 Thread no-reply
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/11/ Project: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 Date of build: Wed, 07 Jun 2017 14:31:54 + Build duration: 2 min 37 sec and

D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

2017-06-07 Thread Matthieu Gallien
mgallien added a comment. Ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D4377 To: awilcox, mgallien Cc: #frameworks

D5747: add pid to plasma window management protocol

2017-06-07 Thread Sebastian Kügler
sebas closed this revision. sebas added a comment. Issue has been fixed elsewhere, otherwise code is submitted. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot,