D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-16 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6683?vs=16755=16775#toc REPOSITORY

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread Martin Flöser
graesslin added a comment. I like the idea! That would basically allow us to abandon https://phabricator.kde.org/D6571 and would also solve the issues we see with the kwayland-integration plugin which can crash applications on exit. May I ask for a small unit test for the new

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread David Edmundson
davidedmundson added a comment. We still need https://phabricator.kde.org/D6571, with my proposed change. That's a special case where we delete the connection before the QPA. My added connect means that we get that signal regardless of whether we're in Kwin or not. What we wouldn't

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote: > We still need https://phabricator.kde.org/D6571, with my proposed change. That's a special case where we delete the connection before the QPA. It might be that we don't need it. Also

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ASAN found a heap-use-after-free when deleting the focused keyboard surface in the client library. Keyboard did not

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH keyboard-entered-surface-cleanup REVISION DETAIL https://phabricator.kde.org/D6741 To: graesslin, #frameworks, #plasma, davidedmundson Cc: plasma-devel, ZrenBot,

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:bea87753629e: [client] Properly track enteredSurface in Keyboard (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6741?vs=16786=16797

D6700: disable compiler warning on testing deprecated function

2017-07-16 Thread Michael Pyne
mpyne accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH no-testwarning REVISION DETAIL https://phabricator.kde.org/D6700 To: sitter, mpyne Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

2017-07-16 Thread Michael Pyne
mpyne requested changes to this revision. mpyne added a comment. This revision now requires changes to proceed. Still a couple of things: 1. The included new autotest fails for me, because of using `OrLaterVersion` as a default version restriction. `OnlyThisVersion` is used elsewhere as