BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/36/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 08 Aug 2017 02:51:17 +
Build duration:
4 min 46 sec and counting
JUnit Tests
apol updated this revision to Diff 17863.
apol added a comment.
Add missing detach()
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7194?vs=17844=17863
BRANCH
detach
REVISION DETAIL
https://phabricator.kde.org/D7194
AFFECTED FILES
apol updated this revision to Diff 17862.
apol added a comment.
Make sure there's such a button
REPOSITORY
R252 Framework Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7196?vs=17860=17862
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7196
AFFECTED
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
QAbstractButton::setText will call setShortcut(mnemonic), making this
little hack unusable.
This patch puts the shortcut into a separate object.
TEST PLAN
Improved the test to reproduce the
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsQt5.7/57/
Project:
Frameworks kio kf5-qt5 WindowsQt5.7
Date of build:
Tue, 08 Aug 2017 02:51:03 +
Build duration:
25 min and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/49/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 08 Aug 2017 02:52:32 +
Build duration:
24 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20WindowsQt5.7/19/
Project:
Frameworks frameworkintegration kf5-qt5 WindowsQt5.7
Date of build:
Tue, 08 Aug 2017 02:50:22 +
Build duration:
14 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/21/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 08 Aug 2017 02:52:17 +
Build duration:
13 min and counting
JUnit Tests
apol added a comment.
In https://phabricator.kde.org/D7094#133579, @dfaure wrote:
> Would that help with doing things right for the issue in
https://phabricator.kde.org/D6466 as well?
No, I don't think so. This is mostly for packagers who need to document
dependencies.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/26/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 08 Aug 2017 02:51:52 +
Build duration:
8 min 15 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20WindowsQt5.7/23/
Project:
Frameworks kconfigwidgets kf5-qt5 WindowsQt5.7
Date of build:
Tue, 08 Aug 2017 02:50:42 +
Build duration:
17 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/21/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Tue, 08 Aug 2017 02:51:52 +
Build duration:
5 min 0 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsQt5.7/27/
Project:
Frameworks breeze-icons kf5-qt5 WindowsQt5.7
Date of build:
Tue, 08 Aug 2017 02:50:12 +
Build duration:
8 min 57 sec and counting
JUnit
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file_unix.cpp:244
> #endif
> -dest_file.remove(); // don't keep partly copied file
> +if (!!QFile::remove(dest)) { // don't keep
kfunk added a comment.
Guys... no one gave me an "Accepted' yet :)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
kossebau added a comment.
+1 as well. Please also add a note in the API dox what BUILD_TESTING will do
on this macro, so this is not magic behaviour and people can plan with this
(like making sure to not `set target_link_libraries(... Qt5::Tests)`
separately, but only pass as args in the
This revision was automatically updated to reflect the committed changes.
Closed by commit R274:93a2acfe2e66: Qt5DBus is only required with
HAVE_XSCREENSAVER (authored by asturmlechner).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7156?vs=17763=17852#toc
REPOSITORY
R274 KIdleTime
kfunk added a comment.
In https://phabricator.kde.org/D7187#133497, @kossebau wrote:
> +1 as well. Please also add a note in the API dox what BUILD_TESTING will
do on this macro, so this is not magic behaviour and people can plan with this
(like making sure to not set
cordlandwehr accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R868 Yocto: KDE Frameworks Packaging
BRANCH
kpeople
REVISION DETAIL
https://phabricator.kde.org/D7118
To: vkrause, cordlandwehr
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk, vkrause
Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks,
#build_system
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Resolve the following warning printed out when the undo/redo actions
are added through KUndoActions:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20WindowsQt5.7/29/
Project:
Frameworks kxmlgui kf5-qt5 WindowsQt5.7
Date of build:
Mon, 07 Aug 2017 21:32:55 +
Build duration:
3 min 36 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/44/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 07 Aug 2017 20:26:26 +
Build duration:
1 min 35 sec and counting
dfaure added a comment.
Would that help with doing things right for the issue in
https://phabricator.kde.org/D6466 as well?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7094
To: apol, #build_system, #frameworks, sitter
Cc: dfaure, aacid
broulik added inline comments.
INLINE COMMENTS
> entryinternal.cpp:169
> {
> d->mCategory = category;
> }
Detach here also
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7194
To: apol, leinir
Cc: broulik, #frameworks
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7195
To: ltoscano, aacid
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/35/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Mon, 07 Aug 2017 20:26:26 +
Build duration:
2 min 0 sec and counting
dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7142
To: dfaure, dmariano, davidedmundson
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:b99d2d2c5ded: RFC: Make ECMAddTests respect BUILD_TESTING
(authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7187?vs=17835=17858#toc
REPOSITORY
R240 Extra CMake Modules
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:f2b5114d8b90: KUndoActions: use actionCollection to set
the shortcut (authored by ltoscano).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7195?vs=17857=17859
turbov added a comment.
In https://phabricator.kde.org/D7175#133152, @dhaumann wrote:
> I see seveal issues that imo should be addressed:
>
> 1. Please add a test case in autotest/input/ or extend it if one already
exists (did you run make test?)
no, I don't run tests yet (it
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:81
>
> -find_file(kwallet_xml org.kde.KWallet.xml HINTS
> ${CMAKE_CURRENT_SOURCE_DIR}/../../api/KWallet)
> +set(kwallet_xml
> ${CMAKE_CURRENT_SOURCE_DIR}/../../api/KWallet/org.kde.KWallet.xml)
>
How about
kfunk updated this revision to Diff 17835.
kfunk added a comment.
Fix typo. "no-top" is something else.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7187?vs=17830=17835
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
elvisangelaccio added a comment.
In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable
the target if `BUILD_TESTING` is false, why is that not enough?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc:
kfunk added a comment.
In https://phabricator.kde.org/D7187#133358, @elvisangelaccio wrote:
> In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable
the target if `BUILD_TESTING` is false, why is that not enough?
Good question. I didn't explain that in the
elvisangelaccio added a comment.
Oh, I see. +1 then!
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
davidedmundson updated this revision to Diff 17813.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Unbind global
Add a test for transientFor
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
mart updated this revision to Diff 17832.
mart added a comment.
more comments
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7127?vs=17712=17832
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7127
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0c27df529d80: ignore spurious resize events to empty
sizes (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
apol added a comment.
+1
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc: apol, #frameworks, #build_system
kfunk updated this revision to Diff 17830.
kfunk added a comment.
Remove unrelated hunks
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7187?vs=17829=17830
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
AFFECTED FILES
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
thanks!
add some code comments.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D7127
REVISION DETAIL
https://phabricator.kde.org/D7127
To: mart,
mart added a comment.
finally figured out where this event is generated:
it's a spontaneous event generated in qguiapplication.cpp
QGuiApplicationPrivate::processWindowScreenChangedEvent
around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent
gce(window,
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Use-case: Make building unit tests optional, by just following the CMake
BUILD_TESTING option.
The usual
kfunk added a comment.
It's not possible to easily disable tests at the moment, is it? I might be
missing something.
Anyhow, this patch tries to make it easy to build KDevelop without tests;
trying to avoid hacky approaches like those being done in Gentoo:
asturmlechner added a comment.
In https://phabricator.kde.org/D7187#11, @kfunk wrote:
> Anyhow, this patch tries to make it easy to build KDevelop without tests;
trying to avoid hacky approaches like those being done in Gentoo:
Much appreciated if we can drop those.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7130#132809, @gregormi wrote:
> Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an
application is installed by passing the desktop filename (without extension),
i.e. "org.kde.filelight" or
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R274 KIdleTime
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7156
To: asturmlechner, #frameworks, kfunk
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20WindowsQt5.7/22/
Project:
Frameworks kdbusaddons kf5-qt5 WindowsQt5.7
Date of build:
Mon, 07 Aug 2017 07:19:33 +
Build duration:
1 min 30 sec and counting
JUnit
dhaumann added a comment.
I see two issues that imo should be addressed:
1. Please add a test case in autotest/input/ or extend it if one already
exists (did you run make test?)
2. How does it work, are we supposed to run this command from time to time
manually? If so, then I'd be
turbov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
CMake syntax has been redesigned to pursue the following goals:
- the former generator has used an output of `cmake --help` (and
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/20/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Mon, 07 Aug 2017 07:37:56 +
Build duration:
1 min 22 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/25/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 07 Aug 2017 07:37:56 +
Build duration:
1 min 1 sec and counting
JUnit Tests
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
I don't see why `find_file` would be needed here, yep.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
To: vkrause, #frameworks, kfunk
Cc:
mart marked an inline comment as done.
mart added a comment.
not sure how to proceed in debugging this, as all i have is a resize event
handler being called, which a backtrace there is useless to figure out who is
resizing it
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
cullmann added a reviewer: vkrause.
cullmann added a comment.
If that makes it easier to keep the syntax file up-to-date, I would have no
issues with a generator build in this way.
If we ever want to go away from it, we still have the generated file around
as base.
But Volker should give
apol created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Only consider it an error if the knsregistry file is present but can't
be written on.
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION
kfunk accepted this revision.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
To: vkrause, #frameworks, kfunk
Cc: apol, kfunk
elvisangelaccio added a comment.
Ping?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D6774
To: elvisangelaccio, #frameworks
Cc: cfeck
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d475e74cbe59: kcmtrash: fix i18n warning (authored by
elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6815?vs=16975=17847
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R311:a14de9351608: Don't use find_file for finding files in
our own source dir (authored by vkrause).
REPOSITORY
R311 KWallet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7136?vs=17843=17848
vkrause added a comment.
Another +1, would also help the KDE Yocto recipes.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
62 matches
Mail list logo
