D7194: Detach before setting the d pointer

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Ah, yes, good catch :) REPOSITORY R304 KNewStuff BRANCH detach REVISION DETAIL https://phabricator.kde.org/D7194 To: apol, leinir Cc: broulik, #frameworks

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. I'm still in favor of pushing this one too. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai,

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. I'm still against it. Passing unexpectedly invalid pointers about all over the place and then trying to guard them afterwards is an anti pattern that leads to future problems. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078

D7190: Don't complain the knsregistry file is not present before it's useful

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Good call, yes - gets rid of a lump of irrelevant and technically correct but subjectively incorrect information. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL

Re: KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 5 - Failure!

Hi all, This failed because KIO tests are leaving processes behind at their conclusion. Could someone please check to see what has changed here and ensure that KIO tests cleanup after themselves? Cheers, Ben On Wed, Aug 23, 2017 at 2:48 AM, wrote: > *BUILD FAILURE* > Build

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 10:18 PM, Luigi Toscano wrote: > Harald Sitter wrote: >> Ahoy ahoy >> >> I've just stumbled upon a rather puzzling situation with kdoctools. It >> has code branching to turn its assets relocatable [1] (i.e. resolve >> paths relative rather than

D7478: Escape hyphen in rest.xml regular expressions

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The unescaped hyphen caused a build failure with pcre2-10.30 due to a broken regex: 'syntax-highlighting/data/syntax/rest.xml" line 27

D7478: Escape hyphen in rest.xml regular expressions

heikobecker updated this revision to Diff 18584. heikobecker added a comment. Removed accidentally included change. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7478?vs=18583=18584 BRANCH master REVISION DETAIL

D7480: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs

elvisangelaccio edited the summary of this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7480 To: elvisangelaccio, dfaure Cc: #frameworks

D7480: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We are already using qCDebug(), so there is no reason to have this ifdefs all over the place. REPOSITORY R303 KInit BRANCH

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With flatpak applications we can have the following scenario: appId= "org.kde.ark.kdbus-_1_769" newAppId= "org.kde.ark.kdbus"

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 10:47 PM, Ralf Habacker wrote: > Hi, > > I'm using the following patch to cross build kdoctools for windows > >

D7484: Add highlight definition for Tiger

pablooliveira created this revision. pablooliveira added a project: Framework: Syntax Hightlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Tiger is a simple teaching language defined by Andrew W. Appel in his

D7478: Escape hyphen in rest.xml regular expressions

heikobecker added a comment. In https://phabricator.kde.org/D7478#138855, @alexeymin wrote: > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? Wasn't aware of the bug report, but yes. Will add a BUG: reference before pushing if this is accepted. REPOSITORY

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio updated this revision to Diff 18600. elvisangelaccio added a comment. - Add reference to https://phabricator.kde.org/D5775 REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7479?vs=18585=18600 BRANCH kdbus-appId REVISION DETAIL

D7478: Escape hyphen in rest.xml regular expressions

dhaumann added a comment. Please increase the version number! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause Cc: dhaumann, alexeymin, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause Cc: alexeymin, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

vkrause added a comment. Ah, right, I forget to check for the version number every time :) Thanks Dominik! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause Cc:

D7478: Escape hyphen in rest.xml regular expressions

alexeymin added a comment. Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk Cc: alexeymin, #frameworks

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio added a comment. I just realized that ".kdbus" is appended by KDBusAddons, not by flatpak. Maybe we could also fix it there... REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7479 To: elvisangelaccio, dfaure, apol Cc: #frameworks

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18596. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - Don't call release twice - Correctly set - don't call destroy in the destroyed callback - add a test exporting a surface two times - test

D7478: Escape hyphen in rest.xml regular expressions

kfunk added a comment. In https://phabricator.kde.org/D7478#138855, @alexeymin wrote: > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? I think so. FWIW: Here's another upstream report, filed by Heiko himself: https://bugs.exim.org/show_bug.cgi?id=2158

D7369: [WIP] Wayland foreign protocol

mart added a comment. now the client part is wrapped too, so no V1 exported (the public facing classes should lose "Unstable" probably) two more tests to check that importing the same exported in two clients works and exporting the same surface two times works as well. thanks to david's

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio added a comment. In https://phabricator.kde.org/D7479#138860, @elvisangelaccio wrote: > I just realized that ".kdbus" is appended by KDBusAddons, not by flatpak. Maybe we could also fix it there... Nope, it's intentional (see https://phabricator.kde.org/D5775). So

D7479: klauncher: fix appId matching for flatpak apps

elvisangelaccio edited the summary of this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7479 To: elvisangelaccio, dfaure, apol Cc: #frameworks

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.7 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks baloo kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 23 Aug 2017 17:20:44 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/58/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 23 Aug 2017 18:11:54 + Build duration: 4 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/57/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 23 Aug 2017 17:36:04 + Build duration: 1 min 6 sec and counting JUnit Tests

D7487: Make KCMultiDialog scrollable

broulik added a comment. +1 but re-arrange the includes in a separate commit as it's not really related to this. System Settings has its own scroll bars anyway, so I think no KCM adds them on its own. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487

D7368: [KACLEditWidget] Allow double clicking to edit entry

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7368 To: broulik, dfaure Cc: #frameworks

D7462: [kiocore] assert that klauncher is running or not

bshah added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7462 To: bshah, #frameworks, sitter, dfaure

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 53 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/53/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 23 Aug 2017 17:36:04 + Build duration: 24 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 54 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/54/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 23 Aug 2017 18:11:54 + Build duration: 42 sec and counting CONSOLE OUTPUT

D7487: Make KCMultiDialog scrollable

valeriymalov created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Put KCModuleProxy into a QScrollArea the same way SystemSettings does This should make kcmshell and other users of KCMultiDialog a bit more friendly to small screens However, this

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Wed, 23 Aug 2017 17:20:44 + Build duration: 4 min 29 sec and counting JUnit Tests

D7380: KCD: use modern logging classes throughout

dfaure added a comment. It is rather hard to follow your reasoning... 1. QtInfoMsg is *between* QtDebugMsg and QtWarningMsg, so it's *not* more verbose than QtDebugMsg, it's less. This is why our default setup (in the ECM macro) is to enable "info and up" (i.e. info, warning, critical)

D7491: Fix invalid id in viewitem.

xuetianweng created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It should be selected+hover instead of selected_hover. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D7479: klauncher: fix appId matching for flatpak apps

dfaure added inline comments. INLINE COMMENTS > klauncher.cpp:380 > +// Match sandboxed apps (e.g. flatpak), see > https://phabricator.kde.org/D5775 > +if (newAppId.endsWith(QStringLiteral(".kdbus"))) { > +return newAppId.startsWith(pendingAppId); QString::endsWith() has a

D6829: Add ability to use the new kauth helper in file ioslave

dfaure added a comment. Urgh you don't need a new variable for failure(), just do bool failed() const { return !m_success && !m_canceled; } REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6197: Add kauth helper to file ioslave

dfaure accepted this revision. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6829: Add ability to use the new kauth helper in file ioslave

chinmoyr added a comment. Actually, I like this construct quite a bit. if (!dir.rmdir(itemPath)) { if (auto ret = execWithElevatedPrivilege(RMDIR, itemPath)) { if (!ret.wasCanceled()) { error(KIO::ERR_CANNOT_DELETE, itemPath); }

D7462: [kiocore] assert that klauncher is running or not

bshah marked an inline comment as done. bshah added inline comments. INLINE COMMENTS > dfaure wrote in slave.cpp:111 > } else if (...) { > > We don't want/need to turn reply into a bool if it's not valid. > > Alternatively this could be written as > > if (!reply.isValid() || getuid() !=

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 91 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/91/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 24 Aug 2017 05:21:24 + Build duration: 1 min 54 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 90 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/90/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 24 Aug 2017 04:57:29 + Build duration: 4 min 13 sec and counting CONSOLE OUTPUT

D7462: [kiocore] assert that klauncher is running or not

This revision was automatically updated to reflect the committed changes. bshah marked an inline comment as done. Closed by commit R241:c85a8e03f768: [kiocore] Check that klauncher is running or not (authored by bshah). CHANGED PRIOR TO COMMIT

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/22/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Thu, 24 Aug 2017 05:06:44 + Build duration: 5 min 22 sec and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.7 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.7/25/ Project: Frameworks baloo kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 24 Aug 2017 05:06:44 + Build duration: 6 min 11 sec and counting CONSOLE OUTPUT

D5463: Pug/Jade Syntax

guoyunhe abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

D7368: [KACLEditWidget] Allow double clicking to edit entry

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kacleditwidget.cpp:951 > + > +// avoid conflict with clicking to toggle premission > +if (column >= 2 && column <= 4) { typo: permission REPOSITORY R241 KIO

D5775: Don't include the pid in the dbus path when on flatpak

dfaure added inline comments. INLINE COMMENTS > kdbusservice.cpp:98 > +bool inSandbox = false; > +if (!qEnvironmentVariableIsEmpty("XDG_RUNTIME_DIR")) { > +const QByteArray runtimeDir = qgetenv("XDG_RUNTIME_DIR"); this if() seems useless (double lookup).

D7487: Make KCMultiDialog scrollable

valeriymalov updated this revision to Diff 18616. valeriymalov added a comment. Split commit in two (hopefully) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18604=18616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487

D4495: Remove monochrome application icons

guoyunhe abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D4495 To: guoyunhe, #breeze Cc: andreaska, #frameworks

D7480: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D7480 To: elvisangelaccio, dfaure Cc: #frameworks

D7462: [kiocore] assert that klauncher is running or not

dfaure added a comment. Makes sense. INLINE COMMENTS > slave.cpp:111 > +// fallback: if there's an klauncher process owned by a > different user: still fork > +if (getuid() != reply) { > fork = true; } else if (...) { We don't want/need to turn

D7462: [kiocore] assert that klauncher is running or not

dfaure added a comment. Just remove "assert" from the commit message, this isn't asserting anything, it's handling an error case that the code wasn't handling (at least not correctly). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7462 To: bshah, #frameworks,

D7478: Escape hyphen in rest.xml regular expressions

heikobecker updated this revision to Diff 18602. heikobecker added a comment. Increased version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7478?vs=18584=18602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 AFFECTED

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 82 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/82/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 23 Aug 2017 14:27:53 + Build duration: 33 sec and counting

D7478: Escape hyphen in rest.xml regular expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ad077e4045e6: Escape hyphen in rest.xml regular expressions (authored by heikobecker). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE