aacid added a comment.
Damnit, i commited it and now the tests are not passing :(
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/89/console
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos,
zrax created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This allows applications to include application-specific syntax rules
and themes which don't necessarily make sense to install globally to be
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3f9f38a18b60: Added Intel HEX file support for the Syntax
highlighting database (authored by martonmiklos, committed by aacid).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
aacid closed this revision.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D7487
To: valeriymalov, #frameworks, davidedmundson
Cc: davidedmundson, wbauer, broulik
cullmann added a comment.
syntax-highlighting.git, on first glance not landed atm.
Can you commit on your own or should I push it for you Miklos?
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann,
aacid closed this revision.
aacid added a comment.
Seems you commited this but forgot to close this?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: kossebau, aacid, kfunk, #frameworks, #build_system
zrax retitled this revision from "Add support for custom search paths for
application-specific syntax and themedefinitions" to "Add support for custom
search paths for application-specific syntax and theme definitions".
zrax edited the summary of this revision.
zrax edited the test plan for this
zrax retitled this revision from "Add support for custom search paths for
application-specific syntax and theme
definitions" to "Add support for custom search paths for application-specific
syntax and themedefinitions".
zrax added reviewers: Kate, Framework: Syntax Hightlighting.
REPOSITORY
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#143314, @cullmann wrote:
> syntax-highlighting.git, on first glance not landed atm.
>
> Can you commit on your own or should I push it for you Miklos?
Hi guys,
I am on holiday ATM so if you could push it
aacid added a comment.
Which repo is this for?
Has this landed?
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
aacid requested changes to this revision.
This revision now requires changes to proceed.
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
aacid set the repository for this revision to R216 Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/91/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Tue, 05 Sep 2017 21:12:02 +
Build duration:
2 min 36 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/89/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Sep 2017 21:12:03 +
Build duration:
2 min 1 sec and counting
rkflx added a reviewer: cfeck.
rkflx added a comment.
@cfeck Friendly ping :)
Please let me know if you have any questions or someone else should review
this. We really don't want to BIC-break a Tier 1 framework…
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
cfeck added a comment.
I probably miss the big picture here. Why are these attributes needed? The
lineWidth attribute, for example, looks like a thing from the past, where you
could control the thickness of frames (CDE vs. Motif style).
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
cfeck added a comment.
QLabel sends out a QEvent::ContentsRectChange event when the margins change
or the frame style causes a size change. Could this be catched (using an event
filter) instead of reimplementing the properties?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
progwolff created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KDirWatch emits a dirty signal for a watched directory when a file is ceated
in this directory.
However, currently this signal is not emitted when a file is added that is
watched
progwolff abandoned this revision.
progwolff added a comment.
Invalid. Worked as expected without my changes. I did not test it correctly.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7697
To: progwolff, #frameworks
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/45/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Tue, 05 Sep 2017 09:10:07 +
Build duration:
3 min 14 sec and counting
progwolff edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7697
To: progwolff, #frameworks
maxrd2 added a comment.
In https://phabricator.kde.org/D7676#143033, @broulik wrote:
> Well it is now "openService" calling "runApplication", that's inconsistent
isn't it
Yes, but it will start services that have Exec line though.
Should i just rename the method to
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8d38df353422: Fix invalid id in viewitem. (authored by
xuetianweng).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7491?vs=18618=19209
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Overall lots of documentation is missing.
From API layout that looks much better now, but we still have a few places
where "Unstable" is needlessly in the API. Most
mart retitled this revision from "[WIP] Wayland foreign protocol" to "Wayland
foreign protocol".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7369
To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,
25 matches
Mail list logo
