D7660: Fix a regression caused by changing backspace key behavior

jgrulich added a comment. In https://phabricator.kde.org/D7660#144734, @safaalfulaij wrote: > In https://phabricator.kde.org/D7660#144706, @jgrulich wrote: > > > Not sure I can say much, I wrote this patch because I got a bug report where for Indic locales they were not able to

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. In https://phabricator.kde.org/D7660#144706, @jgrulich wrote: > Not sure I can say much, I wrote this patch because I got a bug report where for Indic locales they were not able to remove composed characters. while other software (QtCreator, Libreoffice)

D7706: Use runtime install prefix instead of compile time install prefix.

habacker added a comment. > If all you need is , you can use QCoreApplication::applicationDirPath(). Did a further look into this stuff and found https://cgit.kde.org/kinit.git/commit/src/kdeinit/kinit_win.cpp?id=6b0ddac715475d7ed36a15f180c755f0f978b7cf. In KDE times there were

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. In https://phabricator.kde.org/D7660#144736, @jgrulich wrote: > The bug report is not publicly available, but it was about kate not removing composed characters, while other software do that. I now checked this with LibreOffice and QtCreator and it seems to

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

alexeymin added a comment. Maybe https://phabricator.kde.org/D7700 is better? We should choose one here, I guess REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio, aacid,

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

ngraham added a comment. https://phabricator.kde.org/D7700 is definitely better. My patch here was just a quick-and-dirty way to get it quickly. We can close mine if that gets committed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks,

qqc2-desktop-style as framework

I've moved qqc2-desktop-style to frameworks from kde/workspace, please move the translations to follow Jonathan

Re: qqc2-desktop-style as framework

On Sun, Sep 10, 2017 at 3:41 PM, David Faure wrote: > Sounds OK to me, get it moved to frameworks/ so it can be included in the next > release. > > I notice there are no unittests (but that's always a bit hard for pure-gui > stuff). On the other hand, please do take a look at the

Re: qqc2-desktop-style as framework

On Mon, Sep 11, 2017 at 4:16 PM, Marco Martin wrote: > On Sun, Sep 10, 2017 at 3:41 PM, David Faure wrote: >> Sounds OK to me, get it moved to frameworks/ so it can be included in the >> next >> release. >> >> I notice there are no unittests (but that's always

Re: qqc2-desktop-style as framework

On Monday, 11 September 2017 16:18:40 CEST Jonathan Riddell wrote: > I've moved qqc2-desktop-style to frameworks from kde/workspace, please > move the translations to follow No translations to move. Ciao -- Luigi

D7771: Fix leak in autotests/ThreadWeaverQueueTests

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY QueueSignals_Private needs a virtual destructor so that when QueueSignals::~QueueSignals does delete m_d; it ends up callign the

D7771: Fix leak in autotests/ThreadWeaverQueueTests

aacid added a reviewer: mirko. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko Cc: #frameworks

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7750: fix crash when more than one instances of ExtractorCollection are destructed

mgallien updated this revision to Diff 19416. mgallien added a comment. fix another potential memory leak REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7750?vs=19415=19416 BRANCH fixPluginDelete REVISION DETAIL

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns removed a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns removed a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7774 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns created this revision. bruns added projects: Plasma, Frameworks. REVISION SUMMARY This fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt

D7699: Add support for custom search paths for application-specific syntax and theme definitions

zrax added a comment. Installing the indexer might be more useful in the custom path case, since it could be used to index bundled rules. If we just add the /syntax-extra search path and a shared library installs an index there, we'd be right back where we started with no way to bundle new

D7750: fix crash when more than one instances of ExtractorCollection are destructed

mgallien updated this revision to Diff 19415. mgallien added a comment. fix memory leak REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7750?vs=19342=19415 BRANCH fixPluginDelete REVISION DETAIL https://phabricator.kde.org/D7750 AFFECTED FILES

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is subordinate

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 Date of build: Mon, 11 Sep 2017 21:08:15 + Build duration: 3 min 31 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 11 Sep 2017 21:08:15 + Build duration: 7 min 56 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/40/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 11 Sep 2017 21:18:45 + Build duration: 3 min 24 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/40/ Project: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 Date of build: Mon, 11 Sep 2017 21:18:45 + Build duration: 2 min 20 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/74/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 11 Sep 2017 20:40:47 + Build duration: 56 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/78/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 11 Sep 2017 20:40:47 + Build duration: 4 min 35 sec and counting JUnit Tests