KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 83 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/83/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 06:33:36 + Build duration: 11 min and counting JUnit Tests

D8314: Fix deprecation warning

2017-10-16 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R39:68d42865076e: Fix deprecation warning (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8314?vs=20813=20841 REVISION DETAIL

D6665: Make kssl compile against OpenSSL 1.1.0

2017-10-16 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Now is the right time ;) REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: aacid, arojas, fvogt, ltoscano,

D8315: CMake cleanup: Don't hardcode -std=c++0x

2017-10-16 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R279:265b9f9f3120: CMake cleanup: Dont hardcode -std=c++0x (authored by kfunk). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8315?vs=20814=20840 REVISION DETAIL

D7164: KSqueezedTextLabel: Respect indent, margin and frame width

2017-10-16 Thread David Faure
dfaure added a comment. Looks like the CI issue is gone? https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/ looks green to me (well, blue, the jenkins people got daltonism issues lately). REPOSITORY R236 KWidgetsAddons REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 129 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/129/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 09:39:12 + Build duration: 18 min and counting

D8135: [FrameSvg] Optimize updateSizes

2017-10-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:dea8a1ed5f2f: [FrameSvg] Optimize updateSizes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8135?vs=20332=20851

ECM test failure on FreeBSD

2017-10-16 Thread David Faure
On samedi 9 septembre 2017 14:15:53 CEST no-re...@kde.org wrote: > URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20 > FreeBSDQt5.7/54/ Project: Frameworks extra-cmake-modules kf5-qt5 > FreeBSDQt5.7 > Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0

D7164: KSqueezedTextLabel: Respect indent, margin and frame width

2017-10-16 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D7164#156062, @dfaure wrote: > Looks like the CI issue is gone? Thanks for caring, David. Maybe I could have made this more clear, but work regarding the CI failure is tracked in https://phabricator.kde.org/T6982, were I

Re: Adding build info attribute to KAboutData to improve bug report data?

2017-10-16 Thread Kevin Funk
On Monday, 16 October 2017 07:10:29 CEST Luca Beltrame wrote: > Il giorno Sun, 08 Oct 2017 19:45:00 +0200 > > Kevin Funk ha scritto: > > Heya, > > > > The KDevelop team is currently discussing a patch which adds > > > > git-describe like information to the version string in

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 125 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/125/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Mon, 16 Oct 2017 09:39:12 + Build duration: 8 min 0 sec and counting

KDE CI: Frameworks kcodecs kf5-qt5 AndroidQt5.9 - Build # 2 - Still Failing!

2017-10-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.9/2/ Project: Frameworks kcodecs kf5-qt5 AndroidQt5.9 Date of build: Mon, 16 Oct 2017 11:27:17 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT

D8330: Open files in TagLib extractor readonly

2017-10-16 Thread David Kahles
davidk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is useful if the extractor runs sandboxed, and read-write file access is denied. TagLib would retry it readonly, but this saves one

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7 - Build # 30 - Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.7/30/ Project: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 11:28:02 + Build duration: 5 min 16 sec and counting JUnit

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 23 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/23/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Mon, 16 Oct 2017 11:30:22 + Build duration: 2 min 23 sec and counting JUnit Tests

D8330: Open files in TagLib extractor readonly

2017-10-16 Thread Matthieu Gallien
mgallien added a comment. Thanks, I tested it and it works. I am not sure about the qWarning. I would prefer another opinion on that. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8330 To: davidk, #frameworks Cc: mgallien, ngraham, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-16 Thread gregormi
gregormi added a comment. Thanks for committing, Nate. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: mak, ngraham, ltoscano, #frameworks

Python bindings using cppyy (was: An update on Python bindings)

2017-10-16 Thread Shaheed Haque
As promised, here is an interim update on the investigation into the use of cppyy-based bindings for KF5 (and more...) instead of SIP-based bindings. The first thing is that the underlying technology of cppyy, cling/ROOT, has been under development at CERN for quite a while. It directly reads

D8330: Open files in TagLib extractor readonly

2017-10-16 Thread Matthieu Gallien
mgallien added a reviewer: Frameworks. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8330 To: davidk, #frameworks Cc: ngraham, #frameworks

D8332: Added baloo urls into places model

2017-10-16 Thread Renato Oliveira Filho
renatoo planned changes to this revision. renatoo added a comment. Remove baloon dependency using KConfig API to query if it is enable, and hard-code search url with a fixed string. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo Cc: #frameworks

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Sven Brauch
brauch created this revision. brauch added reviewers: KTextEditor, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If triggerCharacters was not set, toString() would return "undefined", making

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kateindentscript.cpp:47 > > m_triggerCharactersSet = true; > But if triggerCharacters are undefined this variable should be false, no? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch,

D8334: Fix display name of Generator property

2017-10-16 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R286:16751d8e232d: Fix display name of Generator property (authored by elvisangelaccio). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8334?vs=20865=20871

D8336: Improve apidox of KJobTrackerInterface

2017-10-16 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY As discussed in https://phabricator.kde.org/D3977, document when unregisterJob()

D8334: Fix display name of Generator property

2017-10-16 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: mgallien. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use a shorter sentence (since space is limited) with Title Capitalization (since we

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Sven Brauch
brauch marked an inline comment as done. brauch added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kateindentscript.cpp:47 > But if triggerCharacters are undefined this variable should be false, no? No, that's still fine, this variable just caches reading the value from the

D7130: KMoreTools: Update and fix desktopfiles

2017-10-16 Thread Nathaniel Graham
ngraham added a comment. My pleasure. It's always nice to get bugs fixed. :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: mak, ngraham, ltoscano, #frameworks

D8334: Fix display name of Generator property

2017-10-16 Thread Matthieu Gallien
mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D8334 To: elvisangelaccio, mgallien Cc: #frameworks

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. That makes a lot of sense. Please commit. Does that fix the indentation problems reported about Python? REPOSITORY R39 KTextEditor REVISION DETAIL

D8332: Added baloo urls into places model

2017-10-16 Thread Renato Oliveira Filho
renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo Cc: ngraham, #frameworks

D8336: Improve apidox of KJobTrackerInterface

2017-10-16 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kjobtrackerinterface.h:73 > * Unregister a job from this tracker. > + * You need to manually call this method only if you re-implemented > + * registerJob() without connecting KJob::finished to this slot. Then it should be protected?

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Sven Brauch
brauch marked 2 inline comments as done. brauch added a comment. Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a moment. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch, #ktexteditor, cullmann, dhaumann Cc:

D8332: Added baloo urls into places model

2017-10-16 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 20879. renatoo added a comment. Does not load baloo urls if file index is disabled REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20873=20879 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D7130: KMoreTools: Update and fix desktopfiles

2017-10-16 Thread Christoph Feck
cfeck added a comment. This probably also fixes bug 384682. Can someone confirm? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: cfeck, mak, ngraham, ltoscano,

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix! Just one thing: could we in addition have an addition indentation test that uses the trigger chars? Its amazing we seem to have none for this as otherwise this

D8332: Added baloo urls into places model

2017-10-16 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, Dolphin, KDE Applications. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications Cc: ngraham, #frameworks

D8333: fix some indenters from randomly invoking indent

2017-10-16 Thread Sven Brauch
This revision was automatically updated to reflect the committed changes. Closed by commit R39:aeebeadb5f59: fix some indenters from indenting on random characters (authored by brauch). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8333?vs=20861=20874

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 84 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/84/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 16 Oct 2017 19:35:40 + Build duration: 8 min 15 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 130 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/130/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 17 Oct 2017 03:06:41 + Build duration: 14 min and counting

D8332: Added baloo urls into places model

2017-10-16 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 20873. renatoo added a comment. Removed baloo dependency REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20859=20873 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 126 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/126/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Tue, 17 Oct 2017 03:06:41 + Build duration: 11 min and counting JUnit

D7130: KMoreTools: Update and fix desktopfiles

2017-10-16 Thread Nathaniel Graham
ngraham added a comment. I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682. Updating that accordingly. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 24 - Still Unstable!

2017-10-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/24/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Tue, 17 Oct 2017 05:53:41 + Build duration: 4 min 45 sec and counting JUnit Tests