D7175: Redesign CMake syntax

turbov updated this revision to Diff 21207. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=18322=21207 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake.yaml data/generators/generate-cmake-syntax.py data/syntax/cmake.xml To:

D7175: Redesign CMake syntax

turbov updated this revision to Diff 21208. turbov added a comment. Include updates for CMake 3.10 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=21207=21208 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D8436: use a single QML engine

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.cpp:106 > !! right, since it keeps track of attached properties in this way, either gets changed or is not possible to use a single engine, damn :/ hmm, maybe using the rootcontext

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. Sorry but after reading what the patch does i'm not sure this makes sense. Default button just means "the button that is triggered when pressing Enter", it has nothing to do with "this is the button that should have focus". Have you talked with the usability

D7828: createKMessageBox tries to focus a default button when available

ngraham added a comment. There actually is a bug being fixed here in that currently many buttons marked default aren't actually getting made default buttons in that they turn blue and pressing enter will click them. This fixes that. REVISION DETAIL https://phabricator.kde.org/D7828 To:

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. In https://phabricator.kde.org/D7828#159054, @ngraham wrote: > There actually is a bug being fixed here in that currently many buttons marked default aren't actually getting made default buttons in that they turn blue and pressing enter will click them. This fixes

D7828: createKMessageBox tries to focus a default button when available

emateli added a comment. In my opinion a "Default" widget, should also have focus. Makes little sense to have some widget focused and then pressing enter to trigger the action of another one. By focusing, the default action is also made visible and allows to invoke the it action by

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. Sorry to be blunt, but your opinion doesn't matter. Here is the definition of the default property for a button. http://doc.qt.io/qt-5/qpushbutton.html#default-prop Nowhere in it says "this is the button that should have focus when the dialog pops up".

D7828: createKMessageBox tries to focus a default button when available

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Marking as request changes since i'd like someone with UI expertise to confirm this is what we want since from the code point of view default = focus is not what the default

D7828: createKMessageBox tries to focus a default button when available

ngraham added a comment. @aacid sorry to be unclear. To most people, the default button is the one that's visually distinct. In Breeze, that generally is the one with a blue background. Without this patch, the *actual* default button is virtually indistinguishable from other

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/132/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 24 Oct 2017 03:08:12 + Build duration: 2 min 2 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/126/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 24 Oct 2017 03:08:12 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/87/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 24 Oct 2017 03:08:48 + Build duration: 29 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/131/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 24 Oct 2017 03:09:10 + Build duration: 34 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/127/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Tue, 24 Oct 2017 03:09:10 + Build duration: 35 min and counting JUnit

D8402: Support "domain-suffix-match" in Security8021xSetting

Martchus updated this revision to Diff 21149. Martchus added a comment. Changed the method names REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21069=21149 REVISION DETAIL https://phabricator.kde.org/D8402 AFFECTED FILES

D8428: Fix cross-compiling with MinGW (MXE)

vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. looks good to me (and it compiles) REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D8428 To: vpinon, vonreth, habacker Cc: #frameworks, bartoloni, benjaminnelan,

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb marked 7 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > anthonyfieroni wrote in iokitdevice.cpp:293-294 > break after return is useless I know, I do this as a matter of principle (and I'll leave it in since I'll undoubtedly be the principal maintainer of this

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. This definitely needs another revision. Please fix the outstanding issues. INLINE COMMENTS > iokitblock.h:43 > + > +virtual int deviceMajor() const; > +virtual int

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk added inline comments. INLINE COMMENTS > iokitopticaldrive.cpp:27 > + > +#ifdef EJECT_USING_DISKARBITRATION > +// for QCFType: Where's that defined via the build system? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7401 To: rjvbb, #frameworks, kfunk Cc: kfunk,

D8243: Implement support for categories on KfilesPlacesView

renatoo marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8332: Added baloo urls into places model

renatoo added a comment. In https://phabricator.kde.org/D8332#158392, @ngraham wrote: > @dvratil, any remaining objections? This looks great to me. > > @renatoo, once this is in, can we remove the now-duplicated code from Dolphin? Yes the idea is to try to use at least the

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 21167. franckarrecot edited the summary of this revision. franckarrecot added a comment. sync summary REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21166=21167 REVISION DETAIL

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/124/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 23 Oct 2017 09:02:10 + Build duration: 43 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 130 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/130/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 23 Oct 2017 09:02:10 + Build duration: 1 min 14 sec and counting JUnit Tests

D8367: WIP: Hidding Group from KFilePlacesModel

franckarrecot updated this revision to Diff 21165. franckarrecot added a comment. Changing the way to store group states from bookmark to root propreties REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=20974=21165 REVISION DETAIL

D8367: WIP: Hidding Group from KFilePlacesModel

franckarrecot updated this revision to Diff 21166. franckarrecot added a comment. trying to make the summary changes update in phabricator REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21165=21166 REVISION DETAIL https://phabricator.kde.org/D8367

D8243: Implement support for categories on KfilesPlacesView

franckarrecot added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck,

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot retitled this revision from "WIP: Hidding Group from KFilePlacesModel" to "Hidding place groups implementation in KFilePlacesModel". franckarrecot edited the summary of this revision. franckarrecot edited the test plan for this revision. franckarrecot added a reviewer: ngraham.

D1231: Add Remote Access interface to KWayland

Kanedias added inline comments. INLINE COMMENTS > subdiff wrote in remote_access_interface.cpp:206 > Can a rogue client do it though? This would crash the server then? > Can a rogue client do it though? This would crash the server then? Yes, I guess so... What would you propose? Should we send

D1231: Add Remote Access interface to KWayland

subdiff added inline comments. INLINE COMMENTS > Kanedias wrote in remote_access_interface.cpp:206 > > Can a rogue client do it though? This would crash the server then? > > Yes, I guess so... What would you propose? Should we send it only to first > bound? Or last one? > > P.S. Even more:

D1231: Add Remote Access interface to KWayland

subdiff added inline comments. INLINE COMMENTS > remote_access_interface.cpp:206 > +// no reason for client to bind wl_output multiple times > +Q_ASSERT(boundScreens.size() == 1); > +org_kde_kwin_remote_access_manager_send_buffer_ready(res, buf->fd(), > boundScreens[0]);

D8433: Created 'shared' section

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Group all network related urls into the 'shared' section, to make it clear to the user what is access through network or not TEST PLAN

D8434: Created 'shared' section

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Group all network related urls into the 'shared' section, to make it clear to the user what is access through network or not REPOSITORY

D8434: Created 'shared' section

renatoo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo Cc: #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 21177. franckarrecot added a comment. Moving enum from item to model to avoid exposing private api REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21167=21177 REVISION DETAIL

D8434: Created 'shared' section

renatoo added reviewers: ngraham, Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: #frameworks

D8243: Implement support for categories on KfilesPlacesView

ngraham added a comment. @dfaure and @ervin, is this acceptable now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8401: fix URL detection with double urls like "http://www.foo.bar"

This revision was automatically updated to reflect the committed changes. Closed by commit R244:095a75eeb212: fix URL detection with double urls like http://www.foo.barhttp://foo.bar/; (authored by mkoller). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/53/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 23 Oct 2017 17:44:16 + Build duration: 3 min 9 sec and counting JUnit

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

abetts added a comment. Can you guys add a quick picture of what this looks like right now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

D8416: really raising window when shown from systray

mkoller added inline comments. INLINE COMMENTS > graesslin wrote in kstatusnotifieritem.cpp:653 > It only works on X11 because KWin has a bug. KWin allows the force (which is > in X11 Terms a "from tool" request) without checking who sends it. I will > look into hardening this in KWin. Then

D8416: really raising window when shown from systray

graesslin added inline comments. INLINE COMMENTS > mkoller wrote in kstatusnotifieritem.cpp:653 > "without checking who sends it" > > Who shall be allowed to do so ? > > As said, the original problem is that a click in SysTray does not raise it, > but as I understand it, the

D8437: KWidgetsAddons : more compact password dialog

rjvbb added a comment. > Is this change intended? I doubt that (it's been a while). Probably something Designer added, and I can't imagine it would have an impact on packing. I'll check. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb,

D1231: Add Remote Access interface to KWayland

subdiff added a task: T5653: [kwin] Screen recording in Wayland session. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. Sounds great, thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8433: Created 'shared' section

renatoo added a comment. In https://phabricator.kde.org/D8433#158886, @ngraham wrote: > Looks like this was opened by accident; can you abandon it? No this is a valid change? I would like to proposal that one. :D REPOSITORY R241 KIO REVISION DETAIL

D8436: use a single QML engine

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY use a shared qml engine for all ConfigModules in the same process this avoids some crashes

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

cfeck added inline comments. INLINE COMMENTS > kio_smb_browse.cpp:521 > > +bool SMBSlave::workaroundEEXIST(const int errNum) const > +{ While it does no harm, you do not need 'const' for plain types, such as 'int'. REPOSITORY R320 KIO Extras REVISION DETAIL

D8433: Created 'shared' section

ngraham added a comment. Looks like this was opened by accident; can you abandon it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8433 To: renatoo Cc: ngraham, #frameworks

D8436: use a single QML engine

davidedmundson added inline comments. INLINE COMMENTS > configmodule.cpp:106 > { > ConfigModulePrivate::s_rootObjects.remove(d->_qmlObject->engine()); > !! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8436 To: mart, #plasma Cc:

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. @simgunz, have you had a chance to try implementing David's suggestion? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8437: KWidgetsAddons : more compact password dialog

cfeck added inline comments. INLINE COMMENTS > kpassworddialog.ui:137 > + > + true > + Is this change intended? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks Cc: cfeck, ngraham

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/125/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 23 Oct 2017 17:09:46 + Build duration: 38 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 131 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/131/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 23 Oct 2017 17:09:46 + Build duration: 1 min 31 sec and counting JUnit Tests

D8402: Support "domain-suffix-match" in Security8021xSetting

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good to go. Thank you. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks,

D8416: really raising window when shown from systray

graesslin added inline comments. INLINE COMMENTS > mkoller wrote in kstatusnotifieritem.cpp:653 > I'm a bit confused now. > The patch solves my issue for X11 as it does some lines below already, but > you say that this is wrong for Wayland but a solution for wayland does not > exist right now.

D8402: Support "domain-suffix-match" in Security8021xSetting

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Now it looks good. Just one thing I forgot is a unit test for this property. You can add it to autotests/settings/8021xsettingtest.cpp and build the tests with

D8402: Support "domain-suffix-match" in Security8021xSetting

Martchus updated this revision to Diff 21153. Martchus added a comment. Add "domainSuffixMatch" to auto tests REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21149=21153 REVISION DETAIL https://phabricator.kde.org/D8402 AFFECTED FILES

D7033: Port ki18n from QtScript to QtQml

carewolf added a comment. No, but I will see if I can find some. Otherwise feel free to take over an fix the remaining issues. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: ngraham, dhaumann, ltoscano, kfunk, #frameworks

D8437: KWidgetsAddons : more compact password dialog

rjvbb created this revision. rjvbb added a reviewer: Frameworks. rjvbb added a project: Frameworks. REVISION SUMMARY When kwalletd4 was replaced by kwalletd5 I quickly got annoyed by the so much and unnecessarily larger password dialog. This patch addresses that issues, maing the dialog

D8437: KWidgetsAddons : more compact password dialog

rjvbb added a comment. Screenshots attached to the bug report I filed about this (https://bugs.kde.org/show_bug.cgi?id=381231): Before: F5445829: kwallet-pw-dialog.png After (packed): F5445832: kwallet-pw-dialog-packed.png

D8437: KWidgetsAddons : more compact password dialog

ngraham added a comment. Fantastic. Can you add the following onto its own line in the Summary section? "BUG: 381231" That will cause that bug to get automatically closed once this is merged. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To:

D8433: Created 'shared' section

renatoo abandoned this revision. renatoo added a comment. In https://phabricator.kde.org/D8433#158886, @ngraham wrote: > Looks like this was opened by accident; can you abandon it? Ok sorry did not notice that two merge reguest was creted. REPOSITORY R241 KIO REVISION DETAIL

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb marked 27 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > kfunk wrote in iokitblock.h:43 > Here and below: Missing `Q_DECL_OVERRIDE` I hope you meant everywhere, including in old code... > kfunk wrote in iokitdevice.cpp:156 > `new`/`delete` mismatch. Use

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb updated this revision to Diff 21187. rjvbb marked 7 inline comments as done. rjvbb added a comment. Updated as requested/discussed. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7401?vs=18366=21187 REVISION DETAIL https://phabricator.kde.org/D7401 AFFECTED FILES

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb set the repository for this revision to R245 Solid. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7401 To: rjvbb, #frameworks, kfunk Cc: kfunk, anthonyfieroni, cgilles, kde-mac

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. In https://phabricator.kde.org/D8056#158939, @ngraham wrote: > @simgunz, have you had a chance to try implementing David's suggestion? Yes. Everything seems to work but I haven't pushed yesterday because I wanted to do an extra test. The current

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

madcatx added inline comments. INLINE COMMENTS > cfeck wrote in kio_smb_browse.cpp:521 > While it does no harm, you do not need 'const' for plain types, such as 'int'. Don't worry, I'm well aware. I however like to use consts wherever possible to make it clear that changing a value of such