D7810: Add missing icon sizes

hein added inline comments. INLINE COMMENTS > index.theme:297 > MinSize=32 > -MaxSize=48 > +MaxSize=32 > Hmm why lower this one: REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham Cc: hein,

D7810: Add missing icon sizes

jensreuterberg added a subscriber: andreask. jensreuterberg added a comment. Well the issue is that they are not "scalable" - I mean the goal should rather be to make them functionable on all sizes but being SVG's means that they may become misaligned when rendered. (Ie if you make an icon

D8546: Add Aztec code generator

lbeltrame added reviewers: Frameworks, svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D8546 To: vkrause, #frameworks, svuorela Cc: #frameworks

D8243: Implement support for categories on KfilesPlacesView

renatoo added a comment. Guys, is that ready? Do you need any other change/fix? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

KDE CI: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.9/1/ Project: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 Date of build: Mon, 30 Oct 2017 13:20:06 + Build duration: 59 sec and counting CONSOLE OUTPUT

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent added a comment. it depends against https://phabricator.kde.org/D8348 too REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, mlaurent, ngraham Cc: ngraham, mlaurent, #frameworks

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

ngraham added a comment. Michal, I don't know how familiar you are with the Samba codebase, but it looks like another user has a proposal for fixing the issue in https://bugzilla.samba.org/show_bug.cgi?id=13050. Are you able to test that and submit a patch to them? IMHO we should

KDE CI: Frameworks kcompletion kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20AndroidQt5.9/1/ Project: Frameworks kcompletion kf5-qt5 AndroidQt5.9 Date of build: Mon, 30 Oct 2017 13:20:08 + Build duration: 1 min 27 sec and counting

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent added a comment. it depends against https://phabricator.kde.org/D8332.diff too REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, mlaurent, ngraham Cc: ngraham, mlaurent, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent added a comment. depend against https://phabricator.kde.org/D8366 too... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, mlaurent, ngraham Cc: ngraham, mlaurent, #frameworks

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

madcatx added a comment. What is the status on upstreaming this? Is there anything else you need from me to finish this off? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8387 To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks Cc: cfeck,

D8348: Add a section for removable devices

mlaurent added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks

D8243: Implement support for categories on KfilesPlacesView

renatoo added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesmodel.cpp:476 > Either reorder the enum or change for a different (more explicit not relying > on enum storage) comparison operator to have the "right" order. By right > order I assume the goal was to align with Dolphin

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent commandeered this revision. mlaurent edited reviewers, added: franckarrecot; removed: mlaurent. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: mlaurent, renatoo, ngraham, franckarrecot Cc: ngraham, mlaurent, #frameworks

D8243: Implement support for categories on KfilesPlacesView

ervin added a comment. Looks fine code wise now, just a couple more tweaks to make those sections look closer to what Dolphin got. INLINE COMMENTS > kfileplacesmodel.cpp:476 > +[](KFilePlacesItem *itemA, KFilePlacesItem *itemB) { > + return (itemA->groupType() <

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent updated this revision to Diff 21572. mlaurent added a comment. We can't use qAsConst as it's a qt5.8 macro. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21290=21572 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECTED FILES

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent edited the summary of this revision. mlaurent added dependencies: D8366: Factoring out lists of url data within KFilePlacesModelTest, D8348: Add a section for removable devices, D8332: Added baloo urls into places model. REVISION DETAIL https://phabricator.kde.org/D8367 To:

D8332: Added baloo urls into places model

mlaurent added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham Cc: usta, mlaurent, dvratil, ngraham,

D7828: fix createKMessageBox focus widget inconsistency

aacid resigned from this revision. aacid added a comment. This revision is now accepted and ready to land. This change is much less invasive than before, i'm not giving a +1 since i don't immediately understand why this fixes things and since i don't have time to investigate it, i'm removing

D7828: fix createKMessageBox focus widget inconsistency

emateli retitled this revision from "fix createKMessageBox focus button inconsistency" to "fix createKMessageBox focus widget inconsistency". REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx Cc: elvisangelaccio, rkflx, abetts, subdiff,

D7828: fix createKMessageBox focus button inconsistency

emateli retitled this revision from "createKMessageBox tries to focus a default button when available" to "fix createKMessageBox focus button inconsistency". emateli edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham,

D7828: fix createKMessageBox focus widget inconsistency

ngraham set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21590. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. 1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the tags KIO

D7828: fix createKMessageBox focus widget inconsistency

ngraham added a comment. Thanks @aacid. Any remaining objections to landing this? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid,

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21599. smithjd added a comment. - Create a full url instead of only a path. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21590=21599 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8527: Display "Downloaded From" by default, if file supports it

ngraham added a comment. Do any Dolphin people object? If not, I'll land this in a few days (sooner if I get some more thumbs up :) ). REPOSITORY R824 Baloo Widgets BRANCH origin_url_386261 REVISION DETAIL https://phabricator.kde.org/D8527 To: ngraham, #dolphin, #frameworks,

D8528: Consider DjVu files to be documents

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2e80367435cc: Consider DjVu files to be documents (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8528?vs=21461=21597#toc REPOSITORY R293 Baloo CHANGES SINCE LAST

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/36/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Tue, 31 Oct 2017 02:26:30 + Build duration: 3 min 39 sec and counting JUnit Tests

Re: Frameworks release schedule?

El dijous, 26 d’octubre de 2017, a les 11:52:39 CET, laurent Montel va escriure: > Le jeudi 26 octobre 2017, 01:19:02 CEST Valorie Zimmerman a écrit : > > On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote: > > > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel

Re: Buddies/Tabstops in designer for aggregated KDE widgets?

El dissabte, 28 d’octubre de 2017, a les 19:14:26 CET, David Faure va escriure: > On dimanche 24 septembre 2017 23:16:27 CEST Albert Astals Cid wrote: > > El diumenge, 24 de setembre de 2017, a les 14:55:37 CEST, Milian Wolff va > > > > escriure: > > > Hey all, > > > > > > I'm trying to get set

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21584. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21296=21584 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8243: Implement support for categories on KfilesPlacesView

renatoo marked 3 inline comments as done. renatoo added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesmodel.cpp:476 > Either reorder the enum or change for a different (more explicit not relying > on enum storage) comparison operator to have the "right" order. By right > order I

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21583. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21227=21583 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D8434: Created 'shared' section

renatoo updated this revision to Diff 21585. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21297=21585 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8243: Implement support for categories on KfilesPlacesView

renatoo updated this revision to Diff 21582. renatoo added a comment. Updated visuals to match dolphin REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=21226=21582 REVISION DETAIL https://phabricator.kde.org/D8243 AFFECTED FILES

D8434: Created 'shared' section

ngraham added a comment. +1 for the idea! Needs more screenshots. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks