D8084: KAutoSaveFile breaks if source file name contains a space!

mardelle marked 2 inline comments as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8084 To: mardelle, #frameworks, shaforostoff Cc: dfaure, ngraham, cfeck, ltoscano

D8590: KPageListView: Update width on font change

ngraham added reviewers: dfaure, rkflx, broulik. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8590 To: volkov, cfeck, wojnilowicz, dfaure, rkflx, broulik Cc: #frameworks

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

ngraham added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8649 To: genethomas, #framework_syntax_highlighting Cc: #frameworks

D8084: KAutoSaveFile breaks if source file name contains a space!

mardelle updated this revision to Diff 21868. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8084?vs=20216=21868 REVISION DETAIL https://phabricator.kde.org/D8084 AFFECTED FILES autotests/kautosavefiletest.cpp src/lib/io/kautosavefile.cpp To:

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio Cc: ltoscano, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

abetts added a comment. In https://phabricator.kde.org/D8056#164287, @ngraham wrote: > I would say make the categories disappear as soon as that view displays search results. Yeah, because in the end, when you want to narrow down the results, the categories will get in your way

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. @simgunz have you had a chance to work on @dfaure's comments? It would be great to get this in. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc:

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz marked 9 inline comments as done. simgunz added a comment. I fixed most of them. I think I'll have time tomorrow. INLINE COMMENTS > dfaure wrote in kopenwithdialog.cpp:398 > Ah. Filipe and I implemented recursive filtering in QSortFilterProxyModel but > that's only in Qt 5.10. Too

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

abetts added a comment. Can I suggest to maybe simplify even a little more and remove the category separators? AKA, system, internet? REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Can you be more specific? Currently, the categories are expanded automatically after 3 characters have been typed. Do you want to make the categories disappear at this point? Or not having them from the beginning? REPOSITORY R241 KIO BRANCH

D8652: Add supported transformations to OutputDevice

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The server can announce all supported transformations on an

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

ngraham updated this revision to Diff 21871. ngraham added a comment. Improve comment for clarity REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7423?vs=18418=21871 BRANCH arcpatch-D7423 REVISION DETAIL https://phabricator.kde.org/D7423 AFFECTED FILES

D8652: Add supported transformations to OutputDevice

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:470 > we have the initial send which is all fine > > Then you've got this dynamically add them. > But at a protocol level we have no way to remove and replace. > That's somewhat broken. > >

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. In https://phabricator.kde.org/D8056#164283, @abetts wrote: > Can I suggest to maybe simplify even a little more and remove the category separators? AKA, system, internet? +1 totally agree. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8652: Add supported transformations to OutputDevice

davidedmundson added inline comments. INLINE COMMENTS > outputdevice.xml:225 > + > + > + enum="transform" also uint > outputdevice_interface.cpp:470 > > +void OutputDeviceInterface::addSupportedTransformation(Transform > transformation) > +{ we have the initial send

Re: Python bindings using cppyy (was: An update on Python bindings)

Wim, Philipp, On 4 November 2017 at 16:45, Philipp A. wrote: > Hi Wim! > >> So now I have a (C++) namespace 'A' that bears no relationship to anything >> to do with the file system or any type of Python packaging: it exists only >> in memory for the duration of the python

D8652: Add supported transformations to OutputDevice

graesslin updated this revision to Diff 21872. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. enum and uint REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8652?vs=21869=21872 BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. I would say make the categories disappear as soon as that view displays search results. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: subdiff,

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/55/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 05 Nov 2017 03:40:51 + Build duration: 19 min and counting JUnit

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

cfeck added a comment. Would this fix be eligible for 'Applications/17.08' branch? If yes, please backport/commit in the next 48 hours. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8387 To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks Cc:

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

ngraham added a comment. Since it's a bugfix, and a high-impact one, I think so. I'll cherry-pick it. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8387 To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks Cc: cfeck, rdieter, graesslin, z3ntu

D7787: Set KPageListView width properly

wojnilowicz added a comment. In https://phabricator.kde.org/D7787#162826, @volkov wrote: > Could you try to test it without + 5 and with the following change applied? > https://phabricator.kde.org/D8590 ? Without +5 and with https://phabricator.kde.org/D8590 horizontal

D8648: crk.xml: add header line

genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY crk.xml: add header line it broke my xerces sax xml parser TEST PLAN load into my editor which reads KDE syntax highlighting .xml

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - comments are not correctly detected in 3 of the 4 sql .xml syntax definitions TEST PLAN load a test.sql file into my editor which

D8651: cs,xml: added support for @ verbatim strings

genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fix may have been submitted already via GitHub? In C# @"strings" can span multiple lines, do not \ escape chars and escape "

D8330: Open files in TagLib extractor readonly

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. If other extractors are already doing that,I guess it is good enough for now. I guess somebody may one day come up with better error logging (i.e. the user can discover it).

KDE CI: Frameworks kdesignerplugin kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20WindowsMSVCQt5.9/10/ Project: Frameworks kdesignerplugin kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 04 Nov 2017 21:40:58 + Build duration: 2 hr 1 min and counting

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 - Build # 12 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/12/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 04 Nov 2017 21:46:14 + Build duration: 2 hr 59 min and counting

KDE CI: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20WindowsMSVCQt5.9/10/ Project: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 04 Nov 2017 21:48:52 + Build duration: 3 hr 25 min and counting

Re: Python bindings using cppyy (was: An update on Python bindings)

There is a POC-quality implementation of the integration with KDE here: https://cgit.kde.org/pykde5.git/tree/?h=srhaque-cppyy-bindings=19a94fb3ae2b40a985913ed4e49400e02df56dc2 This contains examples of bindings for Akonadi and KDcraw. My next steps will be to do a few more, and then move on to

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 60 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/60/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:39:39 + Build duration: 9 min 42 sec and counting JUnit

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/26/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:42:05 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/56/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:39:39 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks kpackage kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:46:45 + Build duration: 16 min and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/136/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:44:30 + Build duration: 34 min and counting JUnit Tests

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi Wim! So now I have a (C++) namespace 'A' that bears no relationship to anything > to do with the file system or any type of Python packaging: it exists only > in memory for the duration of the python session. > Yeah, cool, so we just use a path hook and are ready to go right?

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/37/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:46:45 + Build duration: 40 min and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/28/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:47:33 + Build duration: 44 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/130/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:44:15 + Build duration: 53 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/55/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:49:22 + Build duration: 57 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/137/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:51:07 + Build duration: 1 hr 2 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 131 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/131/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 22:37:59 + Build duration: 25 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:35:24 + Build duration: 8 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.9/3/ Project: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 Date of build: Sat, 04 Nov 2017 21:45:10 + Build duration: 1 min 25 sec and counting CONSOLE

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:39:49 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks kimageformats kf5-qt5 XenialQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20XenialQt5.7/12/ Project: Frameworks kimageformats kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:43:48 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/54/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 04 Nov 2017 21:40:45 + Build duration: 26 min and counting JUnit

KDE CI: Frameworks krunner kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks krunner kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:48:02 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/129/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:44:15 + Build duration: 25 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks kservice kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:48:12 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/56/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:49:22 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/133/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:51:07 + Build duration: 26 min and counting JUnit

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 21:49:47 + Build duration: 27 min and counting JUnit Tests

D8643: Fix display of remote:/ in the qfiledialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:72c81e41aac1: Fix display of remote:/ in the qfiledialog (authored by apol). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8643?vs=21845=21883 REVISION DETAIL

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi Shaheed, Thank you for the clarifications! My observation is that *nobody* is likely to help with that problem: the > framework owners did > nothing obvious to either keep PyKDE4 going (out of tree) or to help > Steve with my earlier SIP based efforts (in tree). > It's a bit sad, but not too

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/130/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Sat, 04 Nov 2017 22:27:04 + Build duration: 7 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.9/10/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 04 Nov 2017 21:38:16 + Build duration: 1 hr 12 min and counting