D8780: Try `llvm-config` to find `libclang`

2017-11-12 Thread Alex Turbov
turbov created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY The current way to search for `libclang` doesn't work for me (Gentoo with clang 4 and 5 installed). Instead of

D8781: Add *.email to extensions for emails

2017-11-12 Thread Gene Thomas
genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY .email is the sensible filename extension for storing email. There is no longer a 3 character limit. I wrote a tool that backs up

D8781: Add *.email to extensions for emails

2017-11-12 Thread Gene Thomas
genethomas abandoned this revision. genethomas added a comment. phabricator ignored my pastes in diff and has diffed CMakeLists.txt :o( REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8781 To: genethomas Cc: #frameworks

D8782: add *.email to the extensions

2017-11-12 Thread Gene Thomas
genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY .email is the sensible filename extension for storing email. There is no longer a 3 character limit. I wrote a tool that backs up

D8780: Try `llvm-config` to find `libclang`

2017-11-12 Thread Shaheed Haque
shaheed added a comment. I'm afraid your's truly might take a bit of the blame. The basis of the logic was likely my original Python code, which did just enough to make Ubuntu work. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8780 To: turbov Cc:

D5037: KTextEditor: prevent accidental zooming

2017-11-12 Thread René J . V . Bertin
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f51befdc80b1: prevent accidental zooming. (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5037?vs=15747=22232#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 98 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/98/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 16:54:05 + Build duration: 8 min 4 sec and counting JUnit Tests

D5037: KTextEditor: prevent accidental zooming

2017-11-12 Thread Christoph Cullmann
cullmann added a comment. Given people seem to have tested this, I would be ok to let it go in now. I guess we need some "user-test" for it anyways. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5037 To: rjvbb, #ktexteditor Cc: cullmann, ngraham, kfunk,

D5037: KTextEditor: prevent accidental zooming

2017-11-12 Thread René J . V . Bertin
rjvbb added a comment. Thanks. I've been using this patch myself and never noticed any side-effects. Except when an application shows to be susceptible to accidental zooming ... because it uses another widget class that doesn't have this protection :) REPOSITORY R39 KTextEditor

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 97 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/97/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 16:36:41 + Build duration: 9 min 26 sec and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 97 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/97/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 16:36:41 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 98 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/98/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 16:46:17 + Build duration: 9 min 46 sec and counting JUnit

D7810: Add missing icon sizes

2017-11-12 Thread mandian
mandian added a comment. Even if simplified icons may look better with small size I did not notice any fuzzy effects in smaller icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein

D7175: Redesign CMake syntax

2017-11-12 Thread Alex Turbov
turbov updated this revision to Diff 6. turbov edited the summary of this revision. turbov added a comment. Updated for CMake 3.10 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=21208=6 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio added a comment. Screenshot: F5488679: Screenshot_20171112_115923.png REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, VDG, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Drag-and-drop of toolbar actions is a nice feature that currently is basically hidden to end users. The only way to enable it

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio added a dependent revision: D8774: Show Configure Toolbars dialog as modal. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Aleix Pol Gonzalez
apol added a comment. Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable? INLINE COMMENTS > ktoolbar.cpp:410 > > +contextEditableAction.reset(new > KToggleAction(QIcon::fromTheme(QStringLiteral("document-edit")), >

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-12 Thread Volker Krause
vkrause updated this revision to Diff 5. vkrause added a comment. Integrate review feedback. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7274?vs=18053=5 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D7274 AFFECTED FILES

D7810: Add missing icon sizes

2017-11-12 Thread Eike Hein
hein accepted this revision. hein added a comment. Same. Do you need someone to commit this for you or do you have access? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein Cc:

D7810: Add missing icon sizes

2017-11-12 Thread Jens Reuterberg
jensreuterberg added a comment. Just as a heads up, check whether the icons become fuzzy in certain sizes on Mate for example REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein Cc:

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY The "Configure Toolbars" dialog was made non-modal a long time ago [1] in order to allow drag-and-drop of toolbar actions while the

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D8773#166734, @apol wrote: > Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable? No, "unlocking" means you can drag the whole toolbar, e.g. from the top to the

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2017-11-12 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 9. kossebau added a comment. Update: add some API dox, more API fine-tuning REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=22055=9 BRANCH addAnnotationItemDelegate REVISION DETAIL

D8710: Fix VI-Mode buffer commands

2017-11-12 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. The single shots are not that nice, but I understand that they are necessary to defer the action. Feel free to commit. REPOSITORY R39 KTextEditor BRANCH viedit REVISION DETAIL

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Thomas Pfeiffer
colomar added a comment. Why don't we do this the way Firefox does it: Have a menu entry that puts the whole UI in config mode. That works far better then trying to make each individual config feature discoverable. REPOSITORY R263 KXmlGui REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 41 - Fixed!

2017-11-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/41/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:30:55 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 29 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/29/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:39:03 + Build duration: 6 min 19 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 136 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/136/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:41:10 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 136 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/136/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:48:32 + Build duration: 22 min and counting JUnit

KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 32 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks kservice kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:45:21 + Build duration: 20 min and counting JUnit Tests

Re: Making Purpose part of KF5

2017-11-12 Thread Albert Astals Cid
El dijous, 9 de novembre de 2017, a les 17:10:28 CET, Aleix Pol va escriure: > Hi, > I would like to include Purpose [1] into the frameworks umbrella. > It's been around for a while now, used by few applications and > reasonably stable. > > Any thoughts? Given that now Okular optionally uses it,

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread David Faure
dfaure added a comment. I like the idea. I'm just not sure about the exact wording of the action, but I'll let the VDG decide on that. INLINE COMMENTS > apol wrote in ktoolbar.cpp:410 > Isn't it better to set a parent like for the other ona than use the > QScopedPointer? I'm also

KDE CI: Frameworks kactivities-stats kf5-qt5 XenialQt5.7 - Build # 24 - Failure!

2017-11-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kactivities-stats%20kf5-qt5%20XenialQt5.7/24/ Project: Frameworks kactivities-stats kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:30:16 + Build duration: 1 min 11 sec and counting

KDE CI: Frameworks kactivities kf5-qt5 XenialQt5.7 - Build # 23 - Fixed!

2017-11-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20XenialQt5.7/23/ Project: Frameworks kactivities kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:30:31 + Build duration: 2 min 0 sec and counting JUnit Tests

D8767: Fix translation of toolbar name when it has i18n context

2017-11-12 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH toolbar-i18n-with-ctxt REVISION DETAIL https://phabricator.kde.org/D8767 To: aspotashev, dfaure, apol Cc: #frameworks

KDE CI: Frameworks kactivities-stats kf5-qt5 XenialQt5.7 - Build # 25 - Fixed!

2017-11-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities-stats%20kf5-qt5%20XenialQt5.7/25/ Project: Frameworks kactivities-stats kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:31:28 + Build duration: 1 min 35 sec and counting

KDE CI: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 - Build # 4 - Still Failing!

2017-11-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.9/4/ Project: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 Date of build: Sun, 12 Nov 2017 18:42:08 + Build duration: 1 min 26 sec and counting CONSOLE

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.9 - Build # 4 - Still Failing!

2017-11-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.9/4/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.9 Date of build: Sun, 12 Nov 2017 18:43:42 + Build duration: 45 sec and counting CONSOLE OUTPUT

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-12 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH pending REVISION DETAIL https://phabricator.kde.org/D7274 To: vkrause, #frameworks, cordlandwehr, apol Cc: apol

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8767: Fix translation of toolbar name when it has i18n context

2017-11-12 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > ktoolbarhelper.cpp:32 > +const QVector textKeys = {QStringLiteral("text"), > QStringLiteral("Text")}; > +for (const QString key : textKeys) { > +QDomNode textNode = element.namedItem(key); const

D8173: Use readelf to find project dependencies

2017-11-12 Thread Albert Astals Cid
aacid added a comment. I'm still not getting libkconfigcore.so into the apk with this REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8173 To: apol, #frameworks, #build_system, aacid Cc: mart

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 62 - Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/62/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:36:31 + Build duration: 6 min 21 sec and counting JUnit

KDE CI: Frameworks kcrash kf5-qt5 XenialQt5.7 - Build # 21 - Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks kcrash kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:36:44 + Build duration: 7 min 8 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 32 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks kpackage kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:43:42 + Build duration: 15 min and counting JUnit Tests

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Andres Betts
abetts added a comment. My perspective here is that instead of using an actual checkbox to enable the dragging, I would create visual handles instead. Maybe something like this: F5489078: Group.png Why? Because checkboxes generally don't

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 - Build # 25 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/25/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:36:44 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 58 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/58/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:36:32 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 XenialQt5.7 - Build # 32 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks krunner kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:45:08 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 57 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/57/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:46:33 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.9 - Build # 11 - Fixed!

2017-11-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20WindowsMSVCQt5.9/11/ Project: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 12 Nov 2017 18:46:07 + Build duration: 2 hr 39 min and counting

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure Cc: ngraham, colomar, abetts, apol

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio marked 2 inline comments as done. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure Cc: ngraham, colomar, abetts, apol

D8767: Fix translation of toolbar name when it has i18n context

2017-11-12 Thread Alexander Potashev
aspotashev updated this revision to Diff 22243. aspotashev added a comment. const QString REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8767?vs=22207=22243 BRANCH toolbar-i18n-with-ctxt REVISION DETAIL https://phabricator.kde.org/D8767 AFFECTED

D8767: Fix translation of toolbar name when it has i18n context

2017-11-12 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R263:17eeaf00b651: Fix translation of toolbar name when it has i18n context (authored by aspotashev). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8767?vs=22243=22244

D8777: restore old behaviour of FindPulseAudio

2017-11-12 Thread Johannes Hirte
jhirte updated this revision to Diff 22242. jhirte added a comment. v2 of the patch with comments from Christophe Giboudeaux considered REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8777?vs=22240=22242 REVISION DETAIL

D8767: Fix translation of toolbar name when it has i18n context

2017-11-12 Thread Alexander Potashev
aspotashev marked an inline comment as done. REPOSITORY R263 KXmlGui BRANCH toolbar-i18n-with-ctxt REVISION DETAIL https://phabricator.kde.org/D8767 To: aspotashev, dfaure, apol Cc: #frameworks

D8777: restore old behaviour of FindPulseAudio

2017-11-12 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Please commit after fixing the last issue. INLINE COMMENTS > FindPulseAudio.cmake:123 > > -mark_as_advanced(PulseAudio_INCLUDE_DIRS PulseAudio_INCLUDE_DIR > -

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 39 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:47:03 + Build duration: 30 min and counting JUnit Tests

D7810: Add missing icon sizes

2017-11-12 Thread Nathaniel Graham
ngraham added a comment. I can commit this. @mandian, can you provide a full name? As for an email address, is mand...@openmailbox.org good? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham,

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 140 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/140/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:41:24 + Build duration: 42 min and counting JUnit Tests

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D8773#166846, @colomar wrote: > Why don't we do this the way Firefox does it: Have a menu entry that puts the whole UI in config mode. > That works far better then trying to make each individual config feature

D7810: Add missing icon sizes

2017-11-12 Thread Jens Reuterberg
jensreuterberg added a comment. Cool! Just please keep an eye out. Pixel-aligning icons is a PITA but worthwhile so if there is something that ends up blurry please ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg,

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 38 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/38/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:43:42 + Build duration: 52 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 137 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/137/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:41:10 + Build duration: 1 hr 5 min and counting JUnit Tests Name:

KDE CI: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.7 - Build # 23 - Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.7/23/ Project: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:46:07 + Build duration: 1 hr 3 min and counting

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 99 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/99/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:45:38 + Build duration: 1 hr 11 min and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 56 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/56/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:46:33 + Build duration: 1 hr 17 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 140 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/140/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:48:32 + Build duration: 1 hr 31 min and counting

D8710: Fix VI-Mode buffer commands

2017-11-12 Thread Christoph Roick
This revision was automatically updated to reflect the committed changes. Closed by commit R39:62e4c17cbc79: Fix VI-Mode buffer commands (authored by croick). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8710?vs=22057=22239 REVISION DETAIL

D8710: Fix VI-Mode buffer commands

2017-11-12 Thread Christoph Roick
croick added a comment. In https://phabricator.kde.org/D8710#166793, @cullmann wrote: > The single shots are not that nice, but I understand that they are necessary to defer the action. At first I changed the invokeMethod arguments in utils/application.cpp to

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 100 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/100/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 20:41:06 + Build duration: 7 min 34 sec and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 100 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/100/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 20:41:06 + Build duration: 12 min and counting JUnit Tests

D8777: restore old behaviour of FindPulseAudio

2017-11-12 Thread Christophe Giboudeaux
cgiboudeaux added a comment. you also need set(PULSEAUDIO_FOUND "${PulseAudio_FOUND}"). You then have to move the compat variables below "find_package_handle_standard_args". Please also fix the mark_as_advanced() line to match the renamed vars. REPOSITORY R240 Extra CMake Modules

D8773: Improve discoverability of drag-and-drop of toolbar actions

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 22241. elvisangelaccio added a comment. - Implement a global 'edit mode' that enables both kind of drags (whole toolbar + actions within the toolbar). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 56 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/56/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:37:40 + Build duration: 40 min and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 99 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/99/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 18:45:38 + Build duration: 33 min and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 29 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/29/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:44:38 + Build duration: 55 min and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 34 - Still Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/34/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:45:08 + Build duration: 57 min and counting JUnit Tests

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 38 - Unstable!

2017-11-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/38/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 18:47:03 + Build duration: 1 hr 27 min and counting JUnit

D8698: Fix KProtocoInfoTest if krusader is installed

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio retitled this revision from "Fix KProtolInfoTest if krusader is installed" to "Fix KProtocoInfoTest if krusader is installed". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8698 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks

D8777: restore old behaviour of FindPulseAudio

2017-11-12 Thread Johannes Hirte
jhirte created this revision. jhirte added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Commit https://phabricator.kde.org/R240:ee5b036c1df4776a258c0d8067fd2eaf18875829 added

D8546: Add Aztec code generator

2017-11-12 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. I like it. Though I haven't fully reviewed the bit magic and actually tested it, but the first can be fixed at a later point, and the latter I trust you on. INLINE COMMENTS > vkrause wrote in aztec-compact-data-0011.png:1 > There