emateli added a comment.
Ping. Thoughts on the last comment?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks, dfaure
Cc: #frameworks
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in udisksdevicebackend.cpp:67
> Similar code in different place had a comment
>
> // Delay connecting to DBus signals to avoid the related time penalty
> // in hot paths such as predicate matching
Never trust existing
broulik added inline comments.
INLINE COMMENTS
> apol wrote in udisksdevicebackend.cpp:67
> What do we gain by delaying dbus connection?
Similar code in different place had a comment
// Delay connecting to DBus signals to avoid the related time penalty
// in hot paths such as predicate
apol updated this revision to Diff 23202.
apol added a comment.
Move to tracking parents instead of doing a look-up on every color get
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8917?vs=22664=23202
BRANCH
master
REVISION DETAIL
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D9086
To: broulik, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Calling KGlobalAccel::setDefaultShortcut would do few blocking calls one after
the other.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9092
To: apol, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kparts kf5-qt5 SUSEQt5.10
Date of build:
Fri, 01 Dec 2017 19:34:41 +
Build duration:
11 min and counting
JUnit Tests
Name: (root)
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
fix_strict_compile
REVISION DETAIL
https://phabricator.kde.org/D9049
To: mlaurent, dfaure
Cc: apol, #frameworks
graesslin accepted this revision.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9092
To: apol, #frameworks, #plasma, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol,
Git commit 6c9111a952fb7c70c864b663d25080e418a0222c by Ben Cooksley.
Committed on 01/12/2017 at 19:29.
Pushed by bcooksley into branch 'master'.
The usermetadatawritertest requires Taglib.
Therefore if Taglib isn't around, we shouldn't try to build something that
requires it.
This fixes the
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/19/
Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 01 Dec 2017 19:30:20 +
Build duration:
3 min 59 sec and counting
apol updated this revision to Diff 23233.
apol added a comment.
Fix david's comment
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8917?vs=23202=23233
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8917
AFFECTED FILES
On Thu, Nov 30, 2017 at 10:16 PM, Ralf Habacker
wrote:
> Am 30.11.2017 um 21:21 schrieb Aleix Pol:
>> Hi,
>> Recently I put together some CI for Android, where some frameworks are
>> being checked to _build_ for Android + ARM.
>>
>> Now there's many frameworks that can't
Am 01.12.2017 um 21:27 schrieb Aleix Pol:
> On Thu, Nov 30, 2017 at 10:16 PM, Ralf Habacker
> wrote:
>> Am 30.11.2017 um 21:21 schrieb Aleix Pol:
>>> Hi,
>>> Recently I put together some CI for Android, where some frameworks are
>>> being checked to _build_ for Android +
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Explains which service file it's actually describing
REPOSITORY
R309 KService
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9085
AFFECTED
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.7/22/
Project:
Frameworks kdnssd kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 01 Dec 2017 12:47:44 +
Build duration:
2 min 26 sec and counting
CONSOLE OUTPUT
broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We know how many items we're going to add to the vector.
REPOSITORY
R278
broulik edited the test plan for this revision.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D9086
To: broulik, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik updated this revision to Diff 23213.
broulik added a comment.
- Take into account that below we're adding 16 additional items from rawData
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9086?vs=23212=23213
REVISION DETAIL
rjvbb added a comment.
If you read
https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=381570 the
take-home message seems to be that the platform theme plugin (and KDE in
general) shouldn't be messing with setStyleName() at all UNLESS asking for a
font with properties that cannot
apol abandoned this revision.
apol added a comment.
Meh
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D9085
To: apol, #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.9/5/
Project:
Frameworks kpackage kf5-qt5 AndroidQt5.9
Date of build:
Fri, 01 Dec 2017 16:16:53 +
Build duration:
3 min 19 sec and counting
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9089
To: hein, #plasma, mart, garg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/156/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 01 Dec 2017 14:44:31 +
Build duration:
13 min and counting
mart accepted this revision.
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in colorscope.cpp:193
> check here.
this is when the item changes window and we're not sure we are still in the
same color set, so i think is ok to keep this signal
REPOSITORY
R242 Plasma
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in colorscope.cpp:193
> this is when the item changes window and we're not sure we are still in the
> same color set, so i think is ok to keep this signal
yeah, my point was we may /also/ need the colorsChanged signal (via
hein added a reviewer: garg.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9089
To: hein, #plasma, mart, garg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4779f9564a4a: Suppress unnecessary scroll indicators if
the flickable is a ListView with… (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
description needs updating with the new benefits (saving lookups every time)
INLINE COMMENTS
> colorscope.cpp:193
> if (value.window) {
> emit colorGroupChanged();
> }
check here.
REPOSITORY
R242 Plasma Framework (Library)
mart added a comment.
ah, you are right, yes, it should do checkcologgroupchanged instead
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8917
To: apol, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/39/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 01 Dec 2017 16:16:53 +
Build duration:
1 min 33 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Fri, 01 Dec 2017 16:16:53 +
Build duration:
6 min 9 sec and counting
JUnit Tests
hein created this revision.
hein added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
ListView.atYEnd is notoriously buggy and sometimes will cause indicators
to blink in and out of
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/10/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Fri, 01 Dec 2017 14:44:31 +
Build duration:
52 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/13/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Fri, 01 Dec 2017 14:44:31 +
Build duration:
52 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Fri, 01 Dec 2017 16:16:53 +
Build duration:
8 min 51 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks kdnssd kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 01 Dec 2017 17:34:54 +
Build duration:
40 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:b82e40fb2fc1: [KWindowEffectsPrivateX11] Add reserve()
call (authored by broulik).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9086?vs=23213=23236
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.7
Date of build:
Fri, 01 Dec 2017 21:35:46 +
Build duration:
10 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/39/
Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 01 Dec 2017 21:35:46 +
Build duration:
10 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
Date of build:
Fri, 01 Dec 2017 21:35:46 +
Build duration:
10 min and counting
JUnit Tests
dfaure added a comment.
Sounds to me like ~/foo should always mean $HOME/foo even if that doesn't
exist.
INLINE COMMENTS
> kurlnavigatortest.cpp:207
> +
> +QTest::newRow("relativeFile") << QStringLiteral(".some_dotfile") <<
> QUrl::fromUserInput(".some_dotfile", QLatin1String(""),
>
43 matches
Mail list logo