BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/17/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Mon, 11 Dec 2017 03:39:21 +
Build duration:
1 hr 0 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/18/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Mon, 11 Dec 2017 03:39:21 +
Build duration:
1 hr 16 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 11 Dec 2017 03:39:21 +
Build duration:
1 hr 53 min and counting
JUnit
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9223
To: broulik, #plasma, graesslin, apol
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mpyne added a comment.
OK, if no one else has objections I'd say to commit.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D9128
To: anthonyfieroni, leinir, dfaure, mpyne
Cc: mpyne, #frameworks
mpyne added a comment.
@aacid you might be thinking of my KI18n fix for ui*.h files in
https://phabricator.kde.org/D9118, but I'm sure there's other examples.
I'll point out that Kevin looked at my patch as well and recommended
something like `set_source_files_properties(${_header}
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:56a92cb8487c: Prevent global variables from been using
after freeing (authored by anthonyfieroni).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/29/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 11 Dec 2017 04:55:19 +
Build duration:
10 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/29/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Mon, 11 Dec 2017 03:39:28 +
Build duration:
16 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/29/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 11 Dec 2017 04:55:19 +
Build duration:
9 min 21 sec and counting
JUnit Tests
Name:
mlaurent added a comment.
@apol do you have cmake >= 3.10 ?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/25/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Mon, 11 Dec 2017 03:39:28 +
Build duration:
12 min and counting
JUnit
mlaurent added a comment.
@apol do you have an example of class which generate signal/slot ?
For me ARG_GENERATE_MOC seems to be the case and by default it skips AUTOMOC
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne,
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20SUSEQt5.7/10/
Project:
Frameworks kiconthemes kf5-qt5 SUSEQt5.7
Date of build:
Mon, 11 Dec 2017 07:11:39 +
Build duration:
5 min 2 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 11 Dec 2017 03:39:28 +
Build duration:
1 hr 32 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/27/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:23:24 +
Build duration:
8 min 31 sec and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/9/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:36:26 +
Build duration:
5 min 6 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/16/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:37:12 +
Build duration:
15 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/11/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:38:34 +
Build duration:
19 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:39:41 +
Build duration:
31 min and counting
JUnit Tests
Name:
cullmann added a comment.
In https://phabricator.kde.org/D8371#178009, @januz wrote:
> In https://phabricator.kde.org/D8371#177673, @cullmann wrote:
>
> > b) an extended unit test would be nice, to really show that the regex are
right.
>
>
> Hi, sure. Is there any documentation
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/16/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:39:51 +
Build duration:
1 hr 20 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 01:57:41 +
Build duration:
10 hr and counting
JUnit Tests
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
compile kmail without cmake warning
REPOSITORY
R237 KConfig
BRANCH
remove_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9277
mlaurent added reviewers: kfunk, dfaure.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: #frameworks
dfaure closed this revision.
dfaure added a comment.
https://commits.kde.org/kio/efeda6c1cc905913ef8cf587d966264d0135aba0
REVISION DETAIL
https://phabricator.kde.org/D8545
To: schwab, dfaure
Cc: wbauer, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:40:12 +
Build duration:
37 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:40:06 +
Build duration:
37 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/9/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:39:36 +
Build duration:
1 hr 0 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:40:12 +
Build duration:
1 hr 10 min and counting
JUnit Tests
dhaumann added a comment.
Btw: To update the reference, you can simply execute
build/frameworks/syntax-highlighting/autotests/update-reference-data.sh
Note, this script is in your *build* folder (not the git checkout folder).
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:40:06 +
Build duration:
1 hr 12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:36:47 +
Build duration:
11 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:37:30 +
Build duration:
26 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:39:11 +
Build duration:
24 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20WindowsMSVCQt5.9/19/
Project:
Frameworks frameworkintegration kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 10 Dec 2017 09:36:38 +
Build duration:
37 min and
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/14/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:37:12 +
Build duration:
49 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.9/16/
Project:
Frameworks kauth kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 10 Dec 2017 09:36:51 +
Build duration:
48 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:39:11 +
Build duration:
58 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/28/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:38:28 +
Build duration:
58 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/28/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:40:40 +
Build duration:
1 hr 6 min and counting
JUnit
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks kiconthemes kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 13:50:32 +
Build duration:
3 min 10 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20SUSEQt5.7/9/
Project:
Frameworks kiconthemes kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 15:19:00 +
Build duration:
1 min 0 sec and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:37:31 +
Build duration:
5 hr 43 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:39:11 +
Build duration:
6 hr 6 min and counting
JUnit Tests
aacid added a comment.
Wasn't this fixed recently in ecm? Or does kconfig needs an extra fix in
addition to the fix in ecm?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: aacid, #frameworks
elvisangelaccio marked an inline comment as done.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau, dfaure
Cc: apol, #frameworks
elvisangelaccio updated this revision to Diff 23725.
elvisangelaccio added a comment.
- Dropped TODO, there is not enough evidence that this method should become
protected.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8336?vs=23105=23725
BRANCH
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:39:36 +
Build duration:
6 hr 12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:38:34 +
Build duration:
5 hr 57 min and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsMSVCQt5.9/24/
Project:
Frameworks sonnet kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 10 Dec 2017 09:40:56 +
Build duration:
3 hr 47 min and counting
CONSOLE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:39:29 +
Build duration:
6 hr 9 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:39:41 +
Build duration:
6 hr 14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/28/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:38:28 +
Build duration:
37 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/9/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:47:56 +
Build duration:
33 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/24/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Sun, 10 Dec 2017 09:40:40 +
Build duration:
41 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks karchive kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:36:47 +
Build duration:
45 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:39:41 +
Build duration:
1 hr 2 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:37:30 +
Build duration:
1 hr 7 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/17/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Sun, 10 Dec 2017 09:39:51 +
Build duration:
2 hr 0 min and counting
JUnit Tests
rkflx added a comment.
In https://phabricator.kde.org/D8296#162352, @rkflx wrote:
> As mentioned in the bug, we should wait until after digiKam has had a
release containing the change, i.e. 5.8.0. Provoking the dreaded shortcut
warning dialog would be a bad way to say "thank you".
graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
INLINE COMMENTS
> broulik wrote in datadevicemanager.h:74
> Should `Ask` perhaps become a bigger number in case stuff gets added in the
> middle later like `Link` or is that
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:40:40 +
Build duration:
6 hr 50 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:39:51 +
Build duration:
7 hr 7 min and counting
JUnit Tests
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D9136
To: graesslin, #frameworks, #plasma, #kwin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
mlaurent added a comment.
it's seems that it was not fixed as I updated my kde last friday afternoon.
and this morning I was this problem.
And if it's fixed we need to remove this 2 lines
So it seems there is still a code to remove.
REPOSITORY
R237 KConfig
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 16:47:27 +
Build duration:
1 hr 8 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:40:06 +
Build duration:
6 hr 34 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 12:03:46 +
Build duration:
4 hr 37 min and counting
JUnit
broulik added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
lgtm
INLINE COMMENTS
> datadevice.cpp:177
> {
> +if (d->drag.offer) {
> +delete d->drag.offer;
`delete nullptr` is just fine
> datadevicemanager.h:74
> +Move = 1
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 10 Dec 2017 09:40:12 +
Build duration:
6 hr 44 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsMSVCQt5.9/25/
Project:
Frameworks sonnet kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 10 Dec 2017 17:16:14 +
Build duration:
1 min 35 sec and counting
JUnit Tests
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D9136
To: graesslin, #frameworks, #plasma, #kwin
Cc: ngraham, broulik, plasma-devel, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai,
On Tue, Dec 05, 2017 at 01:12:30PM +0100, David Faure wrote:
> On lundi 4 décembre 2017 17:04:25 CET Thiago Macieira wrote:
> > forking inside a signal handler is a bad idea because it may deadlock. If
> > the crash happens while glibc holds some mutexes relating to
> > pthread_atfork, then you'll
On Sunday, 3 December 2017 02:54:21 PST David Faure wrote:
> I'm trying to fix a bug (caught by CI) where KCrash, with the AutoRestart
> flag, restarts the crashing process directly (fork+execve) rather than via
> kdeinit.
>
> The first process then exits, and whenever the child writes to stderr,
apol added a comment.
+1
What's the plan here?
INLINE COMMENTS
> package.cpp:550
> +
> QResource::registerResource(dir.absoluteFilePath(QStringLiteral("contents.rcc")));
> +dir = QDir(QStringLiteral(":")+defaultPackageRoot()+path);
> +}
QLatin1Char(':')
apol added a comment.
In https://phabricator.kde.org/D9207#176322, @graesslin wrote:
> I'm against a risky change here. Especially as this becomes irrelevant with
Wayland.
What makes it risky?
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
BRANCH
AvoidAllocs (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9211
To: dhaumann, mwolff, apol
Cc: ngraham, #frameworks, kevinapavew, demsking, cullmann, sars,
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
INLINE COMMENTS
> searchproviderregistry.h:46
> +
> +QList findAll();
> +
Maybe QVector?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9213
apol added a comment.
Can you confirm that it still compiles properly in the cases where the class
generates signals/slots/properties?
In fact, kmail compiling properly doesn't say much to me.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent,
80 matches
Mail list logo
