BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 20:30:26 +
Build duration:
2 min 25 sec and counting
JUnit
elvisangelaccio removed a dependent revision: D9242: Implemented support for
hide/show groups.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
To: renatoo, mwolff
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 22:04:11 +
Build duration:
2 min 35 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 22:04:11 +
Build duration:
4 min 23 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 22:04:11 +
Build duration:
6 min 47 sec and counting
JUnit Tests
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Thanks!
INLINE COMMENTS
> helpers.h:23
> +
> +#ifndef KIO_HELPERS_H
> +#define KIO_HELPERS_H
This file should be called *_p.h to make it clear that it's not installed (and
On 12.12.2017 13:13, Kåre Särs wrote:
On måndag 11 december 2017 kl. 21:55:23 EET Albert Astals Cid wrote:
El dijous, 7 de desembre de 2017, a les 22:13:21 CET, Alexander Semke va
escriure:
Hi all,
https://bugs.kde.org/show_bug.cgi?id=387626
we've got this problem reported and I don't see
dfaure added a comment.
Hmm. I can see the usefulness, it's certainly much better than the way people
have historically inserted custom widgets into QFileDialog
(https://stackoverflow.com/questions/16987916/add-widgets-to-qfiledialog, URGH).
On the other hand, I'm wondering if this is
sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> KDEInstallDirs.cmake:699
> +if(INSTALL_PREFIX_SCRIPT)
> +file(WRITE ${CMAKE_BINARY_DIR}/prefix.sh "
> +export
This revision was automatically updated to reflect the committed changes.
Closed by commit R288:02053c0ff28f: Offer QWindow API for KJobWidgets::
decorators (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8923?vs=22686=23820#toc
REPOSITORY
R288 KJobWidgets
CHANGES
mvourlakos added a reviewer: mart.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9276
To: mvourlakos, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfilecustomdialogtest.h:30
> +public:
> +explicit KFileCustomDialogTest(QObject *parent = nullptr);
> +~KFileCustomDialogTest() = default;
not really
mvourlakos added a reviewer: mart.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9275
To: mvourlakos, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
cgiboudeaux added a comment.
+1. Please add the missing documentation about this new option.
INLINE COMMENTS
> apol wrote in KDEInstallDirs.cmake:700-704
> Usually isn't necessary as you get the libraries through the rpath. I can add
> it though.
It won't harm and solve potential issues if
bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Perfect. Lets get this committed.
REPOSITORY
R857 CI System Tooling
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9076
To: apol, #frameworks, bcooksley
Cc:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/7/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 03:59:02 +
Build duration:
2 min 26 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/18/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 03:59:02 +
Build duration:
3 min 12 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 03:59:02 +
Build duration:
3 min 13 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/17/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 20:30:26 +
Build duration:
4 min 3 sec and counting
JUnit Tests
anthonyfieroni updated this revision to Diff 23828.
anthonyfieroni added a comment.
Helper function in all over places.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9290?vs=23768=23828
REVISION DETAIL
https://phabricator.kde.org/D9290
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R857:235e202a1374: Have an application that can cross-check if
the promised platforms are correct (authored by apol).
REPOSITORY
R857 CI System Tooling
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:c688a15d871a: Improve apidox of KJobTrackerInterface
(authored by elvisangelaccio).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8336?vs=23725=23831
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 05:58:40 +
Build duration:
9 min 41 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/27/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 05:59:15 +
Build duration:
16 min and counting
CONSOLE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/14/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 05:58:52 +
Build duration:
18 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/9/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 05:58:40 +
Build duration:
16 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 05:58:52 +
Build duration:
25 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/18/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 05:59:05 +
Build duration:
27 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/19/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 05:59:05 +
Build duration:
38 min and counting
JUnit Tests
anthonyfieroni updated this revision to Diff 23843.
anthonyfieroni added a comment.
Rename function, remove variadic template, it still not needed
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9290?vs=23828=23843
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/12/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 05:58:52 +
Build duration:
10 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/9/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 05:58:40 +
Build duration:
11 min and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/31/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 05:59:15 +
Build duration:
19 min and counting
CONSOLE
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 05:58:50 +
Build duration:
23 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/32/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 05:58:50 +
Build duration:
24 min and counting
JUnit Tests
Name: (root)
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/28/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 06:37:17 +
Build duration:
1 min 9 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/32/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 06:37:17 +
Build duration:
3 min 27 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 05:59:05 +
Build duration:
44 min and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 05:59:15 +
Build duration:
46 min and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/29/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 06:52:48 +
Build duration:
3 min 29 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/33/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 06:52:48 +
Build duration:
5 min 2 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/88/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 13 Dec 2017 05:59:15 +
Build duration:
1 hr 9 min and counting
bcooksley added a comment.
Depending on the end goal of this you may wish to also set the following
environment variables:
CMAKE_PREFIX_PATH: to help guide CMake to look here in addition to system
prefixes
PKG_CONFIG_PATH: to help pkg-config find *.pc files
QMAKEFEATURES: to
anthonyfieroni added inline comments.
INLINE COMMENTS
> pathhelpers_p.h:31
> +{
> +if (!path1.endsWith(QLatin1Char('/'))) {
> +return path1 + QLatin1Char('/') + path2;
To be absolutely sure we can add pedantic check
if (!path1.endsWith('/') && !path2.startsWith('/'))
?
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 13:00:15 +
Build duration:
3 min 0 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 13:00:30 +
Build duration:
2 min 44 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 13:00:15 +
Build duration:
3 min 26 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 13:00:15 +
Build duration:
5 min 57 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/18/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 13:00:30 +
Build duration:
7 min 43 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/16/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 13:00:30 +
Build duration:
8 min 29 sec and counting
JUnit Tests
sitter created this revision.
sitter added a reviewer: ilic.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- strip shebang
- make -x
the script is run through add_custom_command with the explicit python
ilic accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9295
To: sitter, ilic
Cc: #frameworks
On måndag 11 december 2017 kl. 21:55:23 EET Albert Astals Cid wrote:
> El dijous, 7 de desembre de 2017, a les 22:13:21 CET, Alexander Semke va
>
> escriure:
> > Hi all,
> >
> > https://bugs.kde.org/show_bug.cgi?id=387626
> > we've got this problem reported and I don't see how to easily fix
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:54147ad2fc2d: do not treat ts-pmap-compile as exectuable
(authored by sitter).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9295?vs=23802=23803
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in DefaultListItemBackground.qml:23
> does this change kill this?
>
> If so +1000
ah, yes it does, will remove
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9287
To: mart,
mart marked 2 inline comments as done.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9287
To: mart, #plasma, bshah
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mart updated this revision to Diff 23809.
mart added a comment.
- fix deps
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9287?vs=23761=23809
BRANCH
arcpatch-D9287
REVISION DETAIL
https://phabricator.kde.org/D9287
AFFECTED FILES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D9287
REVISION DETAIL
https://phabricator.kde.org/D9287
To: mart, #plasma, bshah, davidedmundson
Cc: davidedmundson, plasma-devel,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 14:19:30 +
Build duration:
6 min 59 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 08:00:27 +
Build duration:
3 min 53 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 08:00:27 +
Build duration:
9 min 3 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/31/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 08:47:47 +
Build duration:
22 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 08:00:27 +
Build duration:
1 min 57 sec and counting
JUnit
bcooksley added a comment.
This can go in from my perspective, code looks fine from my understanding of
it.
In terms of 'All' as a platform, how is that handled? (assuming that's a
valid specification in the Frameworks metadata.yaml files)
REPOSITORY
R857 CI System Tooling
REVISION
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
OpenSuSE Leap 42.3:
$ ls -l /usr/share/pixmaps | wc -l
46
$ rpm -qf /usr/share/pixmaps/yast.png
yast2-control-center-3.1.6-3.3.x86_64
$ rpm -qil
davidedmundson added a comment.
> The description: "I'm not as sure on this..." and "but from code skimming I
can't see anything that
I went through this code thoroughly recently for a change I made.
We know we don't have any graphical widgets used anywhere; the use of
QGuiApplication
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 14:19:30 +
Build duration:
12 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b2f61f8e3c9f: disappearing scrollbars on mobile (authored
by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9287?vs=23809=23814
REVISION
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/30/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 14:43:10 +
Build duration:
2 min 12 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/26/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Tue, 12 Dec 2017 14:43:10 +
Build duration:
5 min 55 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 14:19:30 +
Build duration:
37 min and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/87/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 12 Dec 2017 14:43:10 +
Build duration:
15 min and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 14:43:10 +
Build duration:
32 min and counting
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REVISION SUMMARY
If enabled it will install a prefix.sh script to the root of the prefix.
This file will be
apol abandoned this revision.
apol added a comment.
`¯\_(ツ)_/¯`
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D9292
To: apol, #frameworks, dfaure
Cc: dfaure
apol added a comment.
In https://phabricator.kde.org/D9076#178587, @bcooksley wrote:
> This can go in from my perspective, code looks fine from my understanding
of it.
>
> In terms of 'All' as a platform, how is that handled? (assuming that's a
valid specification in the Frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau, dfaure
Cc: apol, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/31/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Tue, 12 Dec 2017 08:47:47 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/9/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 12 Dec 2017 08:47:47 +
Build duration:
30 min and counting
JUnit Tests
Name: (root)
cgiboudeaux added inline comments.
INLINE COMMENTS
> KDEInstallDirs.cmake:700-704
> +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS
> +export XDG_CONFIG_DIRS=${KDE_INSTALL_FULL_CONFDIR}:$XDG_CONFIG_DIRS
> +export PATH=${KDE_INSTALL_FULL_BINDIR}:$PATH
> +export
apol added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in KDEInstallDirs.cmake:700-704
> missing LD_LIBRARY_PATH ?
Usually isn't necessary as you get the libraries through the rpath. I can add
it though.
> cgiboudeaux wrote in KDEInstallDirs.cmake:707
> I'm not sure that's the right
mlaurent added a comment.
@kfunk what do you think about it ? :)
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
82 matches
Mail list logo
