D1231: Add Remote Access interface to KWayland

2018-01-26 Thread Oleg Chernovskiy
Kanedias updated this revision to Diff 25976. Kanedias edited the test plan for this revision. Kanedias added a comment. - Add RemoteAccess interface to KWayland - Merge branch - Fix compilation warnings uint -> int REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D10124: Faster simplejob start

2018-01-26 Thread Jaime Torres Amate
jtamate added a comment. F5675857: kcioclient5_move_2000_files_old_connect.png F5675856: kcioclient5_move_2000_files_partly_connect.png From spending 11.65% to 7.06% REPOSITORY R241 KIO REVISION

D10124: Faster simplejob start

2018-01-26 Thread Anthony Fieroni
anthonyfieroni added a comment. Is there any problems to change other connects too? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks Cc: anthonyfieroni

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Igor Janssen
ijanssen added reviewers: Plasma, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: plasma-devel, #frameworks, ZrenBot,

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach
michaelh added a dependent revision: D10119: Create test to assert metaDataRequestFinished is emitted once only. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 80 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/80/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 26 Jan 2018 13:25:53 + Build duration: 1 hr 26 min and counting JUnit Tests Name:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 26 Jan 2018 14:50:59 + Build duration: 6 min 25 sec and counting

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Dominik Haumann
dhaumann added a comment. The version needs to be increased from 6 to 7. Besides this, the patch looks good. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Igor Janssen
ijanssen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ijanssen requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=382437 //One cause of the bug is commit at

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Igor Janssen
ijanssen edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen Cc: #frameworks

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Kai Uwe Broulik
broulik added a comment. Yes, please! I agree that shared-mime-info must be fixed to remove the `.bin` extension but this will take forever and this is a serious regression preventing any novice user from downloading files properly. REPOSITORY R241 KIO REVISION DETAIL

D10092: [Examples] Fix build

2018-01-26 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:595fd8805430: [Examples] Fix build (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10092?vs=25923=25992 REVISION DETAIL

D10077: [Default Tooltip] Fix sizing

2018-01-26 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f31e7860d98f: [Default Tooltip] Fix sizing (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10077?vs=25885=25993 REVISION

D10124: Faster simplejob start

2018-01-26 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Changing only 4 of the signals connections to the new syntax almost doubles the spped of simplejob::start in a

D10124: Faster simplejob start

2018-01-26 Thread Jaime Torres Amate
jtamate added a comment. In https://phabricator.kde.org/D10124#196534, @anthonyfieroni wrote: > Is there any problems to change other connects too? There is only one problem, that I do not know how to do it. REPOSITORY R241 KIO REVISION DETAIL

D10113: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: elvisangelaccio, smithjd, vhanda, ngraham, Dolphin, Frameworks. michaelh requested review of this revision. REVISION SUMMARY Add signal 'dataAvailable' to allow chunkwise data processing Emit metaDataRequestFinished when request

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 29 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 26 Jan 2018 14:50:59 + Build duration: 8 min 36 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 56 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/56/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Fri, 26 Jan 2018 14:50:59 + Build duration: 9 min 35 sec and counting

D10113: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach
michaelh added a dependency: D10105: baloo-widgets: Refactor filemetadataprovider for better readability. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

2018-01-26 Thread Michael Heidelbach
michaelh added a dependent revision: D10113: Emit metaDataRequestFinished once per request. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D10105 To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10124: Faster simplejob start

2018-01-26 Thread Anthony Fieroni
anthonyfieroni added a comment. This -> https://wiki.qt.io/New_Signal_Slot_Syntax#Overload REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks Cc: ngraham, anthonyfieroni

D10124: Faster simplejob start

2018-01-26 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > simplejob.cpp:142 > > q->connect(slave, SIGNAL(infoMessage(QString)), > SLOT(_k_slotSlaveInfoMessage(QString))); Try something along the lines of q->connect(slave, ::infoMessage, q, std::bind(::_k_slotSlaveInfoMessage,

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach
michaelh retitled this revision from "Emit metaDataRequestFinished once per request" to "baloo-widgets: Emit metaDataRequestFinished once per request". REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham,

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 26 Jan 2018 19:34:42 + Build duration: 8 min 46 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 57 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/57/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Fri, 26 Jan 2018 19:34:42 + Build duration: 7 min 58 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 26 Jan 2018 19:34:42 + Build duration: 11 min and counting

D10106: Relocate the Baloo database to the XDG cache location.

2018-01-26 Thread Michael Heidelbach
michaelh added a comment. The way I use baloo the DB is not easily recreated at all. 1. Indexing takes around 2hrs. 2. On top of that I have to make a lot of manual adjustments due some bugs in baloo. That takes about another hour. In my view a cache is for faster access of data

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Albert Astals Cid
aacid added a comment. autotest possible? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10077: [Default Tooltip] Fix sizing

2018-01-26 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10077 To: broulik, #plasma, #vdg, mart Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Andres Betts
abetts added a comment. Is this change purely a conversation of what developers use in code to call up fonts in their applications? Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something like System Settings that

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9332: Allow filter places based on alternative application name

2018-01-26 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R241:fc1f2fe296d6: Allow filter places based on alternative application name (authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Bart Ribbers
PureTryOut updated this revision to Diff 25985. PureTryOut added a comment. Updated the version from 6 to 7 REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10072?vs=25871=25985 REVISION DETAIL https://phabricator.kde.org/D10072 AFFECTED

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Nathaniel Graham
ngraham added a comment. Does anyone have strong objections to landing this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: anthonyfieroni, ngraham, cfeck,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot,

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sat, 27 Jan 2018 04:01:29 + Build duration: 3 min 3 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 9 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Sat, 27 Jan 2018 04:01:29 + Build duration: 5 min 15 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

2018-01-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 27 Jan 2018 04:01:29 + Build duration: 2 min 53 sec and counting JUnit Tests