davidedmundson added a comment.
> so in that case would be a problem that potentially could come up elsewhere
as would make the logic of managedtexturenode not completely correct in those
edge cases
Textures will never be deleted by anyone else.
Docs say:
> Warning: The
lshoravi updated this revision to Diff 26573.
lshoravi edited the summary of this revision.
lshoravi added a comment.
Updated author as per ngrahams suggestion. Diff updated for latest framework
(assuming that it turned out correctly.)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20WindowsMSVCQt5.9/29/
Project:
Frameworks kxmlgui kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 05 Feb 2018 10:20:58 +
Build duration:
41 min and counting
JUnit Tests
jtamate added a comment.
False alarm. :-)
Do not know what caused it, but after a complete kdesrc-build, the leak is
gone.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10124
To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Makes sense imho.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10319
To: broulik, #frameworks, franckarrecot, renatoo, markg
Cc: markg, michaelh, ngraham
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/31/
Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 05 Feb 2018 08:11:53 +
Build duration:
1 hr 36 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.9/18/
Project:
Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:55 +
Build duration:
2 hr 21 min and counting
Hi,
Am Sonntag, 4. Februar 2018, 23:47:26 CET schrieb Albert Astals Cid:
> So we're having KF5 5.43 next week, has this been figured out?
not quite, but it's on the right track (unlikely for 5.43 though). See below.
Cheers,
Fabian
> I find this thread ended too open ended for my taste.
>
>
mart added a comment.
In https://phabricator.kde.org/D10250#199624, @davidedmundson wrote:
> Good analysis on the plotter. Thanks for looking into it.
>
> > but in some rare cases, it can be deleted too by some external cause,
usually when a widget changes its parent
>
> If
markg added a comment.
+1 for the idea, just a question about the key.
Windows uses ALT+P:
https://lifehacker.com/5811238/quickly-show-the-preview-pane-in-windows-7-with-alt-%252B-p
I don't know what Finder uses, you can probably tell ;)
As it stands now, i'd go for ALT+P. It also
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8fe54f5b4e56: [KFilePlacesModel] Group network shares
under Remote category (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10319?vs=26567=26582
ngraham updated this revision to Diff 26584.
ngraham removed a reviewer: markg.
ngraham added a comment.
This revision now requires review to proceed.
Fix "ambiguous shortcut" issue by using plain old QKey instead of QKeySequence
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D10314#201388, @ngraham wrote:
> I use F11 to be consistent with Dolphin, where F11 toggles the information
panel. It's not //exactly// the same thing, but
markg added a comment.
In https://phabricator.kde.org/D10314#201419, @ngraham wrote:
> Fixed it!
>
> Changing Dolphin to Alt-P would open a can of worms since the other panels
are triggered with Function keys, so I think F11 makes sense here.
Nice!
That could indeed be a
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/95/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 14:09:41 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/115/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 14:09:41 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
ngraham added a comment.
I use F11 to be consistent with Dolphin, where F11 toggles the information
panel. It's not //exactly// the same thing, but I figured re-using existing KDE
muscle memory was worthwhile. Alt-P could work too though, and would probably
conflict less. Easier to type on
markg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: markg, michaelh, ngraham
dfaure added inline comments.
INLINE COMMENTS
> fileundomanager.cpp:404
> +} else if (commandType == FileUndoManager::Copy) {
> +d->slotLock();
> +return;
Where's the corresponding call to slotUnlock?
I think you only wanted to update the state of the action, maybe better
lshoravi updated this revision to Diff 26574.
lshoravi added a comment.
And with that said, I specified the wrong revision in arc. This should be the
correct diff.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10305?vs=26573=26574
cfeck resigned from this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma, #plasma_accessibility
Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai, ali-mohamed,
ngraham accepted this revision.
ngraham added a comment.
Excellent.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10319
To: broulik, #frameworks, franckarrecot, renatoo, markg, ngraham
Cc: ngraham, markg, michaelh
ngraham added a comment.
Fixed it!
Changing Dolphin to Alt-P would open a can of worms since the other panels
are triggered with Function keys, so I think F11 makes sense here.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/114/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 14:09:41 +
Build duration:
11 min and counting
JUnit Tests
Name: (root)
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:889c0a96bc65: Export kconf_update with tooling (authored
by apol).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/116/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 15:07:46 +
Build duration:
6 min 15 sec and counting
JUnit Tests
Name:
broulik added a comment.
> Shouldn't this be controlled by System Settings > Application Style >
Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels?
If that option is enabled you get a frame even with this patch. Otherwise,
the default, is nice and clean.
ltoscano reopened this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
Let phabricator close it...
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, markg, michaelh,
ltoscano closed this revision.
ltoscano added a comment.
Too late.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, markg, michaelh, ngraham
ngraham added a comment.
Hmm, I thought I did. I just did a standard `arc land`.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, markg, michaelh, ngraham
ltoscano added a comment.
Interesting, it seems that phabricator updated the link to the commit, but
did not close the bug. Let's ignore it, unless it happens again.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano,
markg added a comment.
Why does it show the panel as if it were unlocked?
Your before image looks exactly like an unlocked frame in Dolphin.
Would it be possible to show it as if it were locked? That would solve all
the issues with it, right?
REPOSITORY
R241 KIO
REVISION DETAIL
ngraham closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: markg, michaelh, ngraham
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/96/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 15:07:46 +
Build duration:
10 min and counting
JUnit Tests
Name: (root)
broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This avoids a double "Places" header
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/115/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 15:07:46 +
Build duration:
12 min and counting
JUnit Tests
Name: (root)
ngraham added a comment.
Shouldn't this be controlled by System Settings > Application Style > Widget
Style > Breeze > Configure > Frames > Draw Frame around Dockable panels?
Otherwise, people who check that setting will have a visible frame around the
Places panel in Dolphin, but not in
ngraham added a comment.
OK, great.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks
Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mart added a comment.
> However, because it's in a managed texture node, it will get deleted when
the node dies.
> The node definitely will be killed when you switch window.
>
> *if* that's the case you're hitting, you're guarding the wrong thing, and
will need to guard the node not
broulik created this revision.
broulik added reviewers: VDG, Frameworks.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
Avoids letting the menu get huge. This is a straight port from Plasma's task
manager
mart updated this revision to Diff 26596.
mart added a comment.
different approach
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10250?vs=26373=26596
BRANCH
phab/guardTexture2
REVISION DETAIL
https://phabricator.kde.org/D10250
AFFECTED FILES
davidedmundson added a comment.
My valgrind, using your test instructions is showing it is.
at 0x75B5D3C: texture (qsgtexturematerial.h:58)
by 0x75B5D3C: QSGSimpleTextureNode::texture() const
(qsgsimpletexturenode.cpp:264)
by 0x26044983: Plotter::render()
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
phab/guardTexture2
REVISION DETAIL
https://phabricator.kde.org/D10250
To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, ngraham, plasma-devel,
mart retitled this revision from "track the validity of the texture" to
"disconnect render() on window change".
mart edited the summary of this revision.
REPOSITORY
R296 KDeclarative
BRANCH
phab/guardTexture2
REVISION DETAIL
https://phabricator.kde.org/D10250
To: mart, #plasma,
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:2617a2ab9d47: disconnect render() on window change
(authored by mart).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10250?vs=26596=26597
REVISION DETAIL
broulik updated this revision to Diff 26598.
broulik added a comment.
- Install middle click for new tab event filter also on sub menu
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10329?vs=26595=26598
REVISION DETAIL
https://phabricator.kde.org/D10329
broulik added a comment.
Just some minor points, feel free to ignore
INLINE COMMENTS
> plotter.cpp:288
> setFlag(ItemHasContents);
> +connect(this, ::windowChanged, this, [this]() {
> +if (m_window) {
Override `QQuickItem::itemChange` instead of a `connect`
>
graesslin added a comment.
I'm a little bit late to the party, but F11is kind of the standard key for
fullscreen.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: graesslin, ltoscano, markg, michaelh, ngraham
ngraham accepted this revision as: VDG.
ngraham added a comment.
Strongly approve. This improves organization, prevents the menu from becoming
huge when there are a lot of items, and also eliminates one objection to
https://phabricator.kde.org/D10245.
REPOSITORY
R241 KIO
REVISION DETAIL
rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.
I rebased and was just about to land this, but found a serious problem:
Accepting via OK, double clicking or [Enter] will only work if you have typed
at least a single character.
ngraham added a comment.
Yeah, and Dolphin already overloads that by using F11 to show and hide the
Information panel. I wouldn't object to using a different keyboard shortcut,
but then we'd want to but we'd want to do it for all of for Dolphin's panels,
and change the shortcuts here, too,
graesslin added a comment.
In https://phabricator.kde.org/D10314#201553, @ngraham wrote:
> Yeah, and Dolphin already overloads that by using F11 to show and hide the
Information panel. I wouldn't object to using a different keyboard shortcut,
but then we'd want to but we'd want to do it
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/47/
Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:09:59 +
Build duration:
1 min 38 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/49/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:09:59 +
Build duration:
2 min 40 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/49/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:09:59 +
Build duration:
6 min 42 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/30/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:10:13 +
Build duration:
11 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/16/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:10:06 +
Build duration:
14 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/43/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:10:44 +
Build duration:
19 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/26/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:10:56 +
Build duration:
21 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/27/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:10:44 +
Build duration:
20 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/21/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:10:56 +
Build duration:
25 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:11:28 +
Build duration:
25 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/16/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:12:09 +
Build duration:
30 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/22/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:11:57 +
Build duration:
29 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:11:28 +
Build duration:
32 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/14/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:12:11 +
Build duration:
34 min and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/94/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:11:34 +
Build duration:
39 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/13/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:12:27 +
Build duration:
38 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/59/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:12:39 +
Build duration:
40 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/17/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:24:55 +
Build duration:
32 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/38/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Mon, 05 Feb 2018 08:12:14 +
Build duration:
48 min and counting
JUnit Tests
lshoravi edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma, #plasma_accessibility, cfeck
Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/16/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:11:57 +
Build duration:
49 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:05 +
Build duration:
51 min and counting
JUnit Tests
Name:
lshoravi edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma, #plasma_accessibility, cfeck
Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/8/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:09 +
Build duration:
53 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/9/
Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:11 +
Build duration:
56 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/31/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:10:13 +
Build duration:
56 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/38/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:10:44 +
Build duration:
1 hr 1 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:11:28 +
Build duration:
1 hr 2 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:16 +
Build duration:
1 hr 3 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/24/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:14 +
Build duration:
1 hr 3 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/22/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:11:57 +
Build duration:
1 hr 5 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/16/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:12:09 +
Build duration:
1 hr 8 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/27/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:10:56 +
Build duration:
1 hr 9 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/13/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:12:11 +
Build duration:
1 hr 10 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/24/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:23 +
Build duration:
1 hr 13 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/62/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:12:39 +
Build duration:
1 hr 20 min and counting
JUnit
broulik created this revision.
broulik added reviewers: Frameworks, franckarrecot, renatoo.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
If you add network shares in e.g. fstab, they would show up as "Devices"
rather than
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/39/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Mon, 05 Feb 2018 08:12:14 +
Build duration:
1 hr 26 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/35/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 05 Feb 2018 08:12:39 +
Build duration:
1 hr 29 min and counting
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
Does the same as K_PLUGIN_FACTORY_WITH_JSON but saves you typing the class
name twice.
If you
ngraham accepted this revision as: ngraham.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
apol added a comment.
+1
I'd welcome that. I always found odd to have to invent a name that wouldn't
be required on the rest of the program.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10333
To: aacid
Cc: apol, #frameworks, michaelh, ngraham
cullmann added a comment.
I think beside the
> I think the old code tried to ensure we only add word-boundary if we still
can find the string then. e.g. if the string that you highlight contains spaces
or stuff like that at the borders, you don't add \b.
all other comments are just
zzag added a comment.
In https://phabricator.kde.org/D10245#201640, @ngraham wrote:
> I think we could make Search For a hidden category in Dolphin (once the UI
is better) and remove it entirely from the Save dialog.
Do we really need Serach for? It looks like a dirty hack.
ngraham added a comment.
In https://phabricator.kde.org/D10245#201731, @zzag wrote:
> In https://phabricator.kde.org/D10245#201640, @ngraham wrote:
>
> > I think we could make Search For a hidden category in Dolphin (once the
UI is better) and remove it entirely from the Save dialog.
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: graesslin, ltoscano, markg, michaelh, ngraham
dhaumann added a comment.
This fixes bug https://bugs.kde.org/show_bug.cgi?id=389307 at least
partially. More languages such as Ruby etc can still be added.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7864
To: gszymaszek,
cullmann added a comment.
If the new highlighting better covers what CMake has around on features now
than the old, I am for adding the new one.
If the generator is optimal or not is an other thing, but as long as we would
just check in the result and have the generator as addition to
1 - 100 of 104 matches
Mail list logo
