D10365: New icon for Elisa music player

2018-02-09 Thread Alexander Stippich
astippich added a comment. I was a little bit hesitant at first, but I'm starting to like the idea of a cassette as an icon for Elisa. But I think the text in the icon is not required. It will usually be so small that no-one can read it. Anyways, Matthieu should have a comment about this.

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-09 Thread Jaime Torres Amate
jtamate added a comment. Just to let you know that I know how to reproduce the high I/O of plasmashell and continuous calls to Kservice. You can reproduce it just having opened the vivaldi web browser. (I never though it could be a problem). If it goes to a webpage that still uses flash,

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread René J . V . Bertin
Friedrich W. H. Kossebau wrote: Hi, > So all the PNG versions are there as handcrafted optimized versions of their > SVG counterpart, so the icons are still usable when needed in sizes of > 16,22,24,32,48,... Isn't that an answer to the question "why are there also png icons" (or to "why are

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread Rex Dieter
René J. V. Bertin wrote: >> So all the PNG versions are there as handcrafted optimized versions of >> their SVG counterpart, so the icons are still usable when needed in sizes >> of 16,22,24,32,48,... > > Isn't that an answer to the question "why are there also png icons" (or to > "why are so

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-09 Thread Mark Gaiser
markg marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: apol, #frameworks, michaelh, ngraham

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread Friedrich W. H. Kossebau
Adding Andreas as cc:, given he semi-maintains the oxygen icons. Am Freitag, 9. Februar 2018, 17:49:54 CET schrieb René J. V. Bertin: > Friedrich W. H. Kossebau wrote: > > Am Freitag, 9. Februar 2018, 10:07:35 CET schrieb René J.V. Bertin: > > > Two questions arise: > > > - why are they there so

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread René J . V . Bertin
Rex Dieter wrote: > I'm not aware of fedora providing any such thing. I still had the link in my terminal scrollback: http://ftp.gwdg.de/pub/opensuse/tumbleweed/repo/oss/suse/noarch/oxygen5-icon-theme-scalable-5.42.0-1.1.noarch.rpm R

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread René J . V . Bertin
Friedrich W. H. Kossebau wrote: > Too focussed on the second question, I missed this one. Hm, doing a quick > incomplete ls -1 | wc -l on some categories I would rather see more PNG files > per size than SVG files. You're right actually, I see now that I missed directory level in one of my own

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-09 Thread Mark Gaiser
markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Adds move semantics support and a testcase (only useful in

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-09 Thread Mark Gaiser
markg added a comment. Just a note. The fact that currently no code is structured in a way that move semantics are used is... slightly annoying ;) No as in not when running dolphin with it and profiling it to see UDSEntry uses. There "might" be code that uses move semantics when this

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-09 Thread Mark Gaiser
markg updated this revision to Diff 26838. markg added a comment. Fix indentation. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26836=26838 BRANCH udsentry_move REVISION DETAIL https://phabricator.kde.org/D10414 AFFECTED FILES

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-09 Thread Mark Gaiser
markg updated this revision to Diff 26839. markg added a comment. Remove comment about compiler generated functions. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26838=26839 BRANCH udsentry_move REVISION DETAIL

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-09 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > udsentry.cpp:95 > +// Default implementations for: > +// - Copy constructor > +// - Move constructor This comment is very confusing, especially considering that the order you used there isn't the same as the ones below. I'd just remove it all.

D10365: New icon for Elisa music player

2018-02-09 Thread Paul Lesur
paullesur added a comment. In https://phabricator.kde.org/D10365#203432, @astippich wrote: > I was a little bit hesitant at first, but I'm starting to like the idea of a cassette as an icon for Elisa. But I think the text in the icon is not required. It will usually be so small that

D10409: In linux don't use abstract socket to share file descriptor

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 26830. chinmoyr added a comment. Added back "/tmp/" prefix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=26828=26830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 AFFECTED FILES

D10273: Create proper SocketAddress

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D10409: In linux don't use abstract socket to share file descriptor. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks Cc: ossi, thiago, dfaure, michaelh, ngraham

D10141: Restore Persistence=session for the file ioslave kauth helper

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In https://phabricator.kde.org/D10141#197039, @fvogt wrote: > There is one issue I have with this. While this is close to the `sudo`-mode of temporary authorization grants, it doesn't work that way as the whole session has full access via file.so. How

D10409: In linux don't use abstract socket to share file descriptor

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: Frameworks, ossi. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Use pathname socket for better security. The socket path will be provided by file ioslave. Depends

D10411: Create socket file in user's runtime directory

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: Frameworks, ossi. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY "/tmp" is world writable so creating socket there is a bad idea. Instead create socket in user's

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D10411: Create socket file in user's runtime directory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi Cc: michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. Is the patch good enough to be pushed? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D6198: Add KAuth support to delete operation

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6198 To: chinmoyr, elvisangelaccio, #frameworks Cc: fvogt, dfaure, davidedmundson, michaelh, ngraham

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: Frameworks, ossi. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY The class SocketAddress is meant only for creating a proper socket address structure. It should not be

D10409: In linux don't use abstract socket to share file descriptor

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

2018-02-09 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame,

D10141: Restore Persistence=session for the file ioslave kauth helper

2018-02-09 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D10141#203664, @fvogt wrote: > In https://phabricator.kde.org/D10141#203545, @chinmoyr wrote: > > > In https://phabricator.kde.org/D10141#197039, @fvogt wrote: > > > > > There is one issue I have with this. While this is close

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

2018-02-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 09 Feb 2018 23:23:51 + Build duration: 9 min 55 sec and counting JUnit

D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

2018-02-09 Thread Albert Astals Cid
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R244:97ca9ee095cd: Introduce K_PLUGIN_CLASS_WITH_JSON (authored by aacid). CHANGED PRIOR TO COMMIT

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread kainz.a
Hi all together, first, yes I'm the maintainer of oxygen-icons5 and there are png file the the origin svgz files. I don't know how the svg rendering work in plasma, BUT the svg folder is 350 mb in size the png ones are 34 mb. I don't think it's a good idea to use the svgz icons. And here is the

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-02-09 Thread Igor Janssen
ijanssen added a comment. In https://phabricator.kde.org/D10114#202694, @ngraham wrote: > Is this committable? I think yes REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel,

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread Rex Dieter
René J. V. Bertin wrote: > Rex Dieter wrote: > >> I'm not aware of fedora providing any such thing. > > I still had the link in my terminal scrollback: > http://ftp.gwdg.de/pub/opensuse/tumbleweed/repo/oss/suse/noarch/oxygen5-icon-theme-scalable-5.42.0-1.1.noarch.rpm That's an opensuse rpm,

D10416: When initialize devicePixelRatio when rendering into a pixmap

2018-02-09 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > Fixes rendering of svg in many places, for example now icons don't look By editing FrameSVG? That seems unlikely. I think you've got some results mixed

D10141: Restore Persistence=session for the file ioslave kauth helper

2018-02-09 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D10141#203726, @aacid wrote: > In https://phabricator.kde.org/D10141#203664, @fvogt wrote: > > > In https://phabricator.kde.org/D10141#203545, @chinmoyr wrote: > > > > > In https://phabricator.kde.org/D10141#197039, @fvogt

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-02-09 Thread Nathaniel Graham
ngraham added a comment. It doesn't merge cleanly on master. Can you re-base it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

2018-02-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 09 Feb 2018 23:23:51 + Build duration: 5 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 41 - Still Unstable!

2018-02-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/41/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Fri, 09 Feb 2018 23:23:51 + Build duration: 17 min and counting JUnit Tests

D10416: When initialize devicePixelRatio when rendering into a pixmap

2018-02-09 Thread Aleix Pol Gonzalez
apol added a comment. This breaks the rendering of buttons (exclusively, as long as I've seen), any idea why? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10416 To: apol, #plasma Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham,

D10141: Restore Persistence=session for the file ioslave kauth helper

2018-02-09 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D10141#203545, @chinmoyr wrote: > In https://phabricator.kde.org/D10141#197039, @fvogt wrote: > > > There is one issue I have with this. While this is close to the `sudo`-mode of temporary authorization grants, it doesn't work

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-09 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D9840#203563, @jtamate wrote: > Just to let you know that I know how to reproduce the high I/O of plasmashell and continuous calls to Kservice. > You can reproduce it just having opened the vivaldi web browser. (I never though

D10365: New icon for Elisa music player

2018-02-09 Thread Diego Gangl
januz added a comment. Agree with the text not being useful for small sizes, but it could look good for a large logo-style image (like say, a 256px logo on the wiki/homepage). A cassette is definitely an interesting idea for an icon. At least it's not another musical note or play icon

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

2018-02-09 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. apol requested review of this revision. REVISION SUMMARY On wayland (at least) it's initialized when the

D10416: When initialize devicePixelRatio when rendering into a pixmap

2018-02-09 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. https://phabricator.kde.org/D10420 this one works better. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10416 To: apol, #plasma, davidedmundson Cc: davidedmundson, ngraham, plasma-devel,

D10416: When initialize devicePixelRatio when rendering into a pixmap

2018-02-09 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. apol requested review of this revision. REVISION SUMMARY Plasma::Svg uses this information to know the pixel

D8351: API dox: add note about calling setApplicationDomain after QApp creation

2018-02-09 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R249:9ae1a9b2e923: API dox: add note about calling setApplicationDomain after QApp creation (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8351?vs=20928=26851#toc

what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread René J . V . Bertin
Hi, I just discover that the huge source tarball size of the oxygen-icons5 theme is not a result of it using png icons, but of an enormous collection of SVG icons. Two questions arise: - why are they there so many more than there are png icons (= what are they used for)? - where are the

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-09 Thread Eike Hein
hein updated this revision to Diff 26821. hein added a comment. Remove unrelated changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10405?vs=26820=26821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10405 AFFECTED FILES

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread Friedrich W. H. Kossebau
Am Freitag, 9. Februar 2018, 10:07:35 CET schrieb René J.V. Bertin: > I just discover that the huge source tarball size of the oxygen-icons5 theme > is not a result of it using png icons, but of an enormous collection of SVG > icons. > > Two questions arise: > - why are they there so many more

Re: what about the scalable subdir in the oxygen-icons5 sources?

2018-02-09 Thread Friedrich W. H. Kossebau
Am Freitag, 9. Februar 2018, 14:11:34 CET schrieb Friedrich W. H. Kossebau: > Am Freitag, 9. Februar 2018, 10:07:35 CET schrieb René J.V. Bertin: > > - where are the instructions on how to install (only) the > > scalable version? Oh, my reply was done for a "how to install only" question, forgot

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-09 Thread Eike Hein
hein added a comment. Argh, sorry for the noisy diff, I didn't do commit -a but arc did I guess ... I'll clean this up, one sec. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart Cc: #frameworks, michaelh, ngraham

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-09 Thread Eike Hein
hein created this revision. hein added reviewers: dfaure, davidedmundson, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. hein requested review of this revision. REVISION SUMMARY Without this patch, runCommandInternal tries

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-09 Thread Marco Martin
mart added a comment. +1 from me REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart Cc: #frameworks, michaelh, ngraham